github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 22:08:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15314 from atom/as-stop-ime-input-on-prevent-default

Browse Source 
Suppress text input for default-prevented keydown events
This commit is contained in:
Nathan Sobo
2017-08-15 10:13:40 -06:00
committed by GitHub
parent 7226f6fb08 37274d3365
commit 360f89e33a
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/text-editor-component.js
View File

@@ -1574,10 +1574,6 @@ class TextEditorComponent {
}
didTextInput (event) {
// Workaround for Chromium not preventing composition events when
// preventDefault is called on the keydown event that precipitated them.
if (this.lastKeydown && this.lastKeydown.defaultPrevented) return
if (!this.isInputEnabled()) return
event.stopPropagation()
@@ -1670,7 +1666,16 @@ class TextEditorComponent {
didCompositionUpdate (event) {
// Workaround for Chromium not preventing composition events when
// preventDefault is called on the keydown event that precipitated them.
if (this.lastKeydown && this.lastKeydown.defaultPrevented) return
if (this.lastKeydown && this.lastKeydown.defaultPrevented) {
this.getHiddenInput().disabled = true
process.nextTick(() => {
// Disabling the hidden input makes it lose focus as well, so we have to
// re-enable and re-focus it.
this.getHiddenInput().disabled = false
this.getHiddenInput().focus()
})
return
}
if (this.getChromeVersion() === 56) {
process.nextTick(() => {