github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Honor the isLineNumberGutterVisible option

Browse Source
This commit is contained in:
Nathan Sobo
2017-03-16 21:48:07 -06:00
committed by Antonio Scandurra
parent 88b30bc4dc
commit 36f5262f40
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/text-editor-component-spec.js
View File

@@ -257,6 +257,11 @@ describe('TextEditorComponent', () => {
expect(element.offsetHeight).toBeGreaterThan(initialHeight)
})
it('supports the isLineNumberGutterVisible parameter', () => {
const {component, element, editor} = buildComponent({lineNumberGutterVisible: false})
expect(element.querySelector('.line-number')).toBe(null)
})
describe('mini editors', () => {
it('adds the mini attribute', () => {
const {element, editor} = buildComponent({mini: true})
@@ -1351,6 +1356,7 @@ function buildComponent (params = {}) {
if (params.mini != null) editorParams.mini = params.mini
if (params.autoHeight != null) editorParams.autoHeight = params.autoHeight
if (params.autoWidth != null) editorParams.autoWidth = params.autoWidth
if (params.lineNumberGutterVisible != null) editorParams.lineNumberGutterVisible = params.lineNumberGutterVisible
const editor = new TextEditor(editorParams)
const component = new TextEditorComponent({
model: editor,

5
src/text-editor-component.js
View File

@@ -240,11 +240,14 @@ class TextEditorComponent {
}
renderLineNumberGutter () {
const model = this.getModel()
if (!model.isLineNumberGutterVisible()) return null
if (this.currentFrameLineNumberGutterProps) {
return $(LineNumberGutterComponent, this.currentFrameLineNumberGutterProps)
}
const model = this.getModel()
const maxLineNumberDigits = Math.max(2, model.getLineCount().toString().length)
if (this.measurements) {