🔥 Remove deprecations from Package

spec/package-manager-spec.coffee

@@ -174,24 +174,6 @@ describe "PackageManager", ->
           expect(atom.config.set('package-with-config-schema.numbers.one', '10')).toBe true
           expect(atom.config.get('package-with-config-schema.numbers.one')).toBe 10
 
-      describe "when a package has configDefaults", ->
-        beforeEach ->
-          jasmine.snapshotDeprecations()
-
-        afterEach ->
-          jasmine.restoreDeprecationsSnapshot()
-
-        it "still assigns configDefaults from the module though deprecated", ->
-
-          expect(atom.config.get('package-with-config-defaults.numbers.one')).toBeUndefined()
-
-          waitsForPromise ->
-            atom.packages.activatePackage('package-with-config-defaults')
-
-          runs ->
-            expect(atom.config.get('package-with-config-defaults.numbers.one')).toBe 1
-            expect(atom.config.get('package-with-config-defaults.numbers.two')).toBe 2
-
       describe "when the package metadata includes `activationCommands`", ->
         [mainModule, promise, workspaceCommandListener, registration] = []
 

src/package.coffee

@@ -6,7 +6,6 @@ async = require 'async'
 CSON = require 'season'
 fs = require 'fs-plus'
 {Emitter, CompositeDisposable} = require 'event-kit'
-{includeDeprecatedAPIs, deprecate} = require 'grim'
 
 ModuleCache = require './module-cache'
 ScopedProperties = require './scoped-properties'
@@ -48,14 +47,6 @@ class Package
     unless typeof metadata.name is 'string' and metadata.name.length > 0
       metadata.name = packageName
 
-    if includeDeprecatedAPIs and metadata.stylesheetMain?
-      deprecate("Use the `mainStyleSheet` key instead of `stylesheetMain` in the `package.json` of `#{packageName}`", {packageName})
-      metadata.mainStyleSheet = metadata.stylesheetMain
-
-    if includeDeprecatedAPIs and metadata.stylesheets?
-      deprecate("Use the `styleSheets` key instead of `stylesheets` in the `package.json` of `#{packageName}`", {packageName})
-      metadata.styleSheets = metadata.stylesheets
-
     metadata
 
   keymaps: null
@@ -174,11 +165,6 @@ class Package
     if @mainModule?
       if @mainModule.config? and typeof @mainModule.config is 'object'
         atom.config.setSchema @name, {type: 'object', properties: @mainModule.config}
-      else if @mainModule.configDefaults? and typeof @mainModule.configDefaults is 'object'
-        deprecate("""Use a config schema instead. See the configuration section
-        of https://atom.io/docs/latest/hacking-atom-package-word-count and
-        https://atom.io/docs/api/latest/Config for more details""", {packageName: @name})
-        atom.config.setDefaults(@name, @mainModule.configDefaults)
       @mainModule.activateConfig?()
     @configActivated = true
 
@@ -211,17 +197,6 @@ class Package
     for [menuPath, map] in @menus when map['context-menu']?
       try
         itemsBySelector = map['context-menu']
-
-        # Detect deprecated format for items object
-        for key, value of itemsBySelector
-          unless _.isArray(value)
-            deprecate("""
-              The context menu CSON format has changed. Please see
-              https://atom.io/docs/api/latest/ContextMenuManager#context-menu-cson-format
-              for more info.
-            """, {packageName: @name})
-            itemsBySelector = atom.contextMenu.convertLegacyItemsBySelector(itemsBySelector)
-
         @activationDisposables.add(atom.contextMenu.add(itemsBySelector))
       catch error
         if error.code is 'EBADSELECTOR'
@@ -309,11 +284,7 @@ class Package
       [stylesheetPath, atom.themes.loadStylesheet(stylesheetPath, true)]
 
   getStylesheetsPath: ->
-    if fs.isDirectorySync(path.join(@path, 'stylesheets'))
-      deprecate("Store package style sheets in the `styles/` directory instead of `stylesheets/` in the `#{@name}` package", packageName: @name)
-      path.join(@path, 'stylesheets')
-    else
-      path.join(@path, 'styles')
+    path.join(@path, 'styles')
 
   getStylesheetPaths: ->
     stylesheetDirPath = @getStylesheetsPath()
@@ -383,11 +354,7 @@ class Package
         callback()
 
     new Promise (resolve) =>
-      if fs.isDirectorySync(path.join(@path, 'scoped-properties'))
-        settingsDirPath = path.join(@path, 'scoped-properties')
-        deprecate("Store package settings files in the `settings/` directory instead of `scoped-properties/`", packageName: @name)
-      else
-        settingsDirPath = path.join(@path, 'settings')
+      settingsDirPath = path.join(@path, 'settings')
 
       fs.exists settingsDirPath, (settingsDirExists) ->
         return resolve() unless settingsDirExists
@@ -417,7 +384,6 @@ class Package
         @mainActivated = false
       catch e
         console.error "Error deactivating package '#{@name}'", e.stack
-    @emit 'deactivated' if includeDeprecatedAPIs
     @emitter.emit 'did-deactivate'
 
   deactivateConfig: ->
@@ -533,31 +499,6 @@ class Package
         else if _.isArray(commands)
           @activationCommands[selector].push(commands...)
 
-    if @metadata.activationEvents?
-      deprecate("""
-        Use `activationCommands` instead of `activationEvents` in your package.json
-        Commands should be grouped by selector as follows:
-        ```json
-          "activationCommands": {
-            "atom-workspace": ["foo:bar", "foo:baz"],
-            "atom-text-editor": ["foo:quux"]
-          }
-        ```
-      """, {packageName: @name})
-      if _.isArray(@metadata.activationEvents)
-        for eventName in @metadata.activationEvents
-          @activationCommands['atom-workspace'] ?= []
-          @activationCommands['atom-workspace'].push(eventName)
-      else if _.isString(@metadata.activationEvents)
-        eventName = @metadata.activationEvents
-        @activationCommands['atom-workspace'] ?= []
-        @activationCommands['atom-workspace'].push(eventName)
-      else
-        for eventName, selector of @metadata.activationEvents
-          selector ?= 'atom-workspace'
-          @activationCommands[selector] ?= []
-          @activationCommands[selector].push(eventName)
-
     @activationCommands
 
   subscribeToActivationHooks: ->
@@ -726,15 +667,3 @@ class Package
       stack = error.stack ? error
 
     atom.notifications.addFatalError(message, {stack, detail, dismissable: true})
-
-if includeDeprecatedAPIs
-  EmitterMixin = require('emissary').Emitter
-  EmitterMixin.includeInto(Package)
-
-  Package::on = (eventName) ->
-    switch eventName
-      when 'deactivated'
-        deprecate 'Use Package::onDidDeactivate instead'
-      else
-        deprecate 'Package::on is deprecated. Use event subscription methods instead.'
-    EmitterMixin::on.apply(this, arguments)