github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 22:08:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Set the lines div height explicitly so it can be > 100% of parent

Browse Source 
All editor specs pass
This commit is contained in:
Nathan Sobo
2012-11-09 14:25:59 -07:00
parent c257a989be
commit 3bc11ede77
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/app/editor-spec.coffee
View File

@@ -483,6 +483,8 @@ fdescribe "Editor", ->
describe "when the font size changes on the view", ->
it "updates the font sizes of editors and recalculates dimensions critical to cursor positioning", ->
rootView.attachToDom()
rootView.height(200)
rootView.width(200)
rootView.setFontSize(10)
lineHeightBefore = editor.lineHeight
charWidthBefore = editor.charWidth

6
src/app/editor.coffee
View File

@@ -868,8 +868,10 @@ class Editor extends View
@renderedLines.css('padding-bottom', paddingBottom)
@gutter.lineNumbers.css('padding-bottom', paddingBottom)
@underlayer.height(@screenLineCount() * @lineHeight)
@overlayer.height(@screenLineCount() * @lineHeight)
linesHeight = @screenLineCount() * @lineHeight
@renderedLines.height(linesHeight)
@underlayer.height(linesHeight)
@overlayer.height(linesHeight)
getFirstVisibleScreenRow: ->
Math.floor(@scrollTop() / @lineHeight)