github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add Spec To Validate Updating An Existing Env Var

Browse Source 
- 🎨 Update spec description to more accurately reflect the intent
This commit is contained in:
Joe Fitzgerald
2016-09-08 11:17:42 -06:00
parent b321ab6a38
commit 3c7a89ec93
1 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spec/update-process-env-spec.js
View File

@@ -96,16 +96,16 @@ describe('updateProcessEnv(launchEnv)', function () {
ATOM_HOME: '/the/atom/home'
}
updateProcessEnv({ATOM_SUPPRESS_ENV_PATCHING: 'true', PWD: '/the/dir'})
updateProcessEnv({ATOM_SUPPRESS_ENV_PATCHING: 'true', PWD: '/the/dir', NODE_ENV: 'the-node-env', NODE_PATH: '/the/node/path', ATOM_HOME: '/the/atom/home'})
expect(process.env).toEqual({
PWD: '/the/dir',
ATOM_SUPPRESS_ENV_PATCHING: 'true',
PWD: '/the/dir',
NODE_ENV: 'the-node-env',
NODE_PATH: '/the/node/path',
ATOM_HOME: '/the/atom/home'
})
updateProcessEnv({PWD: '/the/dir'})
updateProcessEnv({PWD: '/the/dir', NODE_ENV: 'the-node-env', NODE_PATH: '/the/node/path', ATOM_HOME: '/the/atom/home'})
expect(process.env).toEqual({
ATOM_SUPPRESS_ENV_PATCHING: 'true',
PWD: '/the/dir',
@@ -114,6 +114,30 @@ describe('updateProcessEnv(launchEnv)', function () {
ATOM_HOME: '/the/atom/home'
})
})
it('allows an existing env variable to be updated', function () {
process.env = {
WILL_BE_UPDATED: 'old-value',
NODE_ENV: 'the-node-env',
NODE_PATH: '/the/node/path',
ATOM_HOME: '/the/atom/home'
}
updateProcessEnv(process.env)
expect(process.env).toEqual(process.env)
let updatedEnv = {
ATOM_SUPPRESS_ENV_PATCHING: 'true',
WILL_BE_UPDATED: 'new-value',
NODE_ENV: 'the-node-env',
NODE_PATH: '/the/node/path',
ATOM_HOME: '/the/atom/home',
PWD: '/the/dir'
}
updateProcessEnv(updatedEnv)
expect(process.env).toEqual(updatedEnv)
})
})
describe('when the launch environment does not come from a shell', function () {
@@ -203,7 +227,7 @@ describe('updateProcessEnv(launchEnv)', function () {
expect(shouldGetEnvFromShell({SHELL: '/usr/local/bin/fish'})).toBe(true)
})
it('returns false when the shell should not be patched', function () {
it('returns false when the environment indicates that Atom was launched from a shell', function () {
process.platform = 'darwin'
expect(shouldGetEnvFromShell({ATOM_SUPPRESS_ENV_PATCHING: 'true', SHELL: '/bin/sh'})).toBe(false)
process.platform = 'linux'