Add activatePreviousRecentlyUsedItem to pane model and add specs.

keymaps/darwin.cson

@@ -75,7 +75,8 @@
   'ctrl-pagedown': 'pane:show-next-item'
   'ctrl-tab': 'pane:show-next-recently-used-item'
   'ctrl-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
-  'ctrl-shift-tab': 'pane:show-previous-item'
+  'ctrl-shift-tab': 'pane:show-previous-recently-used-item'
+  'ctrl-shift-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
   'cmd-=': 'window:increase-font-size'
   'cmd-+': 'window:increase-font-size'
   'cmd--': 'window:decrease-font-size'

keymaps/linux.cson

@@ -48,7 +48,8 @@
   'shift-backspace': 'core:backspace'
   'ctrl-tab': 'pane:show-next-recently-used-item'
   'ctrl-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
-  'ctrl-shift-tab': 'pane:show-previous-item'
+  'ctrl-shift-tab': 'pane:show-previous-recently-used-item'
+  'ctrl-shift-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
   'ctrl-pageup': 'pane:show-previous-item'
   'ctrl-pagedown': 'pane:show-next-item'
   'ctrl-up': 'core:move-up'

keymaps/win32.cson

@@ -54,7 +54,8 @@
   'shift-backspace': 'core:backspace'
   'ctrl-tab': 'pane:show-next-recently-used-item'
   'ctrl-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
-  'ctrl-shift-tab': 'pane:show-previous-item'
+  'ctrl-shift-tab': 'pane:show-previous-recently-used-item'
+  'ctrl-shift-tab ^ctrl': 'pane:move-active-item-to-top-of-stack'
   'ctrl-pageup': 'pane:show-previous-item'
   'ctrl-pagedown': 'pane:show-next-item'
   'ctrl-shift-up': 'core:move-up'

spec/pane-spec.coffee

@@ -183,8 +183,8 @@ describe "Pane", ->
         pane.activateItem(itemD, true)
         expect(pane.getItems().map (item) -> item.name).toEqual ['A', 'B', 'D']
 
-  describe "::activateNextRecentlyUsedItem()", ->
-    it "sets the active item to the next item in the itemStack", ->
+  describe "::activateNextRecentlyUsedItem() and ::activatePreviousRecentlyUsedItem()", ->
+    it "sets the active item to the next/previous item in the itemStack, looping around at either end", ->
       pane = new Pane(paneParams(items: [new Item("A"), new Item("B"), new Item("C"), new Item("D"), new Item("E")]))
       [item1, item2, item3, item4, item5] = pane.getItems()
       pane.itemStack = [item3, item1, item2, item5, item4]
@@ -195,24 +195,22 @@ describe "Pane", ->
       expect(pane.getActiveItem()).toBe item5
       pane.activateNextRecentlyUsedItem()
       expect(pane.getActiveItem()).toBe item2
-      pane.activateNextRecentlyUsedItem()
-      pane.moveActiveItemToTopOfStack()
-      expect(pane.getActiveItem()).toBe item1
-      expect(pane.itemStack[4]).toBe item1
-      pane.activateNextRecentlyUsedItem()
-      expect(pane.getActiveItem()).toBe item4
-      pane.activateNextRecentlyUsedItem()
+      pane.activatePreviousRecentlyUsedItem()
       expect(pane.getActiveItem()).toBe item5
-      pane.activateNextRecentlyUsedItem()
-      expect(pane.getActiveItem()).toBe item2
+      pane.activatePreviousRecentlyUsedItem()
+      expect(pane.getActiveItem()).toBe item4
+      pane.activatePreviousRecentlyUsedItem()
+      expect(pane.getActiveItem()).toBe item3
+      pane.activatePreviousRecentlyUsedItem()
+      expect(pane.getActiveItem()).toBe item1
       pane.activateNextRecentlyUsedItem()
       expect(pane.getActiveItem()).toBe item3
       pane.activateNextRecentlyUsedItem()
-      expect(pane.getActiveItem()).toBe item1
+      expect(pane.getActiveItem()).toBe item4
       pane.activateNextRecentlyUsedItem()
       pane.moveActiveItemToTopOfStack()
-      expect(pane.getActiveItem()).toBe item4
-      expect(pane.itemStack[4]).toBe item4
+      expect(pane.getActiveItem()).toBe item5
+      expect(pane.itemStack[4]).toBe item5
 
   describe "::activateNextItem() and ::activatePreviousItem()", ->
     it "sets the active item to the next/previous item, looping around at either end", ->

src/pane.coffee

@@ -327,10 +327,19 @@ class Pane extends Model
   activateNextRecentlyUsedItem: ->
     if @items.length > 1
       @itemStackIndex = @itemStack.length - 1 unless @itemStackIndex?
+      @itemStackIndex = @itemStack.length if @itemStackIndex is 0
       @itemStackIndex = @itemStackIndex - 1
       nextRecentlyUsedItem = @itemStack[@itemStackIndex]
       @setActiveItem(nextRecentlyUsedItem, modifyStack: false)
-      @itemStackIndex = @itemStack.length if @itemStackIndex is 0
+
+  # Makes the previous item in the itemStack active.
+  activatePreviousRecentlyUsedItem: ->
+    if @items.length > 1
+      if @itemStackIndex + 1 is @itemStack.length or not @itemStackIndex?
+        @itemStackIndex = -1
+      @itemStackIndex = @itemStackIndex + 1
+      previousRecentlyUsedItem = @itemStack[@itemStackIndex]
+      @setActiveItem(previousRecentlyUsedItem, modifyStack: false)
 
   # Moves the active item to the end of the itemStack once the ctrl key is lifted
   moveActiveItemToTopOfStack: ->

src/register-default-commands.coffee

@@ -3,6 +3,7 @@
 module.exports = ({commandRegistry, commandInstaller, config}) ->
   commandRegistry.add 'atom-workspace',
     'pane:show-next-recently-used-item': -> @getModel().getActivePane().activateNextRecentlyUsedItem()
+    'pane:show-previous-recently-used-item': -> @getModel().getActivePane().activatePreviousRecentlyUsedItem()
     'pane:move-active-item-to-top-of-stack': -> @getModel().getActivePane().moveActiveItemToTopOfStack()
     'pane:show-next-item': -> @getModel().getActivePane().activateNextItem()
     'pane:show-previous-item': -> @getModel().getActivePane().activatePreviousItem()