github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-22 21:38:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove $native.isFile() and $native.isDirectory

Browse Source
This commit is contained in:
Kevin Sawicki
2013-03-07 17:55:13 -08:00
parent fe172985bb
commit 4bc513a8e3
2 changed files with 5 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
native/v8_extensions/native.mm
View File

@@ -24,8 +24,8 @@ namespace v8_extensions {
void Native::CreateContextBinding(CefRefPtr<CefV8Context> context) {
const char* methodNames[] = {
"exists", "read", "write", "absolute", "isDirectory",
"isFile", "remove", "writeToPasteboard", "readFromPasteboard", "quit", "watchPath", "unwatchPath",
"exists", "read", "write", "absolute",
"remove", "writeToPasteboard", "readFromPasteboard", "quit", "watchPath", "unwatchPath",
"getWatchedPaths", "unwatchAllPaths", "makeDirectory", "move", "moveToTrash", "reload", "lastModified",
"md5ForPath", "getPlatform", "setWindowState", "getWindowState", "isMisspelled",
"getCorrectionsForMisspelling"
@@ -113,24 +113,6 @@ namespace v8_extensions {
return true;
}
else if (name == "isDirectory") {
NSString *path = stringFromCefV8Value(arguments[0]);
BOOL isDir = false;
BOOL exists = [[NSFileManager defaultManager] fileExistsAtPath:path isDirectory:&isDir];
retval = CefV8Value::CreateBool(exists && isDir);
return true;
}
else if (name == "isFile") {
NSString *path = stringFromCefV8Value(arguments[0]);
BOOL isDir = false;
BOOL exists = [[NSFileManager defaultManager] fileExistsAtPath:path isDirectory:&isDir];
retval = CefV8Value::CreateBool(exists && !isDir);
return true;
}
else if (name == "remove") {
NSString *path = stringFromCefV8Value(arguments[0]);

7
src/stdlib/fs.coffee
View File

@@ -50,13 +50,12 @@ module.exports =
# Returns true if the file specified by path exists and is a
# directory.
isDirectory: (path) ->
$native.isDirectory path
path? and nodeFs.existsSync(path) and nodeFs.statSync(path).isDirectory()
# Returns true if the file specified by path exists and is a
# regular file.
isFile: (path) ->
return false unless path?
$native.isFile(path)
path? and nodeFs.existsSync(path) and nodeFs.statSync(path).isFile()
# Returns an array with all the names of files contained
# in the directory path.
@@ -118,7 +117,7 @@ module.exports =
@makeDirectory(path)
traverseTree: (rootPath, onFile, onDirectory) ->
return unless nodeFs.existsSync(rootPath) and nodeFs.statSync(rootPath).isDirectory()
return unless @isDirectory(rootPath)
traverse = (rootPath, prefix, onFile, onDirectory) =>
prefix = "#{prefix}/" if prefix