github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 13:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Flesh out deprecation messages for Config::{is,set}Default

Browse Source 
Also, simplify the shim in ::isDefault
This commit is contained in:
Max Brunsfeld
2014-12-16 14:21:40 -08:00
parent b8f239cd39
commit 503fa30c28
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/config.coffee
View File

@@ -623,7 +623,7 @@ class Config
#
# Returns the default value.
getDefault: ->
Grim.deprecate("Use the `excludeSources` to ::get instead")
Grim.deprecate("Use `::get(keyPath, {scope, excludeSources: [atom.config.getUserConfigPath()]})` instead")
if arguments.length is 1
[keyPath] = arguments
else
@@ -639,13 +639,13 @@ class Config
# Returns a {Boolean}, `true` if the current value is the default, `false`
# otherwise.
isDefault: ->
Grim.deprecate("Use the `excludeSources` to ::get instead")
Grim.deprecate("Use `not ::get(keyPath, {scope, sources: [atom.config.getUserConfigPath()]})?` instead")
if arguments.length is 1
[keyPath] = arguments
else
[scopeSelector, keyPath] = arguments
scope = [scopeSelector]
@get(keyPath, {scope}) is @get(keyPath, {scope, excludeSources: [@getUserConfigPath()]})
not @get(keyPath, {scope, sources: [@getUserConfigPath()]})?
# Extended: Retrieve the schema for a specific key path. The schema will tell
# you what type the keyPath expects, and other metadata about the config