github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 05:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16255 from atom/wl-specs-preserve-project-history

Browse Source 
Do not clobber recent project history when running specs
This commit is contained in:
Wliu
2017-11-21 22:32:30 +01:00
committed by GitHub
parent 255de707a1 ebf23ec3e1
commit 572aec74d9
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spec/history-manager-spec.js
View File

@@ -11,6 +11,9 @@ describe("HistoryManager", () => {
let commandDisposable, projectDisposable
beforeEach(async () => {
// Do not clobber recent project history
spyOn(atom.applicationDelegate, 'didChangeHistoryManager')
commandDisposable = jasmine.createSpyObj('Disposable', ['dispose'])
commandRegistry = jasmine.createSpyObj('CommandRegistry', ['add'])
commandRegistry.add.andReturn(commandDisposable)

3
spec/spec-helper.coffee
View File

@@ -61,6 +61,9 @@ else
specProjectPath = require('os').tmpdir()
beforeEach ->
# Do not clobber recent project history
spyOn(atom.history, 'saveState').andReturn(Promise.resolve())
atom.project.setPaths([specProjectPath])
window.resetTimeouts()

6
src/history-manager.js
View File

@@ -50,8 +50,8 @@ export class HistoryManager {
return this.emitter.on('did-change-projects', callback)
}
didChangeProjects (args) {
this.emitter.emit('did-change-projects', args || { reloaded: false })
didChangeProjects (args = {reloaded: false}) {
this.emitter.emit('did-change-projects', args)
}
async addProject (paths, lastOpened) {
@@ -93,7 +93,7 @@ export class HistoryManager {
}
async loadState () {
let history = await this.stateStore.load('history-manager')
const history = await this.stateStore.load('history-manager')
if (history && history.projects) {
this.projects = history.projects.filter(p => Array.isArray(p.paths) && p.paths.length > 0).map(p => new HistoryProject(p.paths, new Date(p.lastOpened)))
this.didChangeProjects({reloaded: true})