github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 13:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14893 from atom/as-fix-resetting-node-pool-styles

Browse Source 
Fix resetting styles in NodePool
This commit is contained in:
Antonio Scandurra
2017-06-27 11:35:19 +02:00
committed by GitHub
parent 71a2abf877 a171380544
commit 57570accbf
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/text-editor-component.js
View File

@@ -4040,7 +4040,6 @@ class NodePool {
constructor () {
this.elementsByType = {}
this.textNodes = []
this.stylesByNode = new WeakMap()
}
getElement (type, className, style) {
@@ -4061,14 +4060,10 @@ class NodePool {
if (element) {
element.className = className
var existingStyle = this.stylesByNode.get(element)
if (existingStyle) {
for (var key in existingStyle) {
if (!style || !style[key]) element.style[key] = ''
}
}
element.styleMap.forEach((value, key) => {
if (!style || style[key] == null) element.style[key] = ''
})
if (style) Object.assign(element.style, style)
this.stylesByNode.set(element, style)
while (element.firstChild) element.firstChild.remove()
return element
@@ -4076,7 +4071,6 @@ class NodePool {
var newElement = document.createElement(type)
if (className) newElement.className = className
if (style) Object.assign(newElement.style, style)
this.stylesByNode.set(newElement, style)
return newElement
}
}