Deprecate Editor::lineLengthForBufferRow

This commit is contained in:
Ben Ogle
2014-09-03 14:03:04 -07:00
parent 0703788209
commit 5e21d1ca5b
3 changed files with 6 additions and 4 deletions

View File

@@ -103,7 +103,7 @@ describe "editorView.", ->
benchmark "cache-entire-visible-area", 100, ->
for i in [firstRow..lastRow]
line = editorView.lineElementForScreenRow(i)[0]
editorView.positionLeftForLineAndColumn(line, i, Math.max(0, editorView.lineLengthForBufferRow(i)))
editorView.positionLeftForLineAndColumn(line, i, Math.max(0, editorView.getModel().lineTextForBufferRow(i).length))
describe "text-rendering.", ->
beforeEach ->

View File

@@ -434,11 +434,13 @@ class Editor extends Model
deprecate "Use Editor::tokenizedLinesForScreenRows instead"
@tokenizedLinesForScreenRows(start, end)
# Public: Returns a {Number} representing the line length for the given
# Returns a {Number} representing the line length for the given
# buffer row, exclusive of its line-ending character(s).
#
# * `row` A {Number} indicating the buffer row.
lineLengthForBufferRow: (row) -> @buffer.lineLengthForRow(row)
lineLengthForBufferRow: (row) ->
deprecate "Use editor.lineTextForBufferRow(row).length instead"
@lineTextForBufferRow(row).length
bufferRowForScreenRow: (row) -> @displayBuffer.bufferRowForScreenRow(row)

View File

@@ -230,7 +230,7 @@ class LanguageMode
break unless /\w/.test(@editor.lineTextForBufferRow(endRow + 1))
endRow++
new Range([startRow, 0], [endRow, @editor.lineLengthForBufferRow(endRow)])
new Range([startRow, 0], [endRow, @editor.lineTextForBufferRow(endRow).length])
# Given a buffer row, this returns a suggested indentation level.
#