github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Guard gitFirst/LastVisibleScreenRow

Browse Source 
These methods are sometimes called by the model before the editor has
been attached to the DOM.
This commit is contained in:
Nathan Sobo
2017-04-18 17:42:43 -06:00
committed by Antonio Scandurra
parent eb7cdf2a34
commit 5ea4096464
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/text-editor-component.js
View File

@@ -2315,14 +2315,18 @@ class TextEditorComponent {
}
getFirstVisibleRow () {
return this.rowForPixelPosition(this.getScrollTop())
if (this.measurements) {
return this.rowForPixelPosition(this.getScrollTop())
}
}
getLastVisibleRow () {
return Math.min(
this.props.model.getApproximateScreenLineCount() - 1,
this.rowForPixelPosition(this.getScrollBottom())
)
if (this.measurements) {
return Math.min(
this.props.model.getApproximateScreenLineCount() - 1,
this.rowForPixelPosition(this.getScrollBottom())
)
}
}
getFirstVisibleColumn () {