github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-24 06:18:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Be defensive when iterating through decorations

Browse Source
This commit is contained in:
Ben Ogle
2014-06-23 18:03:19 -07:00
parent b4f4ef8ec4
commit 5ebb17c2e8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/display-buffer.coffee
View File

@@ -762,8 +762,12 @@ class DisplayBuffer extends Model
@decorationMarkerChangedSubscriptions[marker.id] ?= @subscribe marker, 'changed', (event) =>
decorations = @decorationsByMarkerId[marker.id]
for decoration in decorations
@emit 'decoration-changed', marker, decoration, event
# Why check existence? Markers may get destroyed or decorations removed
# in the change handler. Bookmarks does this.
if decorations?
for decoration in decorations
@emit 'decoration-changed', marker, decoration, event
@decorationsByMarkerId[marker.id] ?= []
@decorationsByMarkerId[marker.id].push(decoration)