Merge pull request #16215 from atom/mkt-fix-uri-handler-off-by-one-line-error

Translate line and column numbers from URI handlers
This commit is contained in:
Michelle Tilley
2017-11-17 09:46:14 -08:00
committed by GitHub

View File

@@ -1,9 +1,16 @@
// Converts a query string parameter for a line or column number
// to a zero-based line or column number for the Atom API.
function getLineColNumber (numStr) {
const num = parseInt(numStr || 0, 10)
return Math.max(num - 1, 0)
}
function openFile (atom, {query}) {
const {filename, line, column} = query
atom.workspace.open(filename, {
initialLine: parseInt(line || 0, 10),
initialColumn: parseInt(column || 0, 10),
initialLine: getLineColNumber(line),
initialColumn: getLineColNumber(column),
searchAllPanes: true
})
}