github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Migrate specs from console.warn to notifications

Browse Source
This commit is contained in:
Kevin Sawicki
2015-03-03 16:33:58 -08:00
parent fa2eab5b7e
commit 6c87dc05f3
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/package-manager-spec.coffee
View File

@@ -213,9 +213,11 @@ describe "PackageManager", ->
expect(mainModule.activate.callCount).toBe 1
it "logs a warning when the activation commands are invalid", ->
spyOn(console, 'warn')
addErrorHandler = jasmine.createSpy()
atom.notifications.onDidAddNotification(addErrorHandler)
expect(-> atom.packages.activatePackage('package-with-invalid-activation-commands')).not.toThrow()
expect(console.warn.callCount).toBe(1)
expect(addErrorHandler.callCount).toBe 1
expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to activate the package-with-invalid-activation-commands package")
describe "when the package has no main module", ->
it "does not throw an exception", ->
@@ -262,11 +264,14 @@ describe "PackageManager", ->
runs -> expect(activatedPackage.name).toBe 'package-with-main'
describe "when the package throws an error while loading", ->
it "logs a warning instead of throwing an exception", ->
fit "adds a notification instead of throwing an exception", ->
atom.config.set("core.disabledPackages", [])
spyOn(console, "warn")
addErrorHandler = jasmine.createSpy()
atom.notifications.onDidAddNotification(addErrorHandler)
expect(-> atom.packages.activatePackage("package-that-throws-an-exception")).not.toThrow()
expect(console.warn).toHaveBeenCalled()
expect(addErrorHandler.callCount).toBe 2
expect(addErrorHandler.argsForCall[0][0].message).toContain("Failed to load the package-that-throws-an-exception package")
expect(addErrorHandler.argsForCall[1][0].message).toContain("Failed to activate the package-that-throws-an-exception package")
describe "when the package is not found", ->
it "rejects the promise", ->