🔥 Duplicate devMode/inDevMode parameter to Package, PackageManager

spec/package-spec.coffee

@@ -10,7 +10,7 @@ describe "Package", ->
       keymapManager: atom.keymaps, commandRegistry: atom.command,
       grammarRegistry: atom.grammars, themeManager: atom.themes,
       menuManager: atom.menu, contextMenuManager: atom.contextMenu,
-      inDevMode: false
+      devMode: false
     )
 
   buildPackage = (packagePath) -> build(Package, packagePath)

src/atom-environment.coffee

@@ -147,7 +147,7 @@ class AtomEnvironment extends Model
     @packages = new PackageManager({
       devMode, configDirPath, resourcePath, safeMode, @config, styleManager: @styles,
       commandRegistry: @commands, keymapManager: @keymaps, notificationManager: @notifications,
-      grammarRegistry: @grammars, inDevMode: @inDevMode()
+      grammarRegistry: @grammars
     })
 
     ThemeManager = require './theme-manager'

src/package-manager.coffee

@@ -28,7 +28,12 @@ ThemePackage = require './theme-package'
 # settings and also by calling `enablePackage()/disablePackage()`.
 module.exports =
 class PackageManager
-  constructor: ({configDirPath, @devMode, safeMode, @resourcePath, @config, @styleManager, @notificationManager, @inDevMode, @keymapManager, @commandRegistry, @grammarRegistry}) ->
+  constructor: (params) ->
+    {
+      configDirPath, @devMode, safeMode, @resourcePath, @config, @styleManager,
+      @notificationManager, @keymapManager, @commandRegistry, @grammarRegistry
+    } = params
+
     @emitter = new Emitter
     @activationHookEmitter = new Emitter
     @packageDirPaths = []
@@ -365,8 +370,9 @@ class PackageManager
           return null
 
       options = {
-        path: packagePath, metadata, packageManager: this,
-        @config, @styleManager, @commandRegistry, @keymapManager, @inDevMode, @notificationManager, @grammarRegistry, @themeManager, @menuManager, @contextMenuManager
+        path: packagePath, metadata, packageManager: this, @config, @styleManager,
+        @commandRegistry, @keymapManager, @devMode, @notificationManager,
+        @grammarRegistry, @themeManager, @menuManager, @contextMenuManager
       }
       if metadata.theme
         pack = new ThemePackage(options)

src/package.coffee

@@ -29,7 +29,13 @@ class Package
   Section: Construction
   ###
 
-  constructor: ({@path, @metadata, @packageManager, @config, @styleManager, @commandRegistry, @keymapManager, @inDevMode, @notificationManager, @grammarRegistry, @themeManager, @menuManager, @contextMenuManager}) ->
+  constructor: (params) ->
+    {
+      @path, @metadata, @packageManager, @config, @styleManager, @commandRegistry,
+      @keymapManager, @devMode, @notificationManager, @grammarRegistry, @themeManager,
+      @menuManager, @contextMenuManager
+    } = params
+
     @emitter = new Emitter
     @metadata ?= @packageManager.loadPackageMetadata(@path)
     @bundledPackage = @packageManager.isBundledPackagePath(@path)
@@ -587,7 +593,7 @@ class Package
   # This information is cached in local storage on a per package/version basis
   # to minimize the impact on startup time.
   getIncompatibleNativeModules: ->
-    unless @inDevMode
+    unless @devMode
       try
         if arrayAsString = global.localStorage.getItem(@getIncompatibleNativeModulesStorageKey())
           return JSON.parse(arrayAsString)