github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 05:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

When possible, re-assign line element text instead of replacing.

Browse Source 
Slight speculative optimization but it's pretty simple.
This commit is contained in:
Nathan Sobo
2012-01-25 18:39:56 -08:00
parent 90faddf9f1
commit 8ea937b15b
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/atom/editor.coffee
View File

@@ -41,8 +41,8 @@ class Editor extends Template
@on 'move-left', => @moveLeft()
@on 'move-down', => @moveDown()
@on 'move-up', => @moveUp()
@on 'newline', => @buffer.change({ start: @getPosition(), end: @getPosition() }, "\n")
@on 'backspace', => @buffer.backspace @getPosition()
@on 'newline', => @bench = @buffer.change({ start: @getPosition(), end: @getPosition() }, "\n")
@on 'backspace', => @benrch = @buffer.backspace @getPosition()
handleEvents: ->
@on 'focus', =>
@@ -69,13 +69,6 @@ class Editor extends Template
@setPosition(row: 0, col: 0)
# @buffer.on 'insert', (e) =>
# {row} = e.range.start
# updatedLine = @buildLineElement(@buffer.getLine(row))
# @lines.find('pre').eq(row).replaceWith(updatedLine)
# if e.string == '\n'
# updatedLine.after @buildLineElement(@buffer.getLine(row + 1))
@buffer.on 'change', (e) =>
{ preRange, postRange } = e
@@ -94,7 +87,12 @@ class Editor extends Template
@cursor.bufferChanged(e)
updateLineElement: (row) ->
@getLineElement(row).replaceWith(@buildLineElement(@buffer.getLine(row)))
line = @buffer.getLine(row)
elt = @getLineElement(row)
if line == ''
elt.html(' ')
else
elt.text(line)
insertLineElement: (row) ->
@getLineElement(row).before(@buildLineElement(@buffer.getLine(row)))