github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-22 21:38:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5714 from as-cii/update-only-needed-cursors

Browse Source 
Update needed cursors only
This commit is contained in:
Nathan Sobo
2015-02-24 13:44:07 -07:00
parent a29cf33e97 cc9ed043c7
commit a208e789d7
1 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/text-editor-presenter.coffee
View File

@@ -259,16 +259,22 @@ class TextEditorPresenter
updateCursorsState: ->
@state.content.cursors = {}
return unless @startRow? and @endRow? and @hasPixelRectRequirements() and @baseCharacterWidth?
for cursor in @model.cursors # using property directly to avoid allocation
if cursor.isVisible() and @startRow <= cursor.getScreenRow() < @endRow
pixelRect = @pixelRectForScreenRange(cursor.getScreenRange())
pixelRect.width = @baseCharacterWidth if pixelRect.width is 0
@state.content.cursors[cursor.id] = pixelRect
@updateCursorState(cursor) for cursor in @model.cursors # using property directly to avoid allocation
@emitter.emit 'did-update-state'
updateCursorState: (cursor, destroyOnly = false) ->
delete @state.content.cursors[cursor.id]
return if destroyOnly
return unless @startRow? and @endRow? and @hasPixelRectRequirements() and @baseCharacterWidth?
return unless cursor.isVisible() and @startRow <= cursor.getScreenRow() < @endRow
pixelRect = @pixelRectForScreenRange(cursor.getScreenRange())
pixelRect.width = @baseCharacterWidth if pixelRect.width is 0
@state.content.cursors[cursor.id] = pixelRect
updateOverlaysState: ->
return unless @hasPixelRectRequirements()
@@ -948,16 +954,17 @@ class TextEditorPresenter
didChangePositionDisposable = cursor.onDidChangePosition =>
@updateHiddenInputState() if cursor.isLastCursor()
@pauseCursorBlinking()
@updateCursorsState()
@updateCursorState(cursor)
didChangeVisibilityDisposable = cursor.onDidChangeVisibility(@updateCursorsState.bind(this))
didChangeVisibilityDisposable = cursor.onDidChangeVisibility =>
@updateCursorState(cursor)
didDestroyDisposable = cursor.onDidDestroy =>
@disposables.remove(didChangePositionDisposable)
@disposables.remove(didChangeVisibilityDisposable)
@disposables.remove(didDestroyDisposable)
@updateHiddenInputState()
@updateCursorsState()
@updateCursorState(cursor, true)
@disposables.add(didChangePositionDisposable)
@disposables.add(didChangeVisibilityDisposable)
@@ -967,7 +974,7 @@ class TextEditorPresenter
@observeCursor(cursor)
@updateHiddenInputState()
@pauseCursorBlinking()
@updateCursorsState()
@updateCursorState(cursor)
startBlinkingCursors: ->
@toggleCursorBlinkHandle = setInterval(@toggleCursorBlink.bind(this), @getCursorBlinkPeriod() / 2)