github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove test that checks that we can search of a subfolder of an ignored folder

Browse Source 
This seems to not be working on Windows or with ripgrep, so it's not
expected behaviour.
This commit is contained in:
Rafael Oleza
2019-06-06 14:02:27 +02:00
parent 2d455ac5ee
commit ac9be2d082
1 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spec/workspace-spec.js
View File

@@ -2771,33 +2771,6 @@ describe('Workspace', () => {
expect(resultHandler).toHaveBeenCalledWith(ignoredPath);
});
// This is a current limitation of the ripgrep scanner: whenever it finds a folder
// ignored by the vcs, it stops there and it does not try to traverse their subfolders.
if (!ripgrep) {
it('does not exclude files when searching on an ignored subfolder even when core.excludeVcsIgnoredPaths is true', async () => {
fs.mkdirSync(path.join(projectPath, 'poop'));
fs.mkdirSync(path.join(projectPath, 'poop', 'subfolder'));
ignoredPath = path.join(
path.join(projectPath, 'poop', 'subfolder', 'whatever.txt')
);
fs.writeFileSync(ignoredPath, 'this match should be included');
atom.project.setPaths([projectPath]);
atom.config.set('core.excludeVcsIgnoredPaths', true);
const resultHandler = jasmine.createSpy('result found');
await scan(
/match/,
{
paths: ['poop/subfolder']
},
({ filePath }) => resultHandler(filePath)
);
expect(resultHandler).toHaveBeenCalledWith(ignoredPath);
});
}
});
describe('when the core.followSymlinks config is used', () => {