github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-24 14:28:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

In vim command-mode, only eat insertion keys, not other modifiers

Browse Source
This commit is contained in:
Nathan Sobo
2012-01-13 14:23:58 -08:00
parent a7e8246de0
commit b4886bb6d6
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/atom/vim-mode-spec.coffee
View File

@@ -14,12 +14,18 @@ describe "VimMode", ->
expect(editor).toHaveClass 'command-mode'
describe "command-mode", ->
it "stops propagation on key events that don't have bindings so that they don't get inserted", ->
it "stops propagation on key events would otherwise insert a character, but allows unhandled non-insertions through", ->
event = keydownEvent('\\')
spyOn(event, 'stopPropagation')
editor.trigger event
expect(event.stopPropagation).toHaveBeenCalled()
event = keydownEvent('s', metaKey: true)
spyOn(event, 'stopPropagation')
editor.trigger event
expect(event.stopPropagation).not.toHaveBeenCalled()
describe "the i keybinding", ->
it "puts the editor into insert mode", ->
expect(editor).not.toHaveClass 'insert-mode'

4
src/atom/vim-mode.coffee
View File

@@ -18,9 +18,9 @@ class VimMode
setupCommandMode: ->
atom.bindKeys '.command-mode', (e) ->
if e.keystroke.match /\d/
if e.keystroke.match /^\d$/
return 'command-mode:numeric-prefix'
if e.keystroke.match /./
if e.keystroke.match /^.$/
return false
@bindCommandModeKeys