github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't rely on promise resolution timing in main process spec

Browse Source
This commit is contained in:
Max Brunsfeld
2018-01-05 13:01:33 -08:00
parent 9d30003e58
commit b645852142
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/main-process/atom-application.test.js
View File

@@ -397,6 +397,7 @@ describe('AtomApplication', function () {
await focusWindow(window)
window.close()
await window.closedPromise
await atomApplication.lastBeforeQuitPromise
assert(electron.app.didQuit())
})
} else if (process.platform === 'darwin') {
@@ -406,6 +407,7 @@ describe('AtomApplication', function () {
await focusWindow(window)
window.close()
await window.closedPromise
await timeoutPromise(1000)
assert(!electron.app.didQuit())
})
}
@@ -495,9 +497,11 @@ describe('AtomApplication', function () {
const window2 = atomApplication.launch(parseCommandLine([path.join(dirBPath, 'file-b')]))
await focusWindow(window2)
electron.app.quit()
await new Promise(process.nextTick)
assert(!electron.app.didQuit())
await Promise.all([window1.lastPrepareToUnloadPromise, window2.lastPrepareToUnloadPromise])
await new Promise(resolve => resolve())
await new Promise(process.nextTick)
assert(electron.app.didQuit())
})