github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-22 21:38:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

🐎 Find elements by id in spec reporter

Browse Source 
Previously classes containing the spec/suite id were used which
caused major amounts of time finding DOM nodes using class selectors
instead of id selectors.

This decreases the Editor spec from ~90s to ~30s.
This commit is contained in:
Kevin Sawicki
2013-08-28 14:54:55 -07:00
parent 8e4c9076f1
commit c8b7040144
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/atom-reporter.coffee
View File

@@ -130,7 +130,7 @@ class AtomReporter extends View
bundledPackageSpecs = 0
userPackageSpecs = 0
for spec in specs
symbol = $$ -> @li class: "spec-summary pending spec-summary-#{spec.id}"
symbol = $$ -> @li id: "spec-summary-#{spec.id}", class: "spec-summary pending"
switch spec.specType
when 'core'
coreSpecs++
@@ -159,7 +159,7 @@ class AtomReporter extends View
@runningSpecCount++
specComplete: (spec) ->
specSummaryElement = $(".spec-summary-#{spec.id}")
specSummaryElement = $("#spec-summary-#{spec.id}")
specSummaryElement.removeClass('pending')
specSummaryElement.data("description", spec.getFullName())
@@ -185,7 +185,7 @@ class SuiteResultView extends View
suite: null
initialize: (@suite) ->
@addClass("suite-view-#{@suite.id}")
@attr('id', "suite-view-#{@suite.id}")
@description.html @suite.description
attach: ->
@@ -194,7 +194,7 @@ class SuiteResultView extends View
parentSuiteView: ->
return unless @suite.parentSuite
if not suiteView = $(".suite-view-#{@suite.parentSuite.id}").view()
if not suiteView = $("#suite-view-#{@suite.parentSuite.id}").view()
suiteView = new SuiteResultView(@suite.parentSuite)
suiteView.attach()
@@ -222,7 +222,7 @@ class SpecResultView extends View
@parentSuiteView().append this
parentSuiteView: ->
if not suiteView = $(".suite-view-#{@spec.suite.id}").view()
if not suiteView = $("#suite-view-#{@spec.suite.id}").view()
suiteView = new SuiteResultView(@spec.suite)
suiteView.attach()