[Gutter] Fix coffeescript style issues

This commit is contained in:
Jess Lin
2015-04-20 23:23:48 -07:00
parent 14145e1197
commit cdca9c3ef1
7 changed files with 21 additions and 21 deletions

View File

@@ -1373,7 +1373,7 @@ describe "DisplayBuffer", ->
[marker] = []
beforeEach ->
marker = displayBuffer.markBufferRange([[1, 0], [1, 0]]);
marker = displayBuffer.markBufferRange([[1, 0], [1, 0]])
it "creates a decoration that is both of 'line-number' and 'gutter' type when called with the 'line-number' type", ->
decorationProperties = {type: 'line-number', class: 'one'}
@@ -1384,7 +1384,7 @@ describe "DisplayBuffer", ->
expect(decoration.getProperties().class).toBe 'one'
it "creates a decoration that is only of 'gutter' type if called with the 'gutter' type and a 'gutterName'", ->
decorationProperties = {type: 'gutter', gutterName:'test-gutter', class: 'one'}
decorationProperties = {type: 'gutter', gutterName: 'test-gutter', class: 'one'}
decoration = displayBuffer.decorateMarker(marker, decorationProperties)
expect(decoration.isType('gutter')).toBe true
expect(decoration.isType('line-number')).toBe false

View File

@@ -86,14 +86,14 @@ describe "GutterContainerComponent", ->
expect(gutterContainerComponent.getDomNode().children.item(0)).toBe expectedCustomGutterNode
it "removes a gutter from the DOM if it does not appear in the latest state update", ->
lineNumberGutter = new Gutter(mockGutterContainer, {name: 'line-number'})
testState = buildTestState([{gutter: lineNumberGutter, visible: true}])
gutterContainerComponent.updateSync(testState)
lineNumberGutter = new Gutter(mockGutterContainer, {name: 'line-number'})
testState = buildTestState([{gutter: lineNumberGutter, visible: true}])
gutterContainerComponent.updateSync(testState)
expect(gutterContainerComponent.getDomNode().children.length).toBe 1
testState = buildTestState([])
gutterContainerComponent.updateSync(testState)
expect(gutterContainerComponent.getDomNode().children.length).toBe 0
expect(gutterContainerComponent.getDomNode().children.length).toBe 1
testState = buildTestState([])
gutterContainerComponent.updateSync(testState)
expect(gutterContainerComponent.getDomNode().children.length).toBe 0
describe "when updated with multiple gutters", ->
it "positions (and repositions) the gutters to match the order they appear in each state update", ->

View File

@@ -46,9 +46,9 @@ describe 'Gutter', ->
[mockGutterContainer, mockGutterContainerRemovedGutters] = []
beforeEach ->
mockGutterContainerRemovedGutters = [];
mockGutterContainerRemovedGutters = []
mockGutterContainer = removeGutter: (destroyedGutter) ->
mockGutterContainerRemovedGutters.push destroyedGutter
mockGutterContainerRemovedGutters.push destroyedGutter
it 'removes the gutter from its container.', ->
gutter = new Gutter mockGutterContainer, {name}

View File

@@ -32,7 +32,7 @@ class CustomGutterComponent
newDimensionsAndBackgroundState = state.gutters
setDimensionsAndBackground(@oldDimensionsAndBackgroundState, newDimensionsAndBackgroundState, @decorationsNode)
@oldDecorationPositionState ?= {};
@oldDecorationPositionState ?= {}
decorationState = state.gutters.customDecorations[@gutter.name]
updatedDecorationIds = new Set
@@ -59,7 +59,7 @@ class CustomGutterComponent
# Builds and returns an HTMLElement to represent the specified decoration.
buildDecorationNode: (decorationId, decorationInfo) ->
@oldDecorationPositionState[decorationId] = {};
@oldDecorationPositionState[decorationId] = {}
newNode = document.createElement('div')
newNode.style.position = 'absolute'
@updateDecorationNode(newNode, decorationId, decorationInfo)
@@ -68,7 +68,7 @@ class CustomGutterComponent
# Updates the existing HTMLNode with the new decoration info. Attempts to
# minimize changes to the DOM.
updateDecorationNode: (node, decorationId, newDecorationInfo) ->
oldPositionState = @oldDecorationPositionState[decorationId];
oldPositionState = @oldDecorationPositionState[decorationId]
if oldPositionState.top isnt newDecorationInfo.top + 'px'
node.style.top = newDecorationInfo.top + 'px'

View File

@@ -72,7 +72,7 @@ class GutterContainerComponent
existingGutterComponentDescription = @gutterComponents[indexInOldGutters]
existingGutterComponent = existingGutterComponentDescription.component
indexInOldGutters++
if existingGutterComponent == gutterComponent
if existingGutterComponent is gutterComponent
matchingGutterFound = true
break
if not matchingGutterFound
@@ -82,7 +82,7 @@ class GutterContainerComponent
@domNode.appendChild(gutterComponent.getDomNode())
else
if indexInOldGutters == oldGuttersLength
if indexInOldGutters is oldGuttersLength
@domNode.appendChild(gutterComponent.getDomNode())
else
@domNode.insertBefore(gutterComponent.getDomNode(), @domNode.children[indexInOldGutters])

View File

@@ -30,7 +30,7 @@ class GutterContainer
addGutter: (options) ->
options = options ? {}
gutterName = options.name
if gutterName == null
if gutterName is null
throw new Error('A name is required to create a gutter.')
if @gutterWithName(gutterName)
throw new Error('Tried to create a gutter with a name that is already in use.')
@@ -54,7 +54,7 @@ class GutterContainer
gutterWithName: (name) ->
for gutter in @gutters
if gutter.name == name then return gutter
if gutter.name is name then return gutter
null
###

View File

@@ -388,9 +388,9 @@ class TextEditorPresenter
updateCommonGutterState: ->
@state.gutters.backgroundColor = if @gutterBackgroundColor isnt "rgba(0, 0, 0, 0)"
@gutterBackgroundColor
else
@backgroundColor
@gutterBackgroundColor
else
@backgroundColor
didAddGutter: (gutter) ->
gutterDisposables = new CompositeDisposable