github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 22:08:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make SelectList handle prefixed move-up and move-down events

Browse Source
This commit is contained in:
Nathan Sobo
2012-10-05 10:43:24 -10:00
parent a180e6d703
commit d4b6ba4c11
2 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
spec/extensions/select-list-spec.coffee
View File

@@ -37,31 +37,31 @@ describe "SelectList", ->
expect(list.find('li:contains(Delta)')).toExist()
expect(list.find('li:first')).toHaveClass 'selected'
describe "when move-up / move-down are triggered on the miniEditor", ->
describe "when core:move-up / core:move-down are triggered on the miniEditor", ->
it "selects the previous / next item in the list, or wraps around to the other side", ->
expect(list.find('li:first')).toHaveClass 'selected'
miniEditor.trigger 'move-up'
miniEditor.trigger 'core:move-up'
expect(list.find('li:first')).not.toHaveClass 'selected'
expect(list.find('li:last')).toHaveClass 'selected'
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
expect(list.find('li:first')).toHaveClass 'selected'
expect(list.find('li:last')).not.toHaveClass 'selected'
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
expect(list.find('li:eq(0)')).not.toHaveClass 'selected'
expect(list.find('li:eq(1)')).toHaveClass 'selected'
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
expect(list.find('li:eq(1)')).not.toHaveClass 'selected'
expect(list.find('li:eq(2)')).toHaveClass 'selected'
miniEditor.trigger 'move-up'
miniEditor.trigger 'core:move-up'
expect(list.find('li:eq(2)')).not.toHaveClass 'selected'
expect(list.find('li:eq(1)')).toHaveClass 'selected'
@@ -71,22 +71,22 @@ describe "SelectList", ->
itemHeight = list.find('li').outerHeight()
list.height(itemHeight * 2)
miniEditor.trigger 'move-down'
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
miniEditor.trigger 'core:move-down'
expect(list.scrollBottom()).toBe itemHeight * 3
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
expect(list.scrollBottom()).toBe itemHeight * 4
miniEditor.trigger 'move-up'
miniEditor.trigger 'move-up'
miniEditor.trigger 'core:move-up'
miniEditor.trigger 'core:move-up'
expect(list.scrollBottom()).toBe itemHeight * 3
describe "the core:confirm event", ->
describe "when there is an item selected (because the list in not empty)", ->
it "triggers the selected hook with the selected array element", ->
miniEditor.trigger 'move-down'
miniEditor.trigger 'move-down'
miniEditor.trigger 'core:move-down'
miniEditor.trigger 'core:move-down'
miniEditor.trigger 'core:confirm'
expect(selectList.confirmed).toHaveBeenCalledWith(array[2])

4
src/app/select-list.coffee
View File

@@ -21,8 +21,8 @@ class SelectList extends View
@miniEditor.getBuffer().on 'change', => @populateList()
@miniEditor.on 'focusout', => @cancel() unless @cancelling
@on 'move-up', => @selectPreviousItem()
@on 'move-down', => @selectNextItem()
@on 'core:move-up', => @selectPreviousItem()
@on 'core:move-down', => @selectNextItem()
@on 'core:confirm', => @confirmSelection()
@on 'core:cancel', => @cancel()