github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-22 21:38:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove closure allocations from DOMElementPool build methods

Browse Source
This commit is contained in:
Nathan Sobo
2017-02-13 09:56:37 -07:00
committed by Antonio Scandurra
parent bb9d1f49c0
commit d7db7af722
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/dom-element-pool.js
View File

@@ -13,17 +13,9 @@ class DOMElementPool {
}
}
build (tagName, factory, reset) {
let element = this.freeElementsByTagName[tagName] ? this.freeElementsByTagName[tagName].pop() : null
if (!element) { element = factory() }
reset(element)
this.freedElements.delete(element)
return element
}
buildElement (tagName, className) {
const factory = () => document.createElement(tagName)
const reset = function (element) {
let element = this.freeElementsByTagName[tagName] ? this.freeElementsByTagName[tagName].pop() : null
if (element) {
for (let dataId in element.dataset) { delete element.dataset[dataId] }
element.removeAttribute('style')
if (className != null) {
@@ -31,14 +23,22 @@ class DOMElementPool {
} else {
element.removeAttribute('class')
}
this.freedElements.delete(element)
} else {
element = document.createElement(tagName)
}
return this.build(tagName, factory, reset)
return element
}
buildText (textContent) {
const factory = () => document.createTextNode(textContent)
const reset = element => { element.textContent = textContent }
return this.build('#text', factory, reset)
let element = this.freeElementsByTagName['#text'] ? this.freeElementsByTagName['#text'].pop() : null
if (element) {
element.textContent = textContent
this.freedElements.delete(element)
} else {
element = document.createTextNode(textContent)
}
return element
}
freeElementAndDescendants (element) {