Eliminate cached placeholderTextVnode

This commit is contained in:
Nathan Sobo
2017-04-24 06:23:07 -06:00
committed by Antonio Scandurra
parent 82cdf80f25
commit d92e0fc0a1

View File

@@ -147,8 +147,6 @@ class TextEditorComponent {
this.pendingScrollLeftColumn = this.props.initialScrollLeftColumn
this.measuredContent = false
this.placeholderTextVnode = null
this.queryGuttersToRender()
this.queryMaxLineNumberDigits()
this.observeBlockDecorations()
@@ -625,17 +623,14 @@ class TextEditorComponent {
}
renderPlaceholderText () {
if (!this.measuredContent) {
this.placeholderTextVnode = null
const {model} = this.props
if (model.isEmpty()) {
const placeholderText = model.getPlaceholderText()
if (placeholderText != null) {
this.placeholderTextVnode = $.div({className: 'placeholder-text'}, placeholderText)
}
const {model} = this.props
if (model.isEmpty()) {
const placeholderText = model.getPlaceholderText()
if (placeholderText != null) {
return $.div({className: 'placeholder-text'}, placeholderText)
}
}
return this.placeholderTextVnode
return null
}
renderCharacterMeasurementLine () {