github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 05:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don’t apply ‘tool-panel’ class to modal panels

Browse Source
This commit is contained in:
Nathan Sobo
2014-11-24 16:46:47 -07:00
parent 8cb0197638
commit dda2b2e893
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/panel-container-element-spec.coffee
View File

@@ -51,6 +51,7 @@ describe "PanelContainerElement", ->
container.addPanel(panel1)
expect(element.childNodes.length).toBe 1
expect(element.childNodes[0]).toHaveClass 'left'
expect(element.childNodes[0]).toHaveClass 'tool-panel' # legacy selector support
expect(element.childNodes[0]).toHaveClass 'panel-left' # legacy selector support
expect(element.childNodes[0].tagName).toBe 'ATOM-PANEL'
@@ -81,6 +82,7 @@ describe "PanelContainerElement", ->
container.addPanel(panel1)
expect(element.childNodes.length).toBe 1
expect(element.childNodes[0]).toHaveClass 'bottom'
expect(element.childNodes[0]).toHaveClass 'tool-panel' # legacy selector support
expect(element.childNodes[0]).toHaveClass 'panel-bottom' # legacy selector support
expect(element.childNodes[0].tagName).toBe 'ATOM-PANEL'
expect(panel1.getView()).toHaveClass 'one'
@@ -124,5 +126,8 @@ describe "PanelContainerElement", ->
container.addPanel(panel1)
expect(panel1.getView()).toHaveClass 'modal'
expect(panel1.getView()).toHaveClass 'overlay' # legacy selector support
expect(panel1.getView()).toHaveClass 'from-top' # legacy selector support
# legacy selector support
expect(panel1.getView()).not.toHaveClass 'tool-panel'
expect(panel1.getView()).toHaveClass 'overlay'
expect(panel1.getView()).toHaveClass 'from-top'

2
src/panel-container-element.coffee
View File

@@ -18,7 +18,7 @@ class PanelContainerElement extends HTMLElement
if @model.isModal()
panelElement.classList.add("overlay", "from-top")
else
panelElement.classList.add("panel-#{@model.getLocation()}")
panelElement.classList.add("tool-panel", "panel-#{@model.getLocation()}")
if index >= @childNodes.length
@appendChild(panelElement)

1
src/panel-element.coffee
View File

@@ -12,7 +12,6 @@ class PanelElement extends HTMLElement
@appendChild(view)
callAttachHooks(view) # for backward compatibility with SpacePen views
@classList.add("tool-panel")
@classList.add(@model.getClassName().split(' ')...) if @model.getClassName()?
@subscriptions.add @model.onDidChangeVisible(@visibleChanged.bind(this))
@subscriptions.add @model.onDidDestroy(@destroyed.bind(this))