github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-25 23:08:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Rename Buffer.createMarker to markRange

Browse Source
This commit is contained in:
Nathan Sobo
2013-01-30 17:41:04 -07:00
parent dfe0cad217
commit e02f9cd830
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/app/buffer-spec.coffee
View File

@@ -669,8 +669,8 @@ describe 'Buffer', ->
fdescribe "markers", ->
[marker1, marker2, marker3] = []
beforeEach ->
marker1 = buffer.createMarker([[4, 20], [4, 23]])
marker2 = buffer.createMarker([[4, 20], [4, 23]], stayValid: true)
marker1 = buffer.markRange([[4, 20], [4, 23]])
marker2 = buffer.markRange([[4, 20], [4, 23]], stayValid: true)
describe "when the buffer changes due to a new operation", ->
describe "when the change precedes the marker range", ->
@@ -756,11 +756,11 @@ describe 'Buffer', ->
it "restores invalidated markers when undoing/redoing in the other direction", ->
buffer.change([[4, 21], [4, 24]], "foo")
expect(buffer.getMarkerRange(marker1)).toBeUndefined()
marker3 = buffer.createMarker([[4, 20], [4, 23]])
marker3 = buffer.markRange([[4, 20], [4, 23]])
buffer.undo()
expect(buffer.getMarkerRange(marker1)).toEqual [[4, 20], [4, 23]]
expect(buffer.getMarkerRange(marker3)).toBeUndefined()
marker4 = buffer.createMarker([[4, 20], [4, 23]])
marker4 = buffer.markRange([[4, 20], [4, 23]])
buffer.redo()
expect(buffer.getMarkerRange(marker3)).toEqual [[4, 20], [4, 23]]
expect(buffer.getMarkerRange(marker4)).toBeUndefined()

2
src/app/buffer.coffee
View File

@@ -271,7 +271,7 @@ class Buffer
getMarkers: ->
_.values(@validMarkers)
createMarker: (range, options) ->
markRange: (range, options) ->
marker = new BufferMarker(_.extend({
id: @nextMarkerId++
buffer: this