github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 05:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't allow float or int Editor's to have NaN as a value

Browse Source
This commit is contained in:
probablycorey
2013-04-24 16:14:35 -07:00
committed by Corey Johnson & Kevin Sawicki
parent cedea831f7
commit ecad6bc2a8
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/app/config-panel-spec.coffee
View File

@@ -72,3 +72,9 @@ describe "ConfigPanel", ->
expect(config.get('foo.int')).toBe 3
expect(config.get('foo.float')).toBe 3.3
expect(config.get('foo.string')).toBe 'All limitations are self imposed.'
panel.intEditor.setText('')
panel.floatEditor.setText('ha ha')
window.advanceClock(10000) # wait for contents-modified to be triggered
expect(config.get('foo.int')).toBe 0
expect(config.get('foo.float')).toBe 0

5
src/app/config-panel.coffee
View File

@@ -32,6 +32,7 @@ class ConfigPanel extends View
bindEditors: ->
for editor in @find('.editor[id]').views()
console.log editor
do (editor) =>
name = editor.attr('id')
type = editor.attr('type')
@@ -41,6 +42,6 @@ class ConfigPanel extends View
editor.getBuffer().on 'contents-modified', ->
value = editor.getText()
if type == 'int' then value = parseInt(value)
if type == 'float' then value = parseFloat(value)
if type == 'int' then value = parseInt(value) or 0
if type == 'float' then value = parseFloat(value) or 0
config.set name, value