github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-25 06:48:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate unnecessary event listener removals

Browse Source
This commit is contained in:
Nathan Sobo
2017-04-06 16:58:13 -06:00
parent 9c28cc0fa8
commit f15b6d9074
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/dock.js
View File

@@ -80,8 +80,6 @@ module.exports = class Dock {
destroy () {
this.subscriptions.dispose()
this.paneContainer.destroy()
this.resizeHandle.destroy()
this.toggleButton.destroy()
window.removeEventListener('mousemove', this.handleMouseMove)
window.removeEventListener('mouseup', this.handleMouseUp)
window.removeEventListener('drag', this.handleDrag)
@@ -651,10 +649,6 @@ class DockResizeHandle {
}
}
destroy () {
this.element.removeEventListener('mousedown', this.handleMouseDown)
}
handleMouseDown (event) {
if (event.detail === 2) {
this.props.onResizeToFit()
@@ -695,11 +689,6 @@ class DockToggleButton {
return this.bounds
}
destroy () {
this.innerElement.removeEventListener('click', this.handleClick)
this.innerElement.removeEventListener('dragenter', this.handleDragEnter)
}
update (newProps) {
this.props = Object.assign({}, this.props, newProps)