github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 05:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Dispose nodes associated with a LineComponent when replacing it

Browse Source
This commit is contained in:
Antonio Scandurra
2017-05-09 18:30:44 +02:00
parent ca3395b1b2
commit f58fd749aa
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/text-editor-component.js
View File

@@ -3453,12 +3453,7 @@ class LinesTileComponent {
textNodesByScreenLineId
})
this.element.insertBefore(newScreenLineComponent.element, oldScreenLineComponent.element)
// Instead of calling destroy on the component here we can simply
// remove its associated element, thus skipping the
// lineNodesByScreenLineId bookkeeping. This is possible because
// lineNodesByScreenLineId has already been updated when creating the
// new screen line component.
oldScreenLineComponent.element.remove()
oldScreenLineComponent.destroy()
this.lineComponents[lineComponentIndex] = newScreenLineComponent
oldScreenLineIndex++