Katrina Uychaco
4e9048d22d
Create saveDialog helper function and name file in message
2016-04-14 23:25:27 -07:00
Katrina Uychaco
6988546790
Update to use current APIs
2016-04-14 22:02:35 -07:00
Katrina Uychaco
7876d55d68
Merge branch 'master' of https://github.com/einarmagnus/atom into einarmagnus-master
2016-04-13 20:01:46 -07:00
Michelle Tilley
8575b38c7b
Pending pane items shouldn't be made permanent before being replaced
...
Previously, when a Pane would replace a pending item with
another pending item, it would emit
`onItemDidTerminatePendingState` for that item, which was
not true because the item was actually being destroyed.
2016-04-02 17:48:24 -07:00
Michelle Tilley
f6d419c2f4
Merge pull request #11057 from atom/mkt-improve-pane-add-item-options
...
Move Pane::addItem 'pending' option to options object
(cherry picked from commit 53a9c22554 )
2016-03-07 10:02:49 -08:00
Katrina Uychaco
e620232d35
Add new item before destroying pending item
...
Fixes atom/tabs#278
Signed-off-by: Michelle Tilley <binarymuse@github.com >
2016-03-03 17:46:02 -08:00
Katrina Uychaco
b7f0f794f8
Don't destroy pane if replacing last pending item
...
Signed-off-by: Michelle Tilley <binarymuse@github.com >
2016-02-29 17:11:11 -08:00
Ben Ogle
920d348014
Only move legit items to the top of the stack
...
Fixes #11002 cc @natalieogle
2016-02-29 11:32:28 -08:00
Michelle Tilley
2dad38a782
onDidTerminatePendingState ➡️ onItemDidTerminatePendingState
...
Signed-off-by: Katrina Uychaco <kuychaco@github.com >
2016-02-28 17:57:59 -08:00
natalieogle
420a8d8692
Add activatePreviousRecentlyUsedItem to pane model and add specs.
2016-02-27 20:45:02 -08:00
natalieogle
bc28a91e02
🎨 Change the structure of a few pieces relating to serialization.
2016-02-27 20:45:02 -08:00
natalieogle
553b3f3300
Change name of function that moves the active item to the top of the item stack.
2016-02-27 20:45:02 -08:00
natalieogle
48ef672524
Remove redundant items.length check.
2016-02-27 20:45:02 -08:00
natalieogle
9610703874
Add check to only build itemStack if there are items.
2016-02-27 20:45:02 -08:00
natalieogle
69a6b9e5c5
Add keymap for 'ctrl-tab ^ctrl' in order to move item to top of stack when lifting ctrl.
2016-02-27 20:45:01 -08:00
natalieogle
3641cc0296
Remove redundant MRU function.
2016-02-27 20:45:01 -08:00
natalieogle
fe52ce6011
Modify serialize functions and add function to move through the item stack in order of most recently used.
2016-02-27 20:45:01 -08:00
natalieogle
6466cb489e
Add serialize and deserialize functionality to the itemStack.
2016-02-27 20:45:01 -08:00
natalieogle
7a6c8f53a4
Add activateMostRecentlyUsedItem to pane model.
2016-02-27 20:45:00 -08:00
Katrina Uychaco
8fff6b2dd0
isItemPending(item) ➡️ getPendingItem()
2016-02-25 17:27:39 -08:00
Katrina Uychaco
6add9ce9e4
isItemPending(item) ➡️ getPendingItem()
2016-02-25 17:25:39 -08:00
Katrina Uychaco
3848da4488
💄 and 📝 for pending API
2016-02-25 17:21:01 -08:00
Katrina Uychaco
b637366a58
Workspace#setItemNotPending ➡️ Item#onDidTerminatePendingState
...
Signed-off-by: Michelle Tilley <binarymuse@github.com >
2016-02-25 16:09:40 -08:00
Michelle Tilley
d0ffbca845
💄 and 📝 for pending state
2016-02-25 10:49:11 -08:00
Katrina Uychaco
a487110521
Refactor pending state to live in pane instead of items
...
* New public API `workspace.setItemNotPending` that
packages can use to set an item to set an item to not pending
(e.g. when the user interacts with the item)
* Pending state for newly opened items with `{pending: true}`
is now tracked by `Pane` instead of the item, and packages like
`tabs` that query this information now get it from the Pane.
2016-02-24 18:30:09 -08:00
Wliu
43dc50f907
Pass the notification manager when splitting panes
...
Fixes #9587
2016-02-18 22:32:00 -05:00
Lee Dohm
57ea5c0fc4
Fix typo in function call
2016-02-12 18:57:38 -08:00
Aaron Contreras
500afb0f20
Improve split API, add new commands and rewrite existing ones
...
Allow empty splits, as well as moving (instead of copying) active item
2016-02-02 00:50:10 +01:00
Katrina Uychaco
4c1ebdf1b9
Merge branch 'master' into ku-pending-editor
2016-01-14 17:40:41 -08:00
Katrina Uychaco
44a648a9ea
Destroy any existing pending pane item when adding a pending item
2016-01-14 17:21:48 -08:00
Katrina Uychaco
24b2f5e0cc
Keep pending pane upon losing focus
2016-01-13 18:53:10 -08:00
Nathan Sobo
db74f4a8f0
Merge pull request #10178 from atom/ku-pending-editor
...
Open file in pending state on single click
2016-01-08 14:45:14 -07:00
Katrina Uychaco
3bcb062ab0
Add friendly message for ETIMEDOUT
2016-01-06 18:23:25 -08:00
Katrina Uychaco
9efb3328bc
Add helper to map error codes to friendly messages
2016-01-06 18:20:46 -08:00
Katrina Uychaco
63b5ddbd99
Handle out-of-bound indices for ::activateItemAtIndex
2015-12-24 13:58:59 -08:00
Katrina Uychaco
e26ae05597
Fix bug in ::activateItemAtIndex
...
Revert to original code to conform to specs.
2015-12-24 13:34:58 -08:00
Katrina Uychaco
4c4e16ac3b
Fix bug in ::activateItem
...
Only destroy active item if it is not the same as the new item.
2015-12-24 12:29:22 -08:00
Katrina Uychaco
219ebea98b
Fix bug in ::activate Item
...
Check if isPending function exists on item before invoking.
2015-12-24 01:31:19 -08:00
Katrina Uychaco
27cc953c07
Destroy pending item when new item is activated
2015-12-24 01:08:28 -08:00
Eli Fatsi
84a6f0cb75
Remap pane:show-item-9 to activate last pane item
2015-11-11 10:09:09 -07:00
Kevin Sawicki
e95ce5d1d0
Handle EAGAIN errors when saving pane items
...
Closes #8202
2015-11-10 16:30:12 -08:00
Kevin Sawicki
24511fef92
Add custom notification for ELOOP save errors
...
Closes #9242
2015-11-10 15:55:23 -08:00
Nathan Sobo
d2fdc414e7
Merge pull request #8919 from bencolon/workspace_vertical_splits
...
Add top/bottom split options when opening uri in a workspace
2015-10-22 14:13:42 -06:00
Ben Colon
1b0d72b232
Add up/down split options when opening uri in a workspace
2015-10-22 17:03:10 +02:00
Nathan Sobo
bd199545c0
In PaneContainer.prototype.saveAll, only save modified items
2015-10-21 20:22:20 -06:00
Nathan Sobo
84aa8471b4
Pass AppDelegate to Workspace, Pane instead of bound functions
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 18:54:48 -06:00
Nathan Sobo
ed1c37cdbf
Bind confirm when deserializing panes
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 17:29:41 -06:00
Max Brunsfeld
369f3d2648
Don't use atom.{notifications,config,deserializers,confirm} in Pane
...
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Max Brunsfeld
9924288a6f
Use atom environment argument to deserialize in Pane, PaneAxis
2015-10-07 15:25:05 -05:00
Nathan Sobo
3d118b8a33
Pass atom environment as second arg when deserializing objects
2015-10-07 15:24:56 -05:00