Corey Johnson
0255e44f00
Remove suppressUpdates
2014-06-17 13:38:08 -07:00
Corey Johnson
0a671fc386
Add a div that triggers overflowchanged events on resize
2014-06-17 13:28:05 -07:00
Corey Johnson
c06f5911c6
Update editor height change spec
2014-06-17 13:26:56 -07:00
Nathan Sobo
9e6756ed6d
Don't perform an update in response scroll view dimension changes
...
We always measure the scroll view in the ::componentWillUpdate hook, so
performing *another* update in response to the measurement causes an
invariant violation in react. Whenever we are measuring, we are always
already updating.
2014-06-13 17:07:41 -06:00
probablycorey
8d84a97b2b
Move scroll view measurements to componentWillUpdate
2014-06-13 11:36:40 -07:00
Corey Johnson
e96d2dbd17
Add the simplest resize fix that will work.
2014-06-12 16:17:45 -07:00
Corey Johnson
025370b9f8
Add editor component resize spec
2014-06-12 16:17:18 -07:00
Corey Johnson
4186a4943b
Remove react shims deprecations
2014-06-12 14:53:09 -07:00
Corey Johnson
e179860519
Merge pull request #2571 from lee-dohm/bug-2526
...
Change line commenting to uncomment if all non-blank lines are commented out
2014-06-12 08:45:47 -07:00
Ivan Žužak
43f8596fb1
Merge pull request #2584 from atom/iz-fix-tab-unindent
...
Outdent only if a tab is matched at the start of the line
2014-06-12 17:39:23 +02:00
Ben Ogle
2c7d01e398
Merge pull request #2588 from atom/bo-fix-page-up-down
...
Fix pageUp and pageDown in the react editor
2014-06-11 17:30:59 -07:00
Ben Ogle
1bdf45f7d6
Fix gutter width
...
When you had a 1000 line file and you fold everything
into 10 lines, it would make the gutter width only large
enough for the 10 lines, so line 999 wouldnt properly
fit in the gutter.
Refs #2423
2014-06-11 17:28:12 -07:00
Ben Ogle
7e6e61905b
Move the cursor on pageUp / pageDown
...
Previously it was only moving the scrollTop, but not the cursors.
Affected on the react editor.
Refs #2423
2014-06-11 17:19:59 -07:00
Corey Johnson
01b4ff24b9
Dedupe grim
2014-06-11 16:50:45 -07:00
Corey Johnson
47e2cb4645
Update grim and its related modules
2014-06-11 16:50:45 -07:00
Ben Ogle & Nathan Sobo
236f4c5342
Upgrade git-diff to update diff correctly after comitting
2014-06-11 17:40:13 -06:00
Ben Ogle & Nathan Sobo
911390aba8
Upgrade find-and-replace for React fixes
2014-06-11 17:38:01 -06:00
Nathan Sobo
5f602ad86e
Merge pull request #2567 from atom/bo-scroll-speed
...
Slow the scroll speed
2014-06-11 14:44:20 -06:00
Kevin Sawicki
9da9c77e61
Add paths that work on Git 1.7
2014-06-11 13:24:54 -07:00
Kevin Sawicki
8ed05a4201
Only log spec output on failures
2014-06-11 13:24:13 -07:00
Kevin Sawicki
a8533c1010
Fail build if any specs fail on Windows
2014-06-11 13:24:13 -07:00
Ben Ogle
87915f70e2
editor.scrollSensitivity option
2014-06-11 12:07:49 -07:00
Ben Ogle
ec07cb9524
Slow the scroll speed
2014-06-11 12:07:48 -07:00
Corey Johnson
d4ae3ac548
Upgrade to language-c@0.17.0
2014-06-11 12:04:40 -07:00
Nathan Sobo
1b4426e3ba
Don't pause overflowchanged events after React editor updates
...
Fixes #2237
Previously, operations such as typing and scrolling were triggering
overflowchanged events on the editor, which concerned me because we
were performing lots of unnecessary measurements of the scroll view.
Now that we draw extra lines above and below the visible screen row
range, this doesn't happen, so we can remove this pausing code which
was delaying the resizing of the editor in certain situations.
2014-06-11 12:07:05 -06:00
Kevin Sawicki
32245b1d92
Remove humanizeKeystrokes specs
...
These are already tested thoroughly in underscore-plus and
they are now platform-specific now which this spec was not
expecting.
2014-06-11 10:59:08 -07:00
Nathan Sobo
030bcd6d4f
Make react cursor the width of a default character at the end of lines
...
When the cursor is positioned before a character, we always make it the
width of that character. But at the end of a line, there is no character
to use to set the width, so we just use the defaultCharWidth.
This makes the block cursor visible on empty lines in vim-mode.
2014-06-11 11:54:10 -06:00
Kevin Sawicki
f1628fb1e0
Only codesign on Mac OS X
2014-06-11 10:45:12 -07:00
Nathan Sobo
7c1a4a9e08
Don't clip range start/end in DisplayBuffer::pixelRectForScreenRange
...
Fixes #2583
This prevents the cursor from having 0 width inside atomic tokens.
2014-06-11 11:40:57 -06:00
Kevin Sawicki
3b1c70911f
Upgrade to minidump 0.7
2014-06-11 10:30:28 -07:00
Kevin Sawicki
70fc084864
Upgrade to settings-view@0.121
2014-06-11 10:28:25 -07:00
Kevin Sawicki
d9152e856b
Upgrade to tree-view@0.100
2014-06-11 10:28:25 -07:00
Corey Johnson
10dba4b9a0
Revert "Upgrade find-and-replace@0.116.0"
...
This reverts commit efea4c6d05
2014-06-11 10:23:29 -07:00
Corey Johnson
5e51445118
Update cursor z-index
2014-06-11 10:04:31 -07:00
Corey Johnson
f4b7f86eb0
Revert "Remove editor-colors class from lines component"
...
This reverts commit 8cca198af1
2014-06-11 10:02:16 -07:00
Ivan Zuzak
07308a4e04
✅ Add test for outdenting with tabs after normal characters
2014-06-11 19:02:14 +02:00
Corey Johnson
8cca198af1
Remove editor-colors class from lines component
2014-06-11 09:53:56 -07:00
Ben Ogle
efea4c6d05
Upgrade find-and-replace@0.116.0
2014-06-11 09:42:11 -07:00
Ivan Zuzak
588d9b97eb
Unindent only if the tab is at the start of the line
2014-06-11 18:31:37 +02:00
Corey Johnson
4f77a371f4
Merge pull request #2497 from atom/cj-add-react-editor-shims
...
Add shims to the React View Editor
2014-06-11 09:06:40 -07:00
Corey Johnson
94dd1eed54
Merge remote-tracking branch 'origin/master' into cj-add-react-editor-shims
...
Conflicts:
src/editor-component.coffee
2014-06-11 08:56:27 -07:00
Ben Ogle
09b91974a7
Fix casing on Grim import
2014-06-11 08:52:36 -07:00
Nathan Sobo
99611fad34
Give React editor lines and line numbers an opaque background
...
This ensures subpixel antialiasing works correctly. It was previously
present on both of these components but got dropped accidentally.
2014-06-11 08:51:19 -06:00
Nathan Sobo
1b026cc805
Set is-focused class on React editor's wrapper view for now
2014-06-11 08:37:16 -06:00
Nathan Sobo
4c0d87080a
Update git-diff so specs pass with React editor enabled
2014-06-11 08:30:17 -06:00
Nathan Sobo
a09eb96982
Upgrade bookmarks to pass specs with react editor enabled
2014-06-11 08:05:30 -06:00
Nathan Sobo
5531d54554
Upgrade autosave to support react editor focusout events
2014-06-11 08:00:04 -06:00
Nathan Sobo
b73d267a5f
Merge branch 'master' into cj-add-react-editor-shims
2014-06-11 07:34:41 -06:00
Nathan Sobo
5add0e4f70
Don't forceUpdate in setImmediate callback if editor is unmounted
...
This was throwing errors in the EditorComponent spec.
/cc @benogle, just so you're aware
2014-06-11 07:21:05 -06:00
Nathan Sobo
7040906473
Ignore null bytes when measuring character widths in React editor
...
Fixes #2391
2014-06-11 07:18:52 -06:00
