Commit Graph

2236 Commits

Author SHA1 Message Date
Nathan Sobo
0ef4c7e172 Only re-render the gutter when we render new lines 2012-05-29 15:12:11 -06:00
Nathan Sobo
3e26386f98 Always re-render gutter from the first rendered to the last rendered screen row 2012-05-29 14:51:19 -06:00
Nathan Sobo
0700aba67f All specs pass again with overdraw 2012-05-29 13:39:13 -06:00
Nathan Sobo
6e34124f12 Overdraw gutter line numbers in addition to editor lines 2012-05-29 13:07:24 -06:00
Nathan Sobo
a9c9a854ac Only truncate change ranges to the last visible row if the last rendered row is smaller
This happens, for example, when the entire buffer is shorter than the number of rows on screen. In this case, the last rendered row is not smaller than the last possible visible row.
2012-05-29 13:03:29 -06:00
Nathan Sobo
c00c3317f0 Down to 2 failures by truncating change ranges to the range of the current rendered lines 2012-05-29 12:52:39 -06:00
Nathan Sobo
e9a67208e6 Adjust otherwise-passing spec for overflow 2012-05-29 11:50:54 -06:00
Nathan Sobo
8fba4ff935 Fix some off by one errors in the overdraw calculations 2012-05-26 13:52:48 -07:00
Nathan Sobo
328aa3ba6b WIP: Redoing overdraw code… it's broken 2012-05-26 13:05:25 -07:00
Nathan Sobo
351c283ed6 Merge branch 'master' into overdraw 2012-05-25 13:13:06 -07:00
Nathan Sobo
7c105a0446 Tweak fold line colors
The deselected orange is now a darkened version of the orange used for coffeescript arrows in the twilight theme. The selected color is now a green based on the color of the cursor, to lend a feeling of similarity between the fold line and the cursor.
2012-05-25 12:46:27 -07:00
Nathan Sobo
e2ca3814a9 Hide the cursor when it is on a fold line 2012-05-25 12:35:32 -07:00
Corey Johnson & Nathan Sobo
ce5a31b5a2 Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-25 11:41:19 -07:00
Corey Johnson & Nathan Sobo
f6db1a2051 remove bufferRow arg from Renderer.registerFold() 2012-05-25 11:17:50 -07:00
Corey Johnson & Nathan Sobo
35b2f0e8c7 Buffer changes updates a stable list of folds 2012-05-25 11:05:45 -07:00
Corey Johnson & Nathan Sobo
bbcb59fe93 Buffer changes updates a stable list of folds 2012-05-25 10:58:30 -07:00
Corey Johnson & Nathan Sobo
f8c3d89e60 When folds are selected they are highlighted 2012-05-24 16:39:14 -07:00
Corey Johnson & Nathan Sobo
c11ee74405 Remove unused css 2012-05-24 14:08:32 -07:00
Corey Johnson & Nathan Sobo
74594ed2be Destroy folds before inserting text on a fold line. Spec for deleting a fold line. 2012-05-24 13:53:48 -07:00
Corey Johnson & Nathan Sobo
f97912c160 💄 2012-05-24 11:43:09 -07:00
Corey Johnson & Nathan Sobo
9b83ce6545 renderer tells editor when the gutter needs to be updated 2012-05-24 11:17:37 -07:00
Corey Johnson & Nathan Sobo
c1197c1d0e spec 💄 2012-05-23 14:56:22 -07:00
Corey Johnson & Nathan Sobo
dd7fff4522 WIP: Adding specs for various fold corner cases… think we still have some issues and gutter updates are failing. 2012-05-23 11:03:33 -07:00
Corey Johnson & Nathan Sobo
04f4a9a765 WIP: Handle buffer change events correctly with respect to folded lines
We're handling changes that straddle the start row and are in the middle of the fold, but we're still screwing up when the old range straddles the end row.
2012-05-22 19:02:13 -07:00
Corey Johnson & Nathan Sobo
13416bd6f2 Add Buffer.logLines() 2012-05-22 18:58:11 -07:00
Corey Johnson & Nathan Sobo
9afc12b05c Now that folds are linewise, we don't need to adjust the start row of buffer change events 2012-05-22 13:24:31 -07:00
Corey Johnson
7b4ebcdd42 Changes inside a fold correctly change the start/end row 2012-05-22 12:09:37 -07:00
Corey Johnson
a7d43c2cca meta-alt-u unfolds lines at cursor 2012-05-22 09:38:14 -07:00
Corey Johnson
ed271fee0f Remove unused methods from Fold 2012-05-22 09:11:09 -07:00
Corey Johnson
50146ce3ae Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-22 08:52:30 -07:00
Nathan Sobo
74008ab329 Fold placeholder lines are treated as if they're empty 2012-05-21 19:20:18 -07:00
Nathan Sobo
6387f512c7 Translate buffer positions inside of folds to column 0 of the first line of the fold 2012-05-21 19:02:05 -07:00
Nathan Sobo
3f4c7deb30 Nuke stray call to Editor.logLines 2012-05-21 19:00:02 -07:00
Nathan Sobo
72f1874c5b Nuke more old fold specs 2012-05-21 18:55:05 -07:00
Nathan Sobo
031c04b888 Clean up remaining position translation spec for folds. It still has one legit failure though. 2012-05-21 18:48:28 -07:00
Nathan Sobo
f3cada9e20 Nuke some fold tests that don't matter anymore 2012-05-21 18:46:16 -07:00
Nathan Sobo
581998f94b Oh, un-F 2012-05-21 18:35:51 -07:00
Nathan Sobo
87d0c1d189 Can use ffdescribe, ffit, fffdescribe, fffit to raise the focus priority. 2012-05-21 18:35:03 -07:00
Nathan Sobo
7744d6087b Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-21 17:56:16 -07:00
Nathan Sobo
f39891b912 Folds are destroyed when their placeholder line is clicked 2012-05-21 17:55:58 -07:00
Corey Johnson
b4e8157172 💄 2012-05-21 15:27:36 -07:00
Corey Johnson
a5656400aa Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-21 15:01:23 -07:00
Corey Johnson
d2899fa58a Folds handle change events 2012-05-21 15:01:14 -07:00
Nathan Sobo
527e243d1a Style fold lines a bit 2012-05-21 14:30:35 -07:00
Nathan Sobo
7ad5830521 Convert failing specs to linewise code folding 2012-05-21 14:18:00 -07:00
Corey Johnson
8af289dde1 Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification 2012-05-21 13:45:07 -07:00
Nathan Sobo
ce1c1ff081 Render fold lines with the 'fold' class and remove old fold placeholder support 2012-05-21 13:38:39 -07:00
Nathan Sobo
9beff8edbb Un-F 2012-05-21 13:36:19 -07:00
Nathan Sobo
4f60135d81 Remove random indent that was causing editor spec not to run 2012-05-21 13:35:54 -07:00
Corey Johnson
d7e1ffcdf2 Update render spec to new version of Renderer.createFold 2012-05-21 10:29:48 -07:00