Commit Graph

24337 Commits

Author SHA1 Message Date
Ross Allen
16d98c534c Explain dismiss when called programmatically 2015-07-13 14:36:08 -07:00
Ross Allen
580201568f Add docblocks for Notification public functions
* Mark `dismiss` as an "extended" API because its use case is uncommon.
* Mark event handler functions as public because responding to a
  notification being displayed or dismissed is useful.
2015-07-13 14:32:40 -07:00
bolinfest
6efb48dca4 Merge pull request #7863 from atom/bf-no-transform-for-of
Do not run the for/of transform in Babel.
2015-07-13 14:11:29 -07:00
Nathan Sobo
4fedaaa802 Merge pull request #7869 from atom/iz-fix-scopes-example
Fix config.set scope selector example
2015-07-13 13:58:51 -05:00
Ivan Zuzak
2d7691c19a Fix config.set scope selector example 2015-07-13 06:51:01 -07:00
Michael Bolin
ad1a110b77 Do not run the for/of transform in Babel.
Because the target environment in Atom supports for/of natively,
do not transpile for/of using Babel. Without this change, the following code:

```
var arr = ['foo', 'bar', 'baz'];
for (var item of arr) console.log(item);
```

would be unnecessarily be transpiled to:

```
var arr = ['foo', 'bar', 'baz'];
var _iteratorNormalCompletion = true;
var _didIteratorError = false;
var _iteratorError = undefined;

try {
  for (var _iterator = arr[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
    var item = _step.value;
    console.log(item);
  }
} catch (err) {
  _didIteratorError = true;
  _iteratorError = err;
} finally {
  try {
    if (!_iteratorNormalCompletion && _iterator['return']) {
      _iterator['return']();
    }
  } finally {
    if (_didIteratorError) {
      throw _iteratorError;
    }
  }
}
```
2015-07-12 21:12:08 -07:00
Machisté N. Quintana
bcbd389a98 Merge pull request #7841 from atom/mq-bump-settings-view
settings-view@0.211.2
2015-07-11 08:18:08 -04:00
Machisté N. Quintana
95ab4d2283 ⬆️ settings-view@0.211.2 2015-07-11 07:20:40 -04:00
Max Brunsfeld
162d9182ae ⬆️ text-buffer 2015-07-10 14:17:40 -07:00
Ivan Žužak
16960aefdd ⬆️ atom-keymap@5.1.6 2015-07-10 14:06:51 +02:00
Ben Ogle
3d861c7442 ⬆️ 0.175.0 2015-07-09 15:47:59 -07:00
Ben Ogle
5863146ea5 ⬆️ scandal@2.0.5 2015-07-09 15:46:51 -07:00
Nathan Sobo
5566d54f58 Don’t update screen lines if DisplayBuffer has been destroyed 2015-07-09 15:44:11 -05:00
Nathan Sobo
c7d99140b9 Merge pull request #7638 from atom-community/jf-dispatch-grammar-used
Add activationHooks + Trigger `{grammar-package-name}:grammar-used` Hook When A text-editor-element's Grammar Is Set
2015-07-09 15:42:31 -05:00
Nathan Sobo
53162160bb Merge pull request #7809 from atom/dh-register-views-earlier
Move view registration for Pane & Gutter related views earlier
2015-07-09 11:54:55 -05:00
Nathan Sobo
55df856bf7 Merge pull request #7813 from atom/ns-display-buffer-invariant-assertion
More consistency checks for DisplayBuffer and TokenizedBuffer
2015-07-09 11:19:31 -05:00
Nathan Sobo
4567601ae9 Maintain change counts for debugging purposes
When we have an unexpected display-buffer or tokenized-buffer state,
we can include the change counts to make sure that every change to the
buffer has been processed by display-buffer and tokenized-buffer. If
they haven’t, there’s something wrong with our event ordering. If they
have, there’s a logic error somewhere else.
2015-07-09 02:18:24 -05:00
Nathan Sobo
afa6c9a786 Add invariant assertion about line count to see if we can find a bug
Does the line count ever get out of whack after an update, or is it
happening in some other way?
2015-07-09 01:55:13 -05:00
Nathan Sobo
028acbcae4 Don’t call method to read stack
If the line is undefined, we want the stack to be null.
2015-07-09 01:51:36 -05:00
Joe Fitzgerald
f954aa2732 Rename @hooks >> @ activationHookEmitter 2015-07-09 02:38:06 -04:00
Joe Fitzgerald
b3b046aa66 Add activationHooks To package.json
- Trigger the `{grammar-package-name}:grammar-used` hook when grammar is set for tokenized-buffer
2015-07-09 02:33:17 -04:00
Nathan Sobo
587e898867 Remove assertion since we call this with out of range rows legitimately 2015-07-09 00:28:46 -05:00
Nathan Sobo
de8d1d95d8 Add assertion about removing the last selection 2015-07-09 00:23:11 -05:00
Nathan Sobo
442e75853b Base textNodeLength on textNode.textContent.length
This is how we were computing the length previously. Not sure what the
difference is but I want to keep it the same.
2015-07-09 00:18:42 -05:00
Nathan Sobo
a352a2ca61 Try to avoid exceptions due to undefined lines in TokenizedBuffer 2015-07-09 00:13:06 -05:00
Nathan Sobo
1dd1770b1a Assert the liveness of editor model when attaching editor view 2015-07-09 00:13:05 -05:00
Kevin Sawicki
8bad01ca5b Guard against null item like saveItem/saveItemAs does 2015-07-08 21:11:49 -07:00
Ben Ogle
650ef16344 ⬆️ settings-view@0.211.1
Fix regression!!!
2015-07-08 18:09:06 -07:00
Kevin Sawicki
56a951ef66 ⬆️ tree-view@0.178 2015-07-08 17:28:52 -07:00
Daniel Hengeveld
b13ee1c9cb re-add Pane require 2015-07-08 17:21:39 -07:00
Max Brunsfeld
f6ce49dd67 Merge pull request #7808 from atom/mb-handle-nan-in-workspace-open
Ignore NaN coordinates passed to workspace.open
2015-07-08 17:17:55 -07:00
Daniel Hengeveld
afee699137 Move view registration for Pane & Gutter related views earlier
Registering them in pane-container led to packages deserializing
before e.g. Gutter was available.
2015-07-08 17:07:26 -07:00
Ben Ogle
d55428e8fe ⬆️ autocomplete-plus@2.18.1 2015-07-08 17:05:59 -07:00
Ben Ogle
b9207e92e8 ⬆️ autocomplete-plus@2.18.0 2015-07-08 17:01:46 -07:00
Max Brunsfeld
c60c00f626 Ignore NaN coordinates passed to workspace.open 2015-07-08 16:50:17 -07:00
Kevin Sawicki
2cf0632b9c Merge pull request #7802 from atom/ks-handle-more-save-errors
Handle more open/save error codes with custom notifications
2015-07-08 15:57:17 -07:00
Kevin Sawicki
22f7379f32 Handle UNKNOWN open errors 2015-07-08 15:40:43 -07:00
Kevin Sawicki
27a94b4d70 Handle ENOTCONN open errors 2015-07-08 15:40:42 -07:00
Kevin Sawicki
955749b320 Handle EIO open errors 2015-07-08 15:40:42 -07:00
Kevin Sawicki
de4cf38dcc Handle ENXIO open errors 2015-07-08 15:40:42 -07:00
Kevin Sawicki
770dc9821e paneItem -> item for consistency 2015-07-08 15:40:42 -07:00
Kevin Sawicki
8c9ecbaf03 Add custom notification for ESPIPE 2015-07-08 15:40:42 -07:00
Kevin Sawicki
485f4dc3a3 Add custom notification for EINTR 2015-07-08 15:40:42 -07:00
Kevin Sawicki
c3e73bdd26 Add custom notification for EIO 2015-07-08 15:40:42 -07:00
Kevin Sawicki
3e744b0714 Add custom notification for ENOTSUP 2015-07-08 15:40:42 -07:00
Kevin Sawicki
7d88f9ea66 Use item path when error has no path 2015-07-08 15:40:42 -07:00
Nathan Sobo
cac74b9567 Merge pull request #7804 from atom/ns-clip-position
Clip positions in TokenizedBuffer::scopeDescriptorForPosition
2015-07-08 17:36:07 -05:00
Kevin Sawicki
e290b949c8 Merge pull request #7797 from atom/code-of-conduct
Add code of conduct to contributing guidelines
2015-07-08 15:23:14 -07:00
Nathan Sobo
b953a11fa5 Clip positions in TokenizedBuffer::scopeDescriptorForPosition 2015-07-08 17:06:05 -05:00
Nathan Sobo
9c63de930e Merge pull request #7798 from atom/ns-undefined-screen-line-metadata
Report extra metadata when screen lines are undefined when clipping
2015-07-08 17:01:29 -05:00