Commit Graph

36353 Commits

Author SHA1 Message Date
Ash Wilson
1a48b987ca Allow LaunchScenario::launch() to accept an existing app 2019-04-18 17:05:25 -04:00
Ash Wilson
b854a698f7 Dump a shorthand description of the actual windows on assert failure 2019-04-18 17:05:08 -04:00
Ash Wilson
109fb1116b Make the stubbed openLocations() sync for simplicity 2019-04-18 17:04:37 -04:00
Ash Wilson
9eb259ce20 Guarantee the window opening order 2019-04-18 17:03:43 -04:00
Ash Wilson
097906c23f AtomWindow tests 2019-04-18 16:20:26 -04:00
Ash Wilson
6d4ba52454 Update AtomEnvironment specs with new location keys 2019-04-18 16:20:08 -04:00
Ash Wilson
8f4c24b4e5 initialPaths and representedDirectoryPaths renaming 2019-04-18 16:19:23 -04:00
Ash Wilson
db2f8302bf Bring the stub AtomWindow up to date 2019-04-18 16:19:06 -04:00
Ash Wilson
2abbabdafe Respect "headless" on non-spec windows 2019-04-18 16:18:49 -04:00
Ash Wilson
0b0d3485ae Injectable BrowserWindow constructor in AtomWindow 2019-04-18 16:18:32 -04:00
Ash Wilson
45770f1fe6 Use isDirectory instead of mustBeDirectory 2019-04-18 16:18:09 -04:00
Ash Wilson
631743f5f4 Rename setRepresentedDirectoryPaths() to setProjectRoots()
Let's keep the naming consistent the whole way up the call chain.
2019-04-18 16:17:53 -04:00
Ash Wilson
495f493c44 Rename hasProjectPath to hasProjectPaths
Likely a relic of the days when there was only one project.
2019-04-18 16:17:07 -04:00
Ash Wilson
a0be3e735f Use containsLocations() for AtomApplication window location 2019-04-18 16:16:17 -04:00
Ash Wilson
2a2ef17d85 Use containsLocation() for URL handler processing 2019-04-18 16:15:45 -04:00
Ash Wilson
952c42c0de Rename initialPaths and representedDirectoryPaths
They're now called initialProjectRoots and projectRoots, which is closer 
to what they actually are.
2019-04-18 16:15:07 -04:00
Ash Wilson
b095482071 Replace containsPath(s) with containsLocation(s)
This lets us use existing stat data.
2019-04-18 16:12:51 -04:00
Ash Wilson
efeb2cdb0a stat locations in parsePathToOpen() 2019-04-18 16:11:02 -04:00
Ash Wilson
f66002e193 Create stubbed AtomWindows instead of real ones in app tests 2019-04-18 10:51:25 -04:00
Ash Wilson
41eacf7af7 Move AtomWindow creation into a dedicated, stubbable method 2019-04-18 10:51:02 -04:00
Ash Wilson
f7fd560ca0 :doc: comment reflow 2019-04-17 15:56:59 -04:00
Ash Wilson
87a4213b6a Rewrite AtomApplication::openPaths() logic to find existing windows 2019-04-17 15:56:49 -04:00
Ash Wilson
9b40488652 Replace tests for scenarios I observed with tests for scenarios we want 2019-04-17 15:18:29 -04:00
Ash Wilson
bd788b1cbd 📝 a/an 2019-04-17 15:13:17 -04:00
Ash Wilson
9409ba821c Account for a window being destroyed before an IPC message is delivered 2019-04-17 15:13:02 -04:00
Ash Wilson
4c432b6010 Don't send IPC replies to destroyed windows 2019-04-17 15:12:25 -04:00
Ash Wilson
1fc2f9b4ba Increase beforeEach, afterEach, and emitterEventPromise timeouts
This is to temporarily work around spikes in the window launch time.
2019-04-17 15:09:44 -04:00
Ash Wilson
a48dd69232 Getter for AtomWindow's loadedPromise 2019-04-17 14:10:14 -04:00
Ash Wilson
9af51897f0 Override and restore ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT 2019-04-17 14:09:43 -04:00
Ash Wilson
b3ab30dcf5 Abstract "wait for window to finish loading" logic 2019-04-17 14:09:19 -04:00
Ash Wilson
b591f83447 Avoid binding expectOpenEvent into the closure 2019-04-17 13:09:56 -04:00
Ash Wilson
4f8de4bb0a Comment on launch scenarios that correspond to file manager launches 2019-04-17 13:09:29 -04:00
Ash Wilson
58c6292905 Tests for the remaining command-line cases 2019-04-17 10:24:03 -04:00
Ash Wilson
fc1af26e34 Show "incorrect window" banner for mismatched results 2019-04-17 10:23:22 -04:00
Ash Wilson
2f48ad097b Boolean logic is hard okay 2019-04-17 10:23:07 -04:00
Ash Wilson
bc4a22f97a Resolve root and editor paths during spec parsing for consistency 2019-04-17 10:22:51 -04:00
Ash Wilson
a53398daf7 Allow file references by basename or short path 2019-04-16 16:00:31 -04:00
Ash Wilson
f0dc842293 Distinguish between launch and open 2019-04-16 16:00:12 -04:00
Ash Wilson
58bd9bfa33 Don't open all precondition windows twice (oops) 2019-04-16 15:59:46 -04:00
Ash Wilson
2a50d87999 Use a single application to launch all precondition windows 2019-04-16 15:59:08 -04:00
Ash Wilson
08a29df12f Omit untitled editors (at least for now) 2019-04-16 15:38:03 -04:00
Ash Wilson
8e15d9656a Log missing roots instead of extra roots twice 2019-04-16 15:37:45 -04:00
Ash Wilson
d3b5ce0b4b Use _ for an empty project root or editor path group
Co-Authored-By: Jason Rudolph <jason@jasonrudolph.com>
2019-04-16 15:37:01 -04:00
Ash Wilson
839544e0a9 Launch scenario test framework 2019-04-16 14:56:03 -04:00
Nathan Sobo
4ce00667b5 ⬆️ fuzzy-finder@1.13.1 to fix atom/fuzzy-finder#380 2019-04-15 14:28:49 -06:00
Winston Liu
7c6b614b92 Merge pull request #19160 from sadikovi/language-java-0.31.3
⬆️ language-java@0.31.3
2019-04-13 15:59:57 -04:00
Ivan Sadikov
9d89f7b4ee update sha 2019-04-13 18:27:56 +02:00
Ivan Sadikov
605cfb9cc2 update to language-java 0.31.3 2019-04-13 18:04:18 +02:00
Jason Rudolph
4a29f442bb Merge pull request #19143 from atom/temp-0.9.0
⬆️temp@0.9.0
2019-04-12 10:05:14 -04:00
Rafael Oleza
74308fbabb Merge pull request #19145 from atom/add-traces-to-test
Add debug traces to failing test steps
2019-04-12 14:00:27 +02:00