Nathan Sobo
1cab51cefa
RootView can no longer be focused.
...
Allowing root view to be focused was stealing focus away from the
editor whenever a click event made it to the root view. This unnecessary
switching of focus was interfering with the ability to drag tabs.
But if RootView can't be focused, focus ends up being returned to the
document body when there are no focusable elements. This would be fine,
except for the fact that we frequently bind global events on root view,
and so they aren't triggered when events are triggered on the body. We
could just bind all global events on the body, but this would require
us to always attach elements to the DOM during specs, which is a serious
performance killer in specs.
The workaround is in the keymap. When the keymap handles a key event
that was triggered on the body, it triggers the corresponding semantic
event on the root view anyway, so from the event perspective, it's as
if the root view actually had focus. The only place this might fall
down is if someone wants to capture raw key events. But that's the
keymap's job anyway, and we maybe add a hook on the keymap if such a
need ever arises.
2013-02-08 17:33:37 -07:00
Justin Palmer
2d968c11a1
this should cause tabs to be draggable
2013-02-08 14:41:14 -07:00
Justin Palmer
ecb21964f7
Merge pull request #250 from github/update-icon
...
Update app icon
2013-02-07 16:46:16 -08:00
Justin Palmer
140a54c53d
remove poor lighting
2013-02-07 16:06:21 -08:00
Justin Palmer
03fb964351
💄
2013-02-07 15:59:16 -08:00
Justin Palmer
95a7bc69ce
slightly adjust the size
2013-02-07 15:52:15 -08:00
Justin Palmer
714acd852f
💀 to the :octocat:
2013-02-07 15:47:48 -08:00
Justin Palmer
2f0b1b793f
a better temporary icon
2013-02-07 12:27:29 -08:00
Justin Palmer
5983d7e30c
new temporary icon
2013-02-07 12:01:15 -08:00
Nathan Sobo
9973fb14e8
Run rake clean prior to running rake install
2013-02-07 12:23:37 -07:00
Nathan Sobo
1cd1e887d5
Merge branch 'readme-updates' into dev
2013-02-06 21:33:59 -07:00
Justin Palmer
2ca9949d1c
cmd -> meta
2013-02-06 21:33:31 -07:00
Justin Palmer
4b50e9bd82
go to line
2013-02-06 21:33:31 -07:00
Justin Palmer
8faf1ed5d5
add treeview shortcuts
2013-02-06 21:33:31 -07:00
Nathan Sobo
6be72bac54
Guard against undefined marker ranges
2013-02-06 20:45:50 -07:00
Justin Palmer
eb7f4514e4
Merge pull request #244 from github/ui-polish
...
Ui polish
2013-02-06 18:33:50 -08:00
Justin Palmer
6395f352d6
adjust position of command panel stats
2013-02-06 17:13:50 -08:00
Nathan Sobo
9c6b658fe5
Merge branch 'dev' into markers
2013-02-06 18:10:42 -07:00
Nathan Sobo
5b3755a170
Fix errors in benchmarks
...
One notable change is that if the editor has a display update pending,
we wait until it completes before moving on to the next benchmark.
2013-02-06 18:01:32 -07:00
Nathan Sobo
56c81ccf0f
Memoize head and tail screen positions in DisplayBufferMarker
2013-02-06 17:32:13 -07:00
Nathan Sobo
4fdb1c454e
Restore marker cleanup assertions
...
Now that EditSessions clean up their markers, we can pass these tests
again.
2013-02-06 17:29:08 -07:00
Justin Palmer
efa31b82fa
adjust command panel colors
2013-02-06 16:26:13 -08:00
Justin Palmer
cb4abb201a
pray the gray away
2013-02-06 16:19:02 -08:00
Kevin Sawicki
c69e217192
Ignore title changes from dev tools client
...
Previously the generic developer tools message
would be set as the window title when opened
and only removed once the active edit session was
changed.
2013-02-06 15:58:39 -08:00
Nathan Sobo
0bd98bf8f8
Do a better job cleaning up after Editors and EditSessions
...
- EditSessions destroy their Selections when they are destroyed
- Editors destroy their EditSessions when they are destroyed
- Editors unsubscribe from the document and window when they are
removed from the DOM.
- When an EditSession is destroyed via any code path, the Editor with
that EditSession removes it.
- Selections no longer trigger 'destroyed' events if their parent
EditSession has already been destroyed.
These are all really intertwined, so I'm doing them as one commit
since that was the only way to keep the specs green.
2013-02-06 16:54:19 -07:00
Nathan Sobo
3e040f3f40
Upgrade vendored SpacePen to d9b6b4a2fe3fdeca07bb82e14e412718540f89f3
2013-02-06 16:40:19 -07:00
Justin Palmer
5ad38c9bc6
bracket matcher animation was kind of annoying when typing between brackets
2013-02-06 15:14:00 -08:00
Justin Palmer
1f50ca8d16
cleanup statusbar styles
2013-02-06 15:12:22 -08:00
Will Farrington
b333cf2734
rake clean should kill the compiled scripts directory
2013-02-06 15:10:25 -08:00
Justin Palmer
124b2c0c07
lets do just mini on the grammar overlay since it originates from the middle
2013-02-06 14:48:33 -08:00
Justin Palmer
3675407ca7
use from-bottom overlay for grammar view
2013-02-06 13:51:40 -08:00
Justin Palmer
cec0757f55
sublte animation on bracket match
2013-02-06 13:40:12 -08:00
Nathan Sobo
28c31dc2e1
Merge branch 'dev' into markers
2013-02-06 14:27:30 -07:00
Justin Palmer
d52e3d5a97
Merge branch 'dev' of https://github.com/github/atom into dev
2013-02-06 10:56:30 -08:00
Nathan Sobo
6561d89e1c
Upgrade vendored SpacePen to f6ef4ba2ffdc27b6c9a057560f1f527b1e0f3e8b
2013-02-06 11:40:46 -07:00
Kevin Sawicki & Nathan Sobo
936c3cf625
Upgrade vendored SpacePen to f6ef4ba2ffdc27b6c9a057560f1f527b1e0f3e8b
2013-02-06 11:30:39 -07:00
Justin Palmer
086806f690
Merge pull request #240 from github/markdown-cleanup
...
Markdown styles cleanup
2013-02-06 10:30:07 -08:00
Jon Rohan
2d6bd15027
Just some gradient adjustments on the light tabs.
2013-02-06 09:35:16 -08:00
Justin Palmer
ac2d5c136b
match more of the look of .com's markdown style
2013-02-06 09:32:07 -08:00
Justin Palmer
c62b75804e
consolidate markdown styles into the markdown package
2013-02-06 09:21:46 -08:00
Justin Palmer
c2c8621394
Merge pull request #238 from github/semantic-tabs
...
Update tab design
2013-02-06 09:05:09 -08:00
Justin Palmer
dae6cacfce
update blurred styles for ui light
2013-02-06 08:57:07 -08:00
Justin Palmer
63a4dbdeb2
ui light tab styles
2013-02-06 08:57:07 -08:00
Justin Palmer
b66b4ac213
consolidate margins
2013-02-06 08:57:07 -08:00
Justin Palmer
f13ea7086e
💄
2013-02-06 08:57:07 -08:00
Justin Palmer
6c0b40d5c0
adjust treeview look to match new tabs
2013-02-06 08:57:07 -08:00
Justin Palmer
f55c048d19
blurred styles for new tab design
2013-02-06 08:57:07 -08:00
Justin Palmer
6d24200fae
move font size into tab class
2013-02-06 08:57:07 -08:00
Justin Palmer
8c9b9b335d
bring back ❌ when hovering over a modified file
2013-02-06 08:57:07 -08:00
Kevin Sawicki
36477279a1
Shift modified icon up and to the left 1px
2013-02-05 21:29:40 -08:00
