Commit Graph

15386 Commits

Author SHA1 Message Date
Michelle Tilley
6425b5e069 Merge pull request #14131 from atom/mkt-prepare-build-for-per-package-transpilation
Update build to pre-compile packages with per-package transpilation configs
2017-04-06 00:39:50 -07:00
Max Brunsfeld
c810ac4f5b Merge pull request #14136 from atom/mb-ns-dont-auto-open-dock-when-adding-item
Open docks when activating their panes, but not when adding items
2017-04-05 12:44:21 -07:00
Max Brunsfeld
caafa41f6f Open docks when activating their panes, but not when adding items 2017-04-05 12:00:38 -07:00
Nathan Sobo
6ac29939e5 Merge pull request #14125 from atom/mb-ns-open-with-item
Allow workspace item objects to be passed to Workspace.open
2017-04-05 12:59:03 -06:00
Nathan Sobo
a74d561f3c Merge pull request #14134 from atom/fb-mdt-dont-store-default-locations
Don't store default locations
2017-04-05 10:59:01 -06:00
Max Brunsfeld
e14e31d9b5 Don't copy workspace items that don't implement .copy()
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-04-05 10:48:31 -06:00
Matthew Dapena-Tretter
fed2372c30 Don't store default locations
This will probably be less confusing for developers experimenting with
changing the default location. Also, we avoid storing extra info we
don't really need.
2017-04-04 14:49:34 -07:00
Bryant Ung
8bc325b922 Merge pull request #14063 from dietmar/linux_middle_mouse_8648
fixing middle mouse button clipboard paste on linux (atom:atom#8648)
2017-04-04 14:22:40 -07:00
Matthew Dapena-Tretter
881cbbd17f Add delete() method to StateStore
This allows us to delete single items.
2017-04-04 13:45:14 -07:00
Max Brunsfeld
32ff2f37d9 Merge pull request #14108 from atom/fb-mdt-remember-moved-item-positions
🐛 Fix observation of moved items
2017-04-04 10:20:24 -07:00
Nathan Sobo
56cefbbc63 Support passing items to Workspace.toggle and .hide
Also, ensure that passing an item that is not yet present in the
workspace does not interfere with resolving the location where we want
to place the item.
2017-04-04 11:18:12 -06:00
Max Brunsfeld
1552854f3b Allow workspace item objects to be passed to Workspace.open 2017-04-04 11:18:12 -06:00
Michelle Tilley
2d5b533530 Allow root package paths to contain 'node_modules' 2017-04-04 07:54:35 -07:00
Michelle Tilley
155c3a14bf Perform per-package transpilation on bundled packages during build 2017-04-04 07:54:14 -07:00
Antonio Scandurra
0e1bc58310 ⬆️ electron-link 2017-04-04 11:36:49 +02:00
Wliu
03be104141 Merge pull request #14119 from cs150bf/fix-14109-and-13978
Fix issue #14109 and #13978
2017-04-03 19:07:17 -04:00
Nathan Sobo
67fc7d0ccb Merge pull request #14107 from atom/fb-mdt-open-always-adds-item
Always add opened items to the workspace
2017-04-03 15:42:11 -06:00
Hong Chen
89dae42092 Fix issue https://github.com/atom/atom/issues/14109 and https://github.com/atom/atom/issues/13978
First argument to dialog.showSaveDialog() needs to be a BrowserWindow

https://github.com/electron/electron/blob/master/docs/api/dialog.md
https://github.com/electron/electron/blob/master/lib/browser/api/dialog.js
2017-04-03 20:47:36 +08:00
Antonio Scandurra
6ecb9086ee Assign Package.prototype.mainModulePath eagerly for preloaded packages
Many packages currently use this instance variable instead of calling
`Package.prototype.getMainModulePath`. With this commit we will eagerly
compute it for preloaded packages too and therefore prevent third party
packages that rely on this implementation detail from breaking.
2017-04-03 14:11:23 +02:00
Antonio Scandurra
6a8d0915db Fix deactivating and reactivating preloaded package 2017-04-03 10:34:32 +02:00
Antonio Scandurra
cef72fd66f Merge pull request #14080 from atom/as-preload-packages
Packages preloading
2017-04-03 09:59:34 +02:00
Matthew Dapena-Tretter
4ed53578ce 🐛 Fix observation of moved items
`PaneContainer::onDidAddPaneItem` isn't triggered on moves.
2017-03-31 16:48:49 -07:00
Matthew Dapena-Tretter
9663101671 Always add opened items to the workspace
This commit changes the behavior of `open()` so that the item will be
added to the workspace—even if the `activateItem` option is false.

This provides a way to open (and add) an item without activating it,
but removes the ability to open without adding. For that, we've made
the `createItemForURI()` method public 😊
2017-03-31 14:17:09 -07:00
Nathan Sobo
5557219fbc Merge pull request #14027 from atom/fb-mdt-save-focused-pane-item
Add `saveFocusedPaneItem()` and call it in "core:save" command
2017-03-31 13:57:50 -06:00
Matthew Dapena-Tretter
dec52a7384 Add atom.workspace.hide()
This adds an method for hiding items by URI and re-implements
`toggle()` in terms of it. (tbh it's really just extracting most of
`toggle()` into a new function.)
2017-03-30 17:37:55 -07:00
Max Brunsfeld
817467f0a8 Merge branch 'master' into fb-mdt-docks 2017-03-30 11:16:21 -07:00
Lee Dohm
6a76ef5dd6 Merge pull request #13764 from atom/wl-dont-soft-wrap-minis
Disable soft wrap on mini editors
2017-03-29 14:38:47 -07:00
Nathan Sobo
c7a4755808 If Workspace.open finds existing item, yield event loop
This ensures that the function always behaves asynchronously regardless
of the state of the workspace.

/cc @maxbrunsfeld

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2017-03-29 09:27:21 -06:00
Matthew Dapena-Tretter
0d12396bf3 Add saveFocusedPaneItem() and call it in "core:save" command
Also, do the same for "core:save-as" and `saveFocusedPaneItemAs()`.
This behavior change means that pane items in docks (#13977) will be
savable too.
2017-03-28 14:05:29 -07:00
Nathan Sobo
45bd466384 Don’t add item in Workspace.open if activateItem is false
We thought it was a bug that activateItem: false caused the
item not to be added, but it turned out there were package
tests that depended on this behavior.

Ideally, we should have an addItem option that exhibits this
behavior instead.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2017-03-28 15:00:13 -06:00
Antonio Scandurra
5e6938c1a8 Use core: instead of core/ when adding resources during snapshot 2017-03-28 13:35:35 +02:00
Antonio Scandurra
a25b58a559 Use @preloaded instead of checking if pack is bundled and dev mode is on 2017-03-28 11:52:25 +02:00
Antonio Scandurra
ab9326687d Streamline path resolution for preloaded packages 2017-03-28 11:47:45 +02:00
Antonio Scandurra
672259ec51 Deactivate preloaded package when the same package has been linked 2017-03-28 10:22:29 +02:00
Antonio Scandurra
557fac226d Read devMode from PackageManager in Package 2017-03-28 10:22:29 +02:00
Antonio Scandurra
19010b9424 Activate menus, context menus, keymaps and settings during preload 2017-03-28 10:22:29 +02:00
Antonio Scandurra
974e1b7f4a Preload settings 2017-03-28 10:22:29 +02:00
Antonio Scandurra
ab1411b1d7 Preload bundled grammar paths 2017-03-28 10:22:29 +02:00
Antonio Scandurra
9c469eb337 Deactivate and delete preloaded packages if they are disabled 2017-03-28 10:22:29 +02:00
Antonio Scandurra
de47a26c5d WIP: Start preloading packages 2017-03-28 10:22:29 +02:00
Antonio Scandurra
fd0cd13271 Fix typo 2017-03-28 10:22:29 +02:00
Antonio Scandurra
e9c13a92ed Extract a loadAvailablePackage method and avoid doing work twice
This will reuse the information that comes from `getAvailablePackages`,
thus avoiding to resolve, for example, a package path twice.
`PackageManager.loadPackage` will still be supported for backward
compatibility, but it will use `loadAvailablePackage` under the hood.
2017-03-28 10:22:29 +02:00
Antonio Scandurra
b913ad8bb5 Extract a getAvailablePackages method and start using it 2017-03-28 10:22:29 +02:00
Matthew Dapena-Tretter
08e8975a10 Always show the dock when an item is dropped into it
Previously, we were only showing it when going from 0 -> 1 items (which
is a bug).
2017-03-27 18:17:02 -07:00
Matthew Dapena-Tretter
3b23ab44bc Add getLocation() to PaneContainer class
This allows the location to be inspected without having to jump to the
DOM and searching for a dock element.
2017-03-27 17:45:21 -07:00
Matthew Dapena-Tretter
401a549bf5 Don't open items in disallowed locations 2017-03-27 17:45:21 -07:00
Matthew Dapena-Tretter
41953ae7d6 Only show dock toggle buttons when dragging if item is allowed 2017-03-27 17:45:15 -07:00
Matthew Dapena-Tretter
f3c3917825 Don't show the dock toggle button if it's closed and empty 2017-03-27 14:20:47 -07:00
Matthew Dapena-Tretter
13f0c8a977 Docks: define handle size in CSS; measure in JS 2017-03-27 12:19:08 -07:00
Michelle Tilley
1ff5c9e684 Merge pull request #13963 from atom/ku-mkt-restore-atom-env-when-adding-folder-to-fresh-window
Restore atom environment when adding project folders to a fresh window
2017-03-27 10:56:37 -07:00