Commit Graph

152 Commits

Author SHA1 Message Date
Antonio Scandurra
173fbba02b Wrap at the first CJK character before the boundary 2015-12-11 14:26:51 +01:00
Antonio Scandurra
c22cae451b Wrap line at boundary if it includes a CJK character 2015-12-10 10:18:24 +01:00
Antonio Scandurra
3253c0d5cd Don't rely on spaces to test korean characters' width behavior 2015-12-10 10:07:46 +01:00
Nathan Sobo
2f81e5faac Store folds in their own marker layer 2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b Add TextEditor-level marker layers and use them for selections 2015-11-09 00:35:31 -07:00
Nathan Sobo
3a25fe4975 Remove id from decoration properties
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
2af010e729 Remove dead test
It tests functionality that no longer matters since we don’t subscribe
to decorations being destroyed in DisplayBuffer
2015-11-09 00:35:26 -07:00
Antonio Scandurra
eb3133b7e7 💚 2015-10-16 10:30:45 +02:00
Antonio Scandurra
b03aa4bf40 Merge branch 'master' into as-cjk-soft-wrap
# Conflicts:
#	spec/display-buffer-spec.coffee
2015-10-16 10:23:44 +02:00
Antonio Scandurra
4766c98bbe Treat Korean characters as different kinds of chars 2015-10-15 21:02:21 +02:00
Antonio Scandurra
c616e86a00 Take into account half width chars as well 2015-10-15 19:24:00 +02:00
Antonio Scandurra
4818d47980 Update wrapped screen lines when default width changes 2015-10-15 18:10:26 +02:00
Antonio Scandurra
27dc3da9e5 🎨 Conflate setting default and double-width chars width
Because they will always change together, and having two different setters seems
highly error-prone.
2015-10-15 17:53:37 +02:00
Antonio Scandurra
20b0523833 💚 2015-10-15 16:41:27 +02:00
Antonio Scandurra
c2ee942df1 Take double width chars into account when soft wrapping 2015-10-15 16:24:08 +02:00
Antonio Scandurra
3c33a7ba9f Soft wrap based on default character width 2015-10-15 15:22:18 +02:00
Nathan Sobo
122bf72c75 Don’t use atom.packages global in TokenizedBuffer 2015-10-07 15:25:00 -05:00
Nathan Sobo
b2359f44a6 Don’t use atom.grammars global in TokenizedBuffer 2015-10-07 15:25:00 -05:00
Nathan Sobo
dc0709ef9e Don’t use atom.assert global in DisplayBuffer 2015-10-07 15:24:59 -05:00
Nathan Sobo
edd666b845 Don’t use atom.config global in DisplayBuffer 2015-10-07 15:24:59 -05:00
Antonio Scandurra
a0277728d6 🔥 Remove deprecated methods 2015-09-25 12:58:23 +02:00
Antonio Scandurra
ce714b9852 🎨 Rename to ::onDidRequestAutoscroll 2015-09-25 10:57:09 +02:00
Antonio Scandurra
99e77dc09d Port leftover specs from DisplayBuffer 2015-09-24 11:41:02 +02:00
Antonio Scandurra
91ef57ed29 Merge branch 'master' into as-display-buffer-logical-coordinates
# Conflicts:
#	src/display-buffer.coffee
2015-09-23 18:46:16 +02:00
Antonio Scandurra
f1c0658470 🔥 Remove double tested behavior 2015-09-23 15:34:43 +02:00
Antonio Scandurra
49fae9b029 Test that the logical scroll event is triggered 2015-09-23 15:34:43 +02:00
Antonio Scandurra
e75812cfbf 🔥 Remove specs
...as we are already testing a similar behavior in the presenter
2015-09-23 15:34:43 +02:00
Antonio Scandurra
8463d5c59d Start porting DisplayBuffer specs 2015-09-23 15:34:43 +02:00
Nathan Sobo
68fe7026a8 Disable deprecated APIs in specs 2015-09-22 10:37:07 -06:00
Nathan Sobo
eddd84c843 Drop jQuery from spec helper
Some of the global spec-helper methods that depend on jQuery may need
to be removed from package specs, but most should be rare based on my
checks.
2015-09-18 20:48:48 -06:00
Max Brunsfeld
b8aec9db7c Fix display buffer spec for new historied marker behavior 2015-08-25 10:50:05 -07:00
Nathan Sobo
1223d7a154 Process closing scopes at wrap boundaries 2015-08-11 13:13:30 -06:00
Max Brunsfeld
a60f330628 Default maintainHistory marker option to false 2015-07-21 13:27:05 -07:00
aki
449c03cb35 Fix destroy listeners 2015-06-16 18:05:45 +09:00
Machiste Quintana
d5bcc0433d WIP: 👕 Fix linter errors 2015-05-22 16:29:12 -04:00
Nathan Sobo
865015e47d Correctly compute bufferDelta for last soft wrap line segment
Fixes #6885
2015-05-21 19:56:53 +02:00
Max Brunsfeld
2bfbb7619e Fix bug w/ markers mutated inside of change listeners 2015-05-19 17:48:53 -07:00
Max Brunsfeld
a1cc35b270 Fix DisplayBuffer spec
Marker updates now happen after all buffer changes
2015-05-19 15:18:20 -07:00
Jess Lin
cdca9c3ef1 [Gutter] Fix coffeescript style issues 2015-04-22 07:29:00 -07:00
Jess Lin
58d6712b0e [Gutter] Augment Decoration to discern the line-number gutter from custom gutters 2015-04-22 07:28:57 -07:00
Jesse Grosjean
409775b53e Improved specs for clipping pixel positions above/below display buffer 2015-04-01 12:39:22 -04:00
Jesse Grosjean
b067a6175f add screenPositionForPixelPosition spec 2015-03-30 13:52:28 -04:00
Nikolaus Wittenstein
b28ee92896 Add tests for DisplayBuffer::screenPositionForBufferPosition around soft tabs
This makes sure that a buffer position in the middle of a soft tab will
correctly clip to the closest edge by default.
2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
5a3f2035a1 Replace skipAtomicTokens with clip
When clipping a screen position, callers used to have to pick between
clipping to the left edge or the right edge when the position was in the
middle of an atomic token. This change allows them to choose the closest
edge, and makes this the default.

This makes selecting hard tabs (or any other atomic tokens) work in a
similar manner as in other text editors; that is, when clicking near
the middle of a tab, the insertion point will move to the closest edge
rather than the left edge.
2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
372fb49c88 TokenizedLine::screenColumnForBufferColumn calculates more accurately
screenColumnForBufferColumn used to break only if the current column
was strictly greater than the target column. This commit changes it so
it breaks when greater or equal, which is how bufferColumnForScreenColumn
works.

This also adds some unit tests for screenColumnForBufferColumn's
interactions with hard tab characters.
2015-03-29 19:43:25 -04:00
Nathan Sobo
10458a5b45 Always autoscroll when the range of the last selection changes
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-03-26 15:30:53 -06:00
Max Brunsfeld
2f5d975338 Remove autoscroll-related legacy editor view support
Signed-off-by: Nathan Sobo <nathan@github.com>
2015-03-26 11:12:37 -07:00
Nathan Sobo
2bfd30c832 Revert "Revert "Don't soft-wrap on indentation"" 2015-03-19 14:37:39 -06:00
Nathan Sobo
6345799cf3 Revert "Don't soft-wrap on indentation" 2015-03-19 12:47:58 -06:00
Antonio Scandurra
56020b11b0 🐛 Avoid soft-wrapping on indentation 2015-03-19 11:36:55 +01:00