Commit Graph

142 Commits

Author SHA1 Message Date
Ian Olsen
22a881323c Move shouldDestroyBufferOnFileDelete callback to TextBuffer constructor
Also add setting the callback to buffers created via deserialization.
2017-01-20 13:52:49 -08:00
Ian Olsen
dcbd839059 Tell text-buffer to ask about destroying buffers for deleted files 2017-01-19 14:11:41 -08:00
Max Brunsfeld
6f4a506517 Remove InputComponent.getDomNode method
Access the dom node directly in TextEditorElement instead

Signed-off-by: Damien Guard <damieng@github.com>
2016-12-08 16:12:26 -08:00
Max Brunsfeld
efd20774de Make each atom-text-editor keep a consistent hidden input node for its lifetime
Signed-off-by: Damien Guard <damieng@github.com>
2016-12-08 16:05:45 -08:00
Antonio Scandurra
f160ccecd1 Include relatedTarget when dispatching blur events from TextEditorElement 2016-11-23 18:15:18 +01:00
Antonio Scandurra
c6832d5b0e Add TextEditorElement.lightDOM to make package specs backward compatible 2016-10-17 16:19:14 +02:00
Antonio Scandurra
883bb15276 Don't trigger a blur event when focusing the same editor twice 2016-10-17 16:18:54 +02:00
Antonio Scandurra
901b0b17a3 Fix failing tests 2016-10-07 13:41:00 +02:00
Antonio Scandurra
91df848b8a Keep a backward compatible DOM structure for atom-text-editor contents 2016-10-07 10:40:41 +02:00
Antonio Scandurra
56a6510b25 Start on removing shadow DOM 2016-10-07 10:40:41 +02:00
Indrek Ardel
55f3311c01 Remove unused variables 2016-09-26 20:52:13 +03:00
bene
66dd70d19d 📝 fix arugments not marked as such [ci skip] 2016-08-31 21:16:49 +02:00
Nathan Sobo
106621e161 Deprecate automatic assignment of autoHeight for text editors
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.

This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.

This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Max Brunsfeld
11463ef00b Merge remote-tracking branch 'origin/as-introduce-editor-update' into ns-mb-detangle-editor 2016-08-11 11:36:48 -07:00
Nathan Sobo
b256a1450a Remove grammars from TextEditorElement.initialize 2016-07-28 15:48:22 -06:00
Max Brunsfeld
738a2b90dc 🔥 useShadowDOM setting 2016-07-28 10:02:16 -07:00
Antonio Scandurra
7efb407d8a Write spec for TextEditorElement when autoHeight changes 2016-06-30 15:48:00 +02:00
Antonio Scandurra
8cb0fbcc5c Allow autoHeight to be set from the editor 2016-06-30 15:27:47 +02:00
Antonio Scandurra
c769b169aa Allow scrollPastEnd to be set from the editor 2016-06-30 15:05:21 +02:00
Nick Smith
8b6940c463 Update text-editor-element.coffee 2016-03-30 22:53:42 -04:00
Mark H. Wilkinson
e0f41d1af4 Fix typo in error message. 2016-03-25 00:05:10 +00:00
joshaber
6cc80e05ff Default to auto height being true.
Otherwise TextEditorElements created through the tag wouldn’t have a
setting and be wrong.
2016-03-04 16:36:47 -05:00
joshaber
98c8a08ac3 s/ignoreScrollPastEnd/scrollPastEnd 2016-03-03 10:06:15 -05:00
joshaber
dfd3e1b948 Take autoHeight as an argument. 2016-02-25 17:11:04 -05:00
joshaber
ff0b9e30a9 Add ignoreScrollPastEnd 2016-02-25 16:59:58 -05:00
joshaber
dd83619c45 Add autoHeight setting. 2016-02-25 16:05:57 -05:00
Antonio Scandurra
cb4c27757a 📝 TextEditorElement::invalidateBlockDecorationDimensions 2015-12-04 15:35:53 +01:00
Antonio Scandurra
937116a280 Render only visible and yet-to-be-measured block decorations 2015-12-03 11:26:45 +01:00
Nathan Sobo
9714f2e729 Emit decoration events synchronously in legacy spec environment
This is needed to keep a bunch of package tests passing that expect
synchronous decoration updates.
2015-11-09 00:35:31 -07:00
Antonio Scandurra
40e3b08a8c Add TextEditorElement::getMaxScrollTop 2015-10-20 08:36:27 +02:00
Max Brunsfeld
778023c78b Make factory for StylesElements on atom.styles 2015-10-09 13:46:32 -07:00
Antonio Scandurra
c3d85f85a4 🔥 Remove unused LOC 2015-10-07 15:25:06 -05:00
Antonio Scandurra
534f038631 Don't use atom globals in TokenIterator 2015-10-07 15:25:02 -05:00
Antonio Scandurra
2532a9cd59 Don't use atom globals in StylesElement 2015-10-07 15:25:02 -05:00
Antonio Scandurra
112ee01bd9 Don't use atom globals in TextEditorElement
...except when the element is instantiated via HTML
2015-10-07 15:25:01 -05:00
Nathan Sobo
51abab930d Parameterize config on editor instead of using global atom.config 2015-10-07 15:24:58 -05:00
Nathan Sobo
e0d426b817 Register deserializers, view providers, and commands in Atom constructor
Previously, these registrations were scattered all over the codebase and
required that `global.atom` be defined, which creating weird ordering
issues. Registering them all from the global makes the relationships
clearer and means we don’t have to assign a global to set up a fully-
functional environment.
2015-10-07 15:24:52 -05:00
Antonio Scandurra
c1ef87ac8b 🎨 2015-09-30 10:35:19 +02:00
Antonio Scandurra
5cb63c8b90 Add feature flag to detect logical display buffer 2015-09-30 10:16:47 +02:00
Antonio Scandurra
5cfc5b67ae Allow listening for TextEditorElement events before attaching it
Fixes atom/wrap-guide#43

/cc: @maxbrunsfeld
2015-09-30 09:09:33 +02:00
Antonio Scandurra
3ad9bb3d21 Fix typo on TextEditorElement ::getWidth/::getHeight 2015-09-28 14:14:23 +02:00
Antonio Scandurra
7316eb4d52 🔥 Drop deprecated methods from the public API 2015-09-25 17:27:14 +02:00
Antonio Scandurra
051baebd9c Shim ::setHeight and ::getHeight to TextEditorElement 2015-09-25 11:15:41 +02:00
Antonio Scandurra
33a67ad3c9 Shim ::setWidth and ::getWidth to TextEditorElement 2015-09-25 11:05:41 +02:00
Antonio Scandurra
19ca87f79f 💚 Fix specs 2015-09-24 11:27:54 +02:00
Antonio Scandurra
535a9da946 wip 2015-09-24 11:21:26 +02:00
Antonio Scandurra
3236c8f0f8 Let's start with deprecations! 2015-09-24 10:07:38 +02:00
Antonio Scandurra
91ef57ed29 Merge branch 'master' into as-display-buffer-logical-coordinates
# Conflicts:
#	src/display-buffer.coffee
2015-09-23 18:46:16 +02:00
Antonio Scandurra
36b0aa0126 🔥 2015-09-23 18:45:32 +02:00
Antonio Scandurra
87c7a0ae30 💚 Fix some TextEditorComponent specs 2015-09-23 16:25:50 +02:00