Nathan Sobo
95ec0d8162
Replaces usages of .mini selector with [mini]
2014-11-13 16:04:57 -08:00
Nathan Sobo
b6b6b6d12b
Add ‘mini’ attribute to TextEditorElement if .isMini() is true on model
2014-11-13 16:04:57 -08:00
Nathan Sobo
9f194ff4df
Create an empty TextBuffer if needed in TextEditor constructor
2014-11-13 16:04:57 -08:00
Nathan Sobo
ed6ca9cd06
Remove .editor class to force themes to style background via :host
...
The goal is to allow the editor’s styling to be overridden as follows:
atom-text-editor {
background: black;
color: white;
}
If we retain these classes, themes will continue to style the root
element of the editor and destroy the ability to style the editor in
this way. You would instead have to do the following:
atom-text-editor::shadow .editor {
background: black;
color: white;
}
This is way less intuitive and confusing for people.
2014-11-13 16:04:57 -08:00
Nathan Sobo
08971562cd
Store useShadowDOM setting when TextEditorElement is created
...
Rather than reading it repeatedly, since the value could potentially
change over time.
2014-11-13 16:04:56 -08:00
Nathan Sobo
99b08826dd
Style non-shadow DOM editor with it’s own style sheet
...
Trying to style both modes of the text editor with the same style sheet
is proving to be more trouble than it’s worth. This prepares the shadow
DOM style sheet to diverge more radically to enable the background color
to be overridden from the outside more easily.
2014-11-13 16:04:24 -08:00
Ben Ogle
e596bf6ef9
Merge pull request #4144 from atom/bo-overlay-decoration
...
Overlay decorations
2014-11-12 15:02:40 -08:00
Ben Ogle
b369a1085c
Use headPixelPosition in overlay decoration rendering
2014-11-12 14:43:52 -08:00
Ben Ogle
eae80ca46d
Add a check for negative bounds when translating the overlay
2014-11-12 11:50:22 -08:00
Max Brunsfeld
3521b96611
Don't select the copied line when copying with no selection
2014-11-12 10:12:26 -08:00
Kevin Sawicki
7abfd45baf
Default to using hard tabs in Makefile files
...
This is a temporary solution until scoped settings supports this
type of restriction.
Closes atom/language-make#3
2014-11-12 09:31:12 -08:00
Ben Ogle
12b9f232c2
💄
2014-11-11 16:39:30 -08:00
Ben Ogle
97a671cb49
Works with the shadow DOM disabled.
2014-11-11 16:30:22 -08:00
Ben Ogle
9dfaa8a4e5
Add bounds checking for overlay decorations
2014-11-11 15:46:27 -08:00
Nathan Sobo
e238292075
Remove WorkspaceElement::handleWindowFocus
...
We were getting stack traces in specs when the window got focused caused
by this subscription never getting disposed. We investigated, and can’t
find a case where removing this causes any issues.
Tested:
* Loading/reloading empty window
* Loading/reloading window with pane splits
* Opening/closing dev tools
* Switching focus between atom windows
* Switching focus between applications
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 16:24:02 -07:00
Nathan Sobo
9fd52f600e
Dispose of WorkspaceElement subscriptions when detached
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 16:24:02 -07:00
Nathan Sobo
c75e692269
Don’t add undefined context menus when activating package resources
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 16:24:02 -07:00
Nathan Sobo
6770570f13
Don't call Grim.deprecate for undefined context menus
...
This preserves the original behavior, in which passing undefined to
atom.contextMenu.add was a no-op that returned a no-op disposable.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 16:24:02 -07:00
Nathan Sobo
9875b069bc
Merge pull request #4152 from atom/ns-highlight-region-classes
...
Add private API for adding classes to highlight regions for backward compatibility
2014-11-11 15:20:47 -07:00
Ben Ogle
9399e00033
Properly display when a marker is reversed
2014-11-11 13:32:13 -08:00
Ben Ogle
67d5d997c9
💄 in 📝
2014-11-11 13:08:27 -08:00
Ben Ogle
40c11410f0
Add Cursor::getMarker() method
2014-11-11 13:08:19 -08:00
Ben Ogle
307108ec6c
Specs for positioning the overlay decorations
2014-11-11 13:08:05 -08:00
Ben Ogle
6538da22a6
Fix linter error
2014-11-11 11:25:36 -08:00
Ben Ogle
c79db992d9
Overlay decorations render
2014-11-11 11:25:36 -08:00
Ben Ogle
89ab0becc2
💄
2014-11-11 11:25:36 -08:00
Ben Ogle
58892be6f7
Use proper verbiage for the docs
2014-11-11 11:24:46 -08:00
Ben Ogle
2aaa025d72
Add deprecated getMoveNextWordBoundaryBufferPosition
...
Closes #4151
2014-11-11 11:24:10 -08:00
Max Brunsfeld
1474aa2116
Merge pull request #4148 from atom/mb-cut-line
...
Cut whole lines when no text is selected
2014-11-11 11:13:51 -08:00
Nathan Sobo
2de8046f99
Add deprecatedRegionClass option to highlight decorations
...
This adds a class to each of the contained regions so we can make
existing bundled packages backward-compatible with themes.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 12:11:26 -07:00
Nathan Sobo
a58af721f1
Assign highlight decoration React keys based on decoration id instead of class
...
@benogle: I think this should be fine now that we assign id’s, right?
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2014-11-11 12:11:26 -07:00
Max Brunsfeld
7a87c22c7d
Cut/copy whole lines when no text is selected
...
Closes #3643
2014-11-11 10:02:17 -08:00
Kevin Sawicki
e36eaa56cb
Add windows1252
2014-11-11 09:47:34 -08:00
Kevin Sawicki
84a74d68cf
Remove windows1250 duplicate
2014-11-11 09:47:34 -08:00
Kevin Sawicki
268a3649b6
Use core.fileEncoding as default buffer encoding
2014-11-11 09:47:34 -08:00
Kevin Sawicki
3e67766d1a
Add core.fileEncoding config schema
2014-11-11 09:47:34 -08:00
Max Brunsfeld
3c800b00f5
Always re-render scrollbars after themes load/reload
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2014-11-10 17:59:41 -08:00
Kevin Sawicki
f4ced3b078
Autoscroll when selecting the entire line
...
Closes #4032
2014-11-10 14:51:03 -08:00
Ben Ogle
5c5c6e77fd
Move method to be with similar methods in the docs.
2014-11-10 14:18:35 -08:00
Ben Ogle
e9678a15f1
Add more docs for getPrev/NextWordBoundary methods
2014-11-10 14:18:15 -08:00
Ben Ogle
f0135adb62
Fix method name
2014-11-10 14:17:48 -08:00
Ben Ogle
6159209d49
moveItemTo* -> moveItem*
2014-11-10 13:28:15 -08:00
Ardeshir Javaherchi
ff80545285
🐧 Add keymap implementation to reorder tabs in linux
2014-11-10 11:25:16 -08:00
Nathan Sobo
08dd51a12f
Merge pull request #4121 from atom/mb-inline-commands-in-palette
...
Include inline commands in the command palette
2014-11-10 10:25:36 -07:00
Nathan Sobo
3f869ec191
Merge pull request #4105 from atom/ld-doc-update
...
Remove obsolete jQuery reference in documentation
2014-11-10 10:18:42 -07:00
Nathan Sobo
0fba8ba402
Subscribe to ‘window:open-path’ as a command
2014-11-10 10:10:53 -07:00
Nathan Sobo
7756f4b945
Don’t run ‘beforeunload’ listeners through atom.commands
2014-11-10 10:10:53 -07:00
Nathan Sobo
832e7113f7
Include all inline commands on the bubble path in ::findCommands
2014-11-10 10:10:52 -07:00
Nathan Sobo
aa46e3d26f
Add atom-pane commands via atom.commands again
2014-11-10 10:10:52 -07:00
Nathan Sobo
d48719ab1c
Ignore jQuery and duplicates in CommandRegistry::findCommands
...
Now that jQuery has been patched to add inline listeners and inline
listeners are reported from findCommands, there’s no reason to include
commands based on $.fn.events. Also, we need to ensure the same command
doesn’t get added to the list twice since it could get added by both
inline and selector-based listeners.
2014-11-10 10:09:24 -07:00
