github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity
36,971 Commits 140 Branches 571 Tags
2cc3bff1bee4d994b2eaae5bb536a0621aea2bcd
Commit Graph

8918 Commits

Author SHA1 Message Date
Benjamin Gray
f141ca35a3 Merge branch 'master' of github.com:atom/atom 2019-06-12 14:39:28 +10:00
Antonio Scandurra
ae10429d08 Ensure TextEditorComponent was resized before asserting on its contents 
Previously, we would wait for the next update promise after resizing the 
editor as an indicator of when the resize occurred. Unfortunately, 
resize events are unreliable and may not be emitted right away. This 
could cause the test code to wait for an update promise that was 
unrelated to the resize event (e.g., cursor blinking).

This commit uses a condition-based promise that ensures the rendered 
rows have changed as a result of the resize. This seems to fix the issue 
locally when introducing artificial timeouts in the resize event.
 2019-06-11 16:20:56 +02:00
Antonio Scandurra
2e6a0acf61 Merge pull request #19457 from atom/as/debug-autocomplete-failures 
Run each test suite with a pristine ATOM_HOME directory
 2019-06-07 10:10:37 +02:00
Antonio Scandurra
6a88fa4185 Don't symlink compile-cache folder in AtomWindow tests 
In these tests, we create a temporary `ATOM_HOME` to avoid cluttering 
the user's real `~/.atom` folder.

Adding a symlink to the real `compile-cache` was introduced to speed up 
main process tests, so that the transpilation cache could be reused. 

Unfortunately, when the real `~/.atom` folder did not exist (such as on 
a pristine environment on CI), it would confuse Atom, which would think 
that it didn't need to re-create a `compile-cache` folder again, but 
wouldn't be able to write to it because the symlink pointed to a 
non-existant directory.

Main process tests were overhauled and made faster recently, so we can 
safely remove this performance optimization.
 2019-06-06 17:11:01 +02:00
Rafael Oleza
dd40782166 add delay to watch-path tests to make them less flaky 2019-06-06 16:48:15 +02:00
Rafael Oleza
33f2bd37ee Merge pull request #19444 from atom/improvements-to-ripgrep-scanner 
Improvements to ripgrep scanner
 2019-06-06 16:35:36 +02:00
Rafael Oleza
ac9be2d082 Remove test that checks that we can search of a subfolder of an ignored folder 
This seems to not be working on Windows or with ripgrep, so it's not
expected behaviour.
 2019-06-06 14:02:29 +02:00
Rafael Oleza
8c80d13dd1 Remove logic to prepend wildcard on globs 
That logic was only needed to make `ripgrep` match correctly globs like
`src` when we pass it the folder to search on.

If we don't pass the folder, `ripgrep` assumes it's the cwd and their
glob matching logic improves by allowing globs like `src`.
 2019-06-05 15:07:24 +02:00
Rafael Oleza
95adde37c0 Take into account the includeHidden option in ripgrep scanner 2019-06-05 10:21:06 +02:00
Rafael Oleza
8758c399db Take into account the follow option in ripgrep scanner 2019-06-04 12:21:50 +02:00
Rafael Oleza
3845862f5d Convert beforeEach() function to async 2019-06-04 12:21:50 +02:00
Rafael Oleza
7652d659e5 Take into account the excludeVcsIgnores option in ripgrep scanner 2019-06-04 12:21:50 +02:00
Nathan Sobo
2d3e332b88 Merge pull request #16100 from atom/wl-deserialize-and-activate 
Activate package when deserializing
 2019-06-03 13:44:58 -07:00
Antonio Scandurra
6b9b4f96f8 Merge pull request #19423 from atom/as/multi-stroke-accelerators 
Display multi-keystroke key bindings in menu item's label
 2019-06-03 10:57:26 +02:00
Rafael Oleza
ed6d06b16e Re-apply prettier JS formatter 2019-06-01 00:19:59 +02:00
Rafael Oleza
49cb6f4a7b Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into wl-deserialize-and-activate 2019-06-01 00:19:27 +02:00
Rafael Oleza
040d96ca1b Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into wl-deserialize-and-activate 2019-06-01 00:18:46 +02:00
Rafael Oleza
66f7f1746a Reformat all JS files using prettier 2019-05-31 20:26:19 +02:00
Rafael Oleza
41840abdc2 Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into pr18738 2019-05-31 20:25:41 +02:00
Rafael Oleza
0580aa11d1 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into pr18738 2019-05-31 20:19:05 +02:00
Rafael Oleza
6263d85250 Re-apply prettier JS formatter 2019-05-31 18:55:45 +02:00
Rafael Oleza
948480665f Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into wl-upgrade-webdriverio 2019-05-31 18:52:18 +02:00
Rafael Oleza
77dcd96a66 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into wl-upgrade-webdriverio 2019-05-31 18:51:49 +02:00
Rafael Oleza
eb495f3ccf Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into as/multi-stroke-accelerators 2019-05-31 18:45:39 +02:00
Rafael Oleza
ba7b9e39ec Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into as/multi-stroke-accelerators 2019-05-31 18:42:40 +02:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Rafael Oleza
677bbb7f0b Merge pull request #19408 from atom/enable-no-useless-escape-eslint-rule 
Enable eslint rules that got disabled
 2019-05-31 18:29:31 +02:00
Antonio Scandurra
b04695ee69 Verify context menu item label's text for multi-keystroke key bindings 2019-05-31 16:26:18 +02:00
Antonio Scandurra
091325bd02 Merge branch 'master' into electron-3.1 2019-05-29 18:35:01 +02:00
Rafael Oleza
a14b3a5ddd Enable symbol-description eslint rule 2019-05-27 11:17:29 +02:00
Rafael Oleza
9abdb2f93a Enable no-unused-expressions eslint rule 2019-05-27 11:15:37 +02:00
Rafael Oleza
2139b4b936 Enable prefer-promise-reject-errors eslint rule 2019-05-27 11:11:49 +02:00
Rafael Oleza
dc2df49b60 Enable no-useless-escape eslint rule 2019-05-27 10:59:39 +02:00
Winston Liu
5265528675 🤦‍♀️ 2019-05-25 21:55:15 -04:00
Winston Liu
fe5082df51 Check for focus methods again 2019-05-25 20:53:47 -04:00
Winston Liu
7870675ef4 Re-enable tests 2019-05-25 20:50:53 -04:00
Winston Liu
e9ba8fdc05 Yay, it's green! Clean things up a bit. 2019-05-25 20:50:27 -04:00
Winston Liu
50e8c97db4 Delete the session when we're done, just to be safe 2019-05-25 16:50:45 -04:00
Winston Liu
45b772b111 Whoopsies 2019-05-25 16:50:37 -04:00
Winston Liu
7bbbca95bc atom.workspace should always exist 2019-05-25 15:44:49 -04:00
Winston Liu
7e2a23b797 Ah heck, more async 2019-05-25 15:42:27 -04:00
Winston Liu
8fcd97ae15 ...as I was saying, async. 2019-05-25 15:30:36 -04:00
Winston Liu
397c8d74e8 Pass in filePath as an argument 2019-05-25 14:24:10 -04:00
Winston Liu
e47253febf I think we need to pass in a folder 2019-05-25 13:31:40 -04:00
Winston Liu
81fe767077 Everything's a Promise, apparently 2019-05-25 12:49:36 -04:00
Winston Liu
4961b31cf7 Perhaps it's something with await? 2019-05-25 00:18:16 -04:00
Winston Liu
8728e9f1e1 Thanks documentation for not giving any hint whatsoever that it's async 2019-05-24 21:00:55 -04:00
Winston Liu
8870380a29 Looks like there are windows being returned... 2019-05-24 20:26:33 -04:00
Winston Liu
bb74186003 Scoping 2019-05-24 18:08:48 -04:00
Winston Liu
a2af8ec9ca Lint 2019-05-24 17:00:37 -04:00