Commit Graph

23105 Commits

Author SHA1 Message Date
Antonio Scandurra
319d54782a Reset shouldUpdate... variables 2015-04-29 09:08:11 +02:00
Antonio Scandurra
110e73da87 🎨 Use booleans to track batched functions 2015-04-29 09:08:11 +02:00
Antonio Scandurra
cb712fa9d3 🎨 Start refactoring batched operations 2015-04-29 09:07:45 +02:00
Nathan Sobo
192997c8cf Clear line numbers from previous usages of the gutter element
In adding custom gutter APIs, I suggested to @jssln that we associate
the gutter model objects with DOM nodes in the view registry to make
it easy for package authors to get at the view layer for a particular
gutter. She also applied this treatment to the line numbers gutter,
which makes sense.

However, using the view registry opened up an unexpected wrinkle…

When you detach an editor, we need to tear down all the associated view
logic because at that point, we don’t know whether the element is about
to be reattached or whether it’s going to get garbage collected. In the
case where we reattach, we end up constructing a new TextEditorComponent
for the element. When this happens, the gutter component requests a DOM
node for the gutter from the view registry. Except in this case the
DOM element isn’t empty because it was already used by a different
component for the same element before it was detached. The fix is simply
to always clear out the line numbers to ensure we start in a clean
state.

@jssln: You should apply this same fix to custom gutters or we’ll see
the same issues.
2015-04-28 20:05:25 -06:00
Nathan Sobo
d7045c3cc8 Make TextEditor params object optional 2015-04-28 20:05:24 -06:00
Kevin Sawicki
df2b0664a1 Catch errors setting load time 2015-04-28 17:43:16 -07:00
Kevin Sawicki
0d9d9e1056 Track load time when profiling startup 2015-04-28 17:42:46 -07:00
Kevin Sawicki
d9afa42550 ⬆️ deprecation-cop@0.43 2015-04-28 17:14:06 -07:00
Kevin Sawicki
9711e94133 ⬆️ grim@1.4 2015-04-28 17:13:54 -07:00
Kevin Sawicki
a115a03289 ⬆️ find-and-replace@0.161 2015-04-28 16:32:44 -07:00
Ben Ogle
8916674920 ⬆️ language-todo@0.19.0 2015-04-28 15:34:36 -07:00
Ben Ogle
3b542f0cbf ⬆️ language-html@0.34.0 2015-04-28 14:49:20 -07:00
Kevin Sawicki
7afa830e86 ⬆️ deprecation-cop@0.42 2015-04-28 13:48:30 -07:00
Kevin Sawicki
bd70637b5f ⬆️ archive-view@0.56 2015-04-28 13:30:58 -07:00
Kevin Sawicki
6169ba2845 ⬆️ keybinding-resolver@0.32 2015-04-28 13:13:03 -07:00
Kevin Sawicki
83b10d624b ⬆️ notifications@0.42 2015-04-28 12:53:29 -07:00
Kevin Sawicki
536421287c ⬆️ deprecation-cop@0.41 2015-04-28 09:56:48 -07:00
Kevin Sawicki
753a802386 ⬆️ grim@1.3 2015-04-28 09:52:40 -07:00
Kevin Sawicki
cc16c30dee Merge pull request #6543 from atom/ks-profile-startup-option
Add --profile-startup option
2015-04-28 09:17:56 -07:00
Kevin Sawicki
3fd5a680dc Merge pull request #6526 from atom/ld-bug-4880
🐛 Put a limit of 100 on max font size
2015-04-28 09:13:00 -07:00
Kevin Sawicki
313c8a73ce Only pen dev tools when not already open 2015-04-28 09:04:52 -07:00
Kevin Sawicki
b5839a8960 Add created to profile message 2015-04-28 09:04:52 -07:00
Kevin Sawicki
3cc99d5662 Handle profile startup option on load 2015-04-28 09:04:52 -07:00
Kevin Sawicki
9c7f9f74a1 Thread through profileStartup load setting 2015-04-28 09:04:52 -07:00
Kevin Sawicki
6b1c7f7a04 📝 Add missing the 2015-04-28 09:04:52 -07:00
Kevin Sawicki
0b150fc6a8 Add --profile-startup 2015-04-28 09:04:51 -07:00
Ivan Žužak
910cc5033c Merge pull request #6550 from atom/mq-upgrade-bracket-matcher
⬆️ bracket-matcher@0.74.0
2015-04-28 13:54:36 +02:00
Ivan Žužak
de7ea9ed9b Merge pull request #6522 from atom/iz-more-deprecation-fixes
Add new Grim.deprecate call for context menu CSON format so that it can be correctly attributed to packages
2015-04-28 13:42:51 +02:00
Antonio Scandurra
96471aa9fe Merge pull request #6546 from atom/as-travis-atom-access-token
Remove ATOM_ACCESS_TOKEN from build matrix
2015-04-28 12:19:44 +02:00
Machiste N. Quintana
324bc316f7 ⬆️ bracket-matcher@0.74.0 2015-04-28 06:11:20 -04:00
Antonio Scandurra
b9a3b0a8bc 🎨 2015-04-28 11:13:21 +02:00
Antonio Scandurra
d04f3e2f17 💚 Remove ATOM_ACCESS_TOKEN from build matrix 2015-04-28 08:59:22 +02:00
Ben Ogle
14b0e70a00 ⬆️ language-html@0.33.0 2015-04-27 18:11:55 -07:00
Machiste N. Quintana
a1594b1a79 Merge pull request #6527 from atom/mq-font-size
Add font size commands to View menu
2015-04-27 20:38:42 -04:00
Kevin Sawicki
201078828a ⬆️ fuzzy-finder@0.82 2015-04-27 16:27:05 -07:00
Daniel Hengeveld
7b1ec29bb1 Merge branch 'master' of https://github.com/github/atom 2015-04-27 15:58:01 -07:00
Daniel Hengeveld
da598b4c0a Add a scopeless access token to public Travis config.
It may seem strange to commit an access token to a public repository but this
one has been granted no scopes, so it doesn't have access to *do* anything, and
is simply used to avoid the GH API's unauthed rate limiting when fetching public
assets. This path was chosen on the advice of the GH platform team.
2015-04-27 15:55:34 -07:00
Nathan Sobo
a50f572eec ⬆️ git-diff 2015-04-27 16:55:30 -06:00
Kevin Sawicki
3cd33f6972 ⬆️ dev-live-reload@0.46 2015-04-27 15:15:56 -07:00
Kevin Sawicki
e8bd0dc710 ⬆️ apm@0.163 2015-04-27 15:10:36 -07:00
Machiste N. Quintana
d586b57fef &R -> &s 2015-04-27 13:21:09 -04:00
Machiste N. Quintana
67e7acebbd &R -> &s 2015-04-27 13:20:39 -04:00
Ivan Žužak
3c2acdcf9a ⬆️ tabs@0.68.0 2015-04-27 18:57:33 +02:00
Ivan Žužak
608f5fa656 ⬆️ language-gfm@0.70.0 2015-04-27 17:47:15 +02:00
Machiste Quintana
415898d597 Add font size commands to View menu 2015-04-26 23:52:48 -04:00
Lee Dohm
21ad8f9807 🐛 Put a limit of 100 on max font size
This will prevent Atom from crashing, but still allow folks who need large
font sizes for visual impairments to have them.

Fix #4880
2015-04-26 19:08:19 -07:00
Ivan Zuzak
46ab8e7f63 Link to section in API docs for ContextMenuManager::add 2015-04-26 11:23:13 +02:00
Ivan Zuzak
cfdf5f1bcc Move Grim.deprecate call so that it can be correctly attributed 2015-04-26 11:22:07 +02:00
Ivan Žužak
14161a63fe ⬆️ one-light-ui@0.6.0 2015-04-26 09:21:09 +02:00
Ivan Žužak
bf3707feab ⬆️ one-light-syntax@0.5.0 2015-04-26 09:19:39 +02:00