Commit Graph

15931 Commits

Author SHA1 Message Date
Corey Johnson
35a7bb115d Fix context-menu specs 2014-06-03 10:44:45 -07:00
Kevin Sawicki
553abc2009 Merge pull request #2492 from p-e-w/linux-dev-tools-keybinding
🐧 Make "Developer Tools" key binding match Chrome
2014-06-03 10:37:43 -07:00
Philipp Emanuel Weidmann
0ad1aeea43 🐧 Make "Developer Tools" key binding match Chrome 2014-06-03 19:31:32 +02:00
Corey Johnson
7e52c86095 📝 Update context menu doc 2014-06-03 10:25:12 -07:00
Corey Johnson
950338ed22 Fix linter errors 2014-06-03 10:17:53 -07:00
Corey Johnson
8ed3b7a250 Merge pull request #2134 from erikhakansson/AdvancedContextMenu
Advanced context menu
2014-06-03 10:13:37 -07:00
Ivan Žužak
390c36ca15 Upgrade to tree-view@0.96.0 2014-06-03 18:56:28 +02:00
Ivan Žužak
1df2e50bbf Upgrade to settings-view@0.118.0 2014-06-03 15:30:19 +02:00
Nathan Sobo
749dba1ac7 Prevent LinesComponent from updating on simple cursor movement 2014-06-03 19:23:19 +09:00
Nathan Sobo
a28566a559 Add ScrollbarCornerComponent::shouldComponentUpdate 2014-06-03 19:18:14 +09:00
Nathan Sobo
64f1c8b80e Merge pull request #2481 from atom/ns-react-clean-up-measurement
Fix cursor and selection positioning when changing line height, font size, and font family
2014-06-03 19:15:40 +09:00
Nathan Sobo
b47f6265c7 Move gutter width measurement into EditorComponent 2014-06-03 18:30:24 +09:00
Nathan Sobo
9511c952af 💄 2014-06-03 18:19:11 +09:00
Nathan Sobo
be0877327e Kill comment 2014-06-03 18:18:53 +09:00
Nathan Sobo
3134bfda95 Update selections when the font size or font family change 2014-06-03 17:43:57 +09:00
Nathan Sobo
1c177aa206 Add spec for cursor position updates when the font family changes 2014-06-03 17:43:57 +09:00
Nathan Sobo
ec65def5d3 Add spec for cursor position updates when the font size changes 2014-06-03 17:43:57 +09:00
Nathan Sobo
3aefa53b33 Batch together line and character width measurement after font changes
This ensures we only perform a single update with the most up-to-date
information about line height, default character width, and specific
character widths. If this update causes more lines to be drawn we may
measure again, but not necessarily.
2014-06-03 17:43:56 +09:00
Nathan Sobo
4fd07a4cf3 Subscribe to scroll view DOM events in ::listenForDOMEvents 2014-06-03 17:43:56 +09:00
Nathan Sobo
03463da729 Allow Editor::batchUpdates calls to be nested 2014-06-03 17:43:56 +09:00
Nathan Sobo
1cc5ef3479 Update selections when the line height changes 2014-06-03 17:43:56 +09:00
Nathan Sobo
77f78d0a11 Update cursors component if the defaultCharWidth changes 2014-06-03 17:43:56 +09:00
Nathan Sobo
8f98f2368b Base gutter updates on defaultCharWidth instead of fontSize/Family 2014-06-03 17:43:56 +09:00
Nathan Sobo
f467e3eed4 Move decision to measure lineHeight/charWidths to EditorComponent
This prevents the double-update of the lines component when changing
the font-size, line-height and font-family. We detect the update of
these values in the root component and trigger a measurement. If the
measurement determines that the pixel values have changed, *then* we
update the lines.
2014-06-03 17:43:56 +09:00
Nathan Sobo
3052fe3f3b Update cursors when the line height in pixels changes 2014-06-03 17:43:56 +09:00
Nathan Sobo
1bce626324 Compute ranges of cursors & selections in EditorComponent and pass down
Previously, SelectionsComponenet::shouldComponentUpdate was storing the
ranges for selections as a side effect. We also were passing boolean
values (cursorMoved and selectionUpdated) to determine if these
components should update.

Now, we compute a simple hash of screen ranges for selections and
cursors in the root component and pass them down. This simplifies
shouldComponentUpdate for selections and allows us to implement one
for cursors.
2014-06-03 17:43:55 +09:00
Nathan Sobo
e222998f82 Only compare screenRow to mouseWheelScreen row when it is defined
Fixes #2482
2014-06-03 17:43:35 +09:00
Kevin Sawicki
2aca16dc6b Upgrade to language-hyperlink@0.10 2014-06-02 21:38:26 -07:00
Kevin Sawicki
653a2623bf 🏁 bind ctrl-alt-up-down to adding selections 2014-06-02 15:59:13 -07:00
Kevin Sawicki
03ce9e0ec8 Upgrade to symbols-view@0.55 2014-06-02 15:58:56 -07:00
Kevin Sawicki
0245ec28eb Always handle resolving absolute URIs 2014-06-02 15:45:47 -07:00
Kevin Sawicki
94f86cb461 Don't resolve uris when project has not path 2014-06-02 15:41:05 -07:00
Kevin Sawicki
b4871fddfb Upgrade to release-notes@0.32 2014-06-02 14:21:54 -07:00
Kevin Sawicki
a598dcc259 🏁 Match Chrome's Settings menu item 2014-06-02 13:51:38 -07:00
Kevin Sawicki
918c86476c Check for href attribute on currentTarget
This makes clicking on images wrapped in anchor tags open correctly.
2014-06-02 13:35:18 -07:00
Kevin Sawicki
4d65a220e2 Add support for a ATOM_DEV_RESOURCE_PATH env var
This is helpful on windows to set a default dev resource path that
isn't ~/github/atom since on Windows it is common to clone Atom to C:\atom
2014-06-02 12:38:33 -07:00
Ben Ogle
7697f19c3d Merge pull request #2474 from atom/bo-add-shift-keymaps
Add missing shift-backspace and shift-delete bindings
2014-06-02 10:58:02 -07:00
Kevin Sawicki
6ad6409efe Merge pull request #2462 from atom/ks-windows-spec-fixes
Get core specs green on Windows
2014-06-02 10:25:09 -07:00
Kevin Sawicki
b6fcc35131 Write removed file to temp directory 2014-06-02 10:17:13 -07:00
Kevin Sawicki
bd873dc851 Upgrade to first-mate@1.6.1 2014-06-02 10:17:13 -07:00
Kevin Sawicki
4c2931f6b5 Use forward slash on all platforms
Paths are normalized by git-utils to use / on all platforms
2014-06-02 10:17:13 -07:00
Kevin Sawicki
1704c78eea Enable core specs when run outside of clone repo
The failing specs have been updated so that specs
can now run without the requirement of a Git repository
at the root.
2014-06-02 10:17:13 -07:00
Kevin Sawicki
bcad8c1b3e Remove # which is interpreted as a tag
This spec was not running because of it since
jasmine-tagged is configured to filter tags by
process.platform
2014-06-02 10:17:13 -07:00
Kevin Sawicki
81d9193bf4 Copy repository to temp folder 2014-06-02 10:17:13 -07:00
Kevin Sawicki
7514f70434 Set project path to temp working directory 2014-06-02 10:17:13 -07:00
Kevin Sawicki
12a8688a9b Copy repository in remaining specs 2014-06-02 10:17:13 -07:00
Kevin Sawicki
0524a724e1 Move fixtures into repo 2014-06-02 10:17:13 -07:00
Kevin Sawicki
805c7ae301 💄 2014-06-02 10:17:13 -07:00
Kevin Sawicki
3f3dabed41 Remove spec completely tested in git-utils library 2014-06-02 10:17:13 -07:00
Kevin Sawicki
516035a82c Add copyRepository helper 2014-06-02 10:17:12 -07:00