Max Brunsfeld
369f3d2648
Don't use atom.{notifications,config,deserializers,confirm} in Pane
...
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Max Brunsfeld
b467c83e76
Remove unused requires in spec-helper
2015-10-09 13:46:51 -07:00
Max Brunsfeld
778023c78b
Make factory for StylesElements on atom.styles
2015-10-09 13:46:32 -07:00
Antonio Scandurra
1a8beef74f
🐛 Load config schema before loading base stylesheets
2015-10-09 19:10:55 +02:00
Antonio Scandurra
4ce814320d
Call side effects methods after instantiating instance variables
...
This prevents a 🐛 where the `onDidLoadBundledKeymaps` was fired before
`MenuManager` had the chance to listen to it thereby not showing the appropriate
menu entries.
2015-10-09 17:41:33 +02:00
Antonio Scandurra
60e4b78da3
Move package reset down into PackageManager
2015-10-09 10:04:04 +02:00
Antonio Scandurra
4863b71fd7
Set timeout in the main process
2015-10-09 09:20:19 +02:00
Max Brunsfeld
43d0241685
Reset project in AtomEnvironment::reset
2015-10-08 17:54:43 -07:00
Max Brunsfeld
7617c35856
Rename AtomEnvironment::removeEditorWindow -> ::destroy
2015-10-08 17:51:27 -07:00
Max Brunsfeld
5c545c0898
Don't register CommandRegistry's window listeners in AtomEnvironment constructor
2015-10-08 17:34:41 -07:00
Max Brunsfeld
04c85e3aae
Avoid using atom global in registerDefaultCommands
2015-10-08 17:21:55 -07:00
Max Brunsfeld
4835fef7be
Reset service-hub in AtomEnvironment::reset()
2015-10-08 16:29:54 -07:00
Max Brunsfeld
a9c8640ab1
Stop using directory providers when their providing packages are deactivated
2015-10-08 15:20:13 -07:00
Max Brunsfeld
b754f1e125
Clean up project specs for custom directory and repository providers
2015-10-08 15:15:02 -07:00
Max Brunsfeld
2af6f995b4
Clean up repository-providers when their providing packages are are deactivated
2015-10-08 13:49:37 -07:00
Max Brunsfeld
c268b4e050
Remove unused stylesheet cleanup in spec-helper
2015-10-08 13:11:58 -07:00
Max Brunsfeld
fb2a1284f6
Clear notifications and context menus in AtomEnvironment::reset
2015-10-08 12:41:07 -07:00
Max Brunsfeld
9a4cbb9e16
Wait for async service consumption in project spec
2015-10-08 12:40:23 -07:00
Max Brunsfeld
d0283d8f05
Reset Clipboard in AtomEnvironment::reset
2015-10-08 11:56:12 -07:00
Max Brunsfeld
9664d34750
Reset MenuManager in AtomEnvironment::reset
2015-10-08 11:56:12 -07:00
Max Brunsfeld
19b07dbd97
Rename atom-spec -> atom-environment-spec
2015-10-08 11:54:54 -07:00
Antonio Scandurra
fa41cf68a4
🐛 Fix ::registerDefaultOpeners
2015-10-08 15:49:01 +02:00
Antonio Scandurra
24365b95df
💄 Satisfy linter requirements
2015-10-08 14:13:49 +02:00
Antonio Scandurra
9ac4034135
🔥 Drop --spec-directory
2015-10-08 14:04:23 +02:00
Antonio Scandurra
5da32540b1
🎨
2015-10-08 11:54:11 +02:00
Antonio Scandurra
1d280e8d92
Introduce timeout option
...
The idea with this commit is to implement a timeout functionality that does not
rely on a system utility (such as unix `timeout`). Tests could hang because of a
CPU-bound task and, as a result, we need to handle timeouts in a separate
process.
An ideal implementation would first spawn the timeout, which in turn would spawn
the tests, acting as a supervisor and making sure they do not exceed the
supplied time. However, setting up such an environment would have been trickier,
thus the test process spawns the timeout cop before running any test. This, in
turn, invokes a `setTimeout` function and kills the parent process as soon as
the timeout gets triggered, logging to console the reason why the parent process
was killed (and exiting the parent process with code 130).
I haven't used `Task` because, in order to log stuff to the console, we need to
fork the ChildProcess from `remote`, as otherwise nothing gets written out.
2015-10-08 11:38:48 +02:00
Nathan Sobo
4746153cc5
Merge branch 'master' into ns-alternative-test-env
2015-10-07 16:53:39 -05:00
Nathan Sobo
8e834794a9
Remove scroll listener on destroy so we don’t call undefined onScroll
...
/cc @izuzak because no PR, @as-cii because this fixes an unexpected
issue with your change.
2015-10-07 16:52:37 -05:00
Nathan Sobo
4808c9f9e8
Eliminate config and confirm global references in Pane
2015-10-07 16:32:47 -05:00
Nathan Sobo
4c51d29868
Merge remote-tracking branch 'origin/master' into ns-alternative-test-env
2015-10-07 16:10:29 -05:00
Nathan Sobo
3636eb35d8
Merge pull request #8811 from atom/as-double-reflow-measurements
...
DOM-based measurements
2015-10-07 15:43:59 -05:00
Nathan Sobo
993419f0c5
Merge pull request #9067 from atom/as-memory-leaks
...
Avoid leaking DOM objects
2015-10-07 15:32:17 -05:00
Nathan Sobo
ca0dda77b6
Don’t bind window:close in spec helper
2015-10-07 15:25:07 -05:00
Nathan Sobo
0f4558c448
Don’t load key bindings in spec helper
2015-10-07 15:25:06 -05:00
Nathan Sobo
499272dfa1
Remove unused locals in spec-helper
2015-10-07 15:25:06 -05:00
Nathan Sobo
a9a6f38858
Don’t clear document requests in spec helper; happens in reset
2015-10-07 15:25:06 -05:00
Nathan Sobo
aa682d5b19
Restore initial styles in AtomEnvironment::reset
2015-10-07 15:25:06 -05:00
Nathan Sobo
dc7a4a8168
Increase wait time in spec
...
This kinda sucks, but it’s not the end of the world.
2015-10-07 15:25:06 -05:00
Antonio Scandurra
c3d85f85a4
🔥 Remove unused LOC
2015-10-07 15:25:06 -05:00
Antonio Scandurra
52c43a71d3
Pass legacyTestRunner parameter
2015-10-07 15:25:06 -05:00
Max Brunsfeld
13301b551c
📝 Document Workspace::buildTextEditor
2015-10-07 15:25:06 -05:00
Thomas Johansen
d878092794
🎨 Replace unnecessary fat arrow
2015-10-07 15:25:06 -05:00
Thomas Johansen
669eff5d20
🔥 Remove duplicate keys
2015-10-07 15:25:06 -05:00
Thomas Johansen
a28a42b610
🔥 Remove duplicate key
2015-10-07 15:25:05 -05:00
Max Brunsfeld
5aee514ef5
🔥 debuggers
2015-10-07 15:25:05 -05:00
Max Brunsfeld
4988f6be11
Remove application:run-all-specs command
2015-10-07 15:25:05 -05:00
Max Brunsfeld
9924288a6f
Use atom environment argument to deserialize in Pane, PaneAxis
2015-10-07 15:25:05 -05:00
Antonio Scandurra
a3a6db7f68
Don't use atom.{config,confirm} global in GitRepository
2015-10-07 15:25:05 -05:00
Antonio Scandurra
ff86eb6a59
Don't use atom.config global in ScopedProperties
2015-10-07 15:25:05 -05:00
Antonio Scandurra
b5fc710f15
Don't use atom.clipboard global in Selection
2015-10-07 15:25:05 -05:00