Nathan Sobo
36d5359ef4
Restore original context menu ordering
...
Previously I used CSS specificity to order the most specific / recently
added menu items for a given element *first* when building up the
context menu. When a duplicate label was found for a given menu I would
refrain from inserting it. Now instead I order things the opposite way.
The most specific / recently added items come later and items with the
same label are clobbered by later items.
2014-09-30 12:06:26 -06:00
Nathan Sobo
915cfe15f5
Clear context menus between specs
2014-09-30 12:06:26 -06:00
Nathan Sobo
f082f93ead
Update specs for new ContextMenuManager API/behavior
...
When selectors have the same specificity, menu items added *later*
appear higher in the list.
2014-09-30 12:06:26 -06:00
Nathan Sobo
f9bf42db64
Remove commented line
2014-09-30 12:06:26 -06:00
Nathan Sobo
ff76e36f7d
Only display ‘Inspect Element’ item in dev mode
2014-09-30 12:06:26 -06:00
Nathan Sobo
740778e129
Auto-detect context menu items in the old format
2014-09-30 12:06:26 -06:00
Nathan Sobo
483e746439
Use new format for platform menus
2014-09-30 12:06:26 -06:00
Nathan Sobo
aec6df828e
fixup! Call context menu item ::created hooks with the click event
2014-09-30 12:06:09 -06:00
Nathan Sobo
703197bcca
Deprecate old style calls to ContextMenuManager::add
2014-09-30 12:06:09 -06:00
Nathan Sobo
2142c8e63e
:public: Document new ContextMenuManager::add API
2014-09-30 12:06:09 -06:00
Nathan Sobo
782f9c609e
Add shouldDisplay hook for context menu items
...
If present, if a falsy value is returned from this function for a given
context menu invocation, the item will not be displayed.
2014-09-30 12:06:09 -06:00
Nathan Sobo
3a567b3c5b
Call context menu item ::created hooks with the click event
2014-09-30 12:06:08 -06:00
Nathan Sobo
c5b395579b
Add devMode flag to individual items
2014-09-30 12:06:08 -06:00
Nathan Sobo
f8225a6441
Make arguments atom.contextMenu.add consistent with atom.menu.add
2014-09-30 12:06:08 -06:00
Nathan Sobo
504c4c7af6
Extract MenuHelpers from MenuManager for reuse by ContextMenuManager
2014-09-30 12:06:08 -06:00
Nathan Sobo
5e6e3c8d72
Merge pull request #3655 from atom/ns-menu-disposables
...
Return disposables from MenuManager::add and add specs
2014-09-30 12:05:11 -06:00
Nathan Sobo
dfc502b9a0
Merge pull request #3663 from atom/bo-subscribe-editor-commands
...
Subscribe to commands in TextEditorComponent so they are unsubscribed!
2014-09-30 10:56:05 -06:00
Ben Ogle
a8d93f9cf4
Spec for unsubscribing from commands
2014-09-30 09:45:55 -07:00
Ben Ogle
50cf5f3e95
Subscribe to editor commands
...
We need to unsubscribe when the editor is removed!
Closes #3651
2014-09-30 09:33:50 -07:00
Kevin Sawicki
5a9b34b31a
! -> ~
2014-09-30 09:32:03 -07:00
Kevin Sawicki
3efaeff669
🍎 Install via move instead of copy
...
This fixes the issue with the icon not showing up on OS X Mavericks
when building.
It seems that copying it to /Application file by file causes the icon to not
show up while moving it atomically there does.
2014-09-30 09:15:55 -07:00
Ben Ogle
443df29236
Upgrade find and replace to have cmd-d undo and skip
2014-09-29 17:26:51 -07:00
Ben Ogle
05b3f16eb2
Merge pull request #3613 from atom/bo-config-types
...
Support JSON Schema in Config
2014-09-29 17:23:54 -07:00
Ben Ogle
b54deccfae
String type must be strict.
...
It makes sense to coerce from more general -> more specific data types.
eg. string -> int, etc. But coercing the other way is problematic
in the case of chaining because the more general type will swallow the
specific type. eg. Setting `false` on type: [‘string’, ‘boolean’] will
coerce the boolean to a string, and will never allow the value to be
a boolean.
2014-09-29 16:09:49 -07:00
Ben Ogle
9808264b7f
Fix onDidChange usage
2014-09-29 16:09:49 -07:00
Ben Ogle
f3ed3dc357
Fix doc to match implementation
2014-09-29 16:09:49 -07:00
Ben Ogle
33b25c7312
Use new config callback arguments
2014-09-29 16:09:49 -07:00
Ben Ogle
454f9c4c65
Rename config-defaults -> config-schema
2014-09-29 16:09:49 -07:00
Ben Ogle
1b506673bb
📝 update
2014-09-29 16:09:49 -07:00
Ben Ogle
5651ebbb48
always set, only emit when values differ
2014-09-29 16:09:49 -07:00
Ben Ogle
a7185a894f
Fix specs
2014-09-29 16:09:49 -07:00
Ben Ogle
16c7fd3d70
Add spec for update event on load
2014-09-29 16:09:49 -07:00
Ben Ogle
98290b31ab
Rework defaults and user loading to notify per path
2014-09-29 16:09:48 -07:00
Ben Ogle
08b138997d
Change the onDidChange / observe arguments
...
Support passing no keypath
2014-09-29 16:09:48 -07:00
Ben Ogle
1f7aee00ac
function names to the imperative mood
...
http://en.wikipedia.org/wiki/Imperative_mood
2014-09-29 16:09:48 -07:00
Ben Ogle
3977596084
Validators -> enforcers
2014-09-29 16:09:48 -07:00
Ben Ogle
804d0d9911
Doc 💄
2014-09-29 16:09:48 -07:00
Ben Ogle
04d045227a
rename to config-defaults
2014-09-29 16:09:48 -07:00
Ben Ogle
4e1d13ceea
is plain object
2014-09-29 16:09:48 -07:00
Ben Ogle
ef19e925e9
Strings accept numbers too
2014-09-29 16:09:48 -07:00
Ben Ogle
2c1fa19e27
Update spec strings
2014-09-29 16:09:48 -07:00
Ben Ogle
11fad1bd12
Moar 📝
2014-09-29 16:09:48 -07:00
Ben Ogle
1408d69641
Fix up message strings
2014-09-29 16:09:48 -07:00
Ben Ogle
38d2303857
Clean up docs in creating a package
2014-09-29 16:09:48 -07:00
Ben Ogle
96207ffbdb
Update error messages to read good
2014-09-29 16:09:47 -07:00
Ben Ogle
fcf2143e70
isPlainObject
2014-09-29 16:09:47 -07:00
Ben Ogle
3a8f842de3
Remove uses of toggle
2014-09-29 16:09:47 -07:00
Ben Ogle
452e34db90
Remove deprecations for push / remove / unshift at keypath
2014-09-29 16:09:47 -07:00
Ben Ogle
8b39ce77b1
We’ll always have validators for a type. No check
2014-09-29 16:09:47 -07:00
Ben Ogle
604158647a
line height can be a string or a number
2014-09-29 16:09:47 -07:00
