Christopher Chedeau
c8a398e6e9
Fix prepending multiple gutters at once
...
There's a bug when multiple gutters are prepended at once where their order is not correctly preserved in the dom. The issue is that we do not update indexInOldGutters even though we inserted a dom node in the old gutters dom.
Honestly, I'm unconvinced that this entire logic is correct, but this fixes the use case we have in Nuclide so it's more correct than before :)
Released under CC0
2016-11-19 12:22:59 -08:00
Indrek Ardel
55f3311c01
Remove unused variables
2016-09-26 20:52:13 +03:00
Antonio Scandurra
6fed847cce
Don't use atom globals in gutter components
2015-10-07 15:25:02 -05:00
Antonio Scandurra
f86c9b2331
Let TextEditorComponent manage DOMElementPool
2015-09-15 10:58:24 +02:00
Antonio Scandurra
d6ac7863c9
Merge branch 'master' into as-tiled-gutter
2015-06-19 20:12:43 +02:00
Antonio Scandurra
d7156ff387
Remove event listeners from orphaned gutters
2015-06-19 10:24:48 +02:00
Antonio Scandurra
e893b5105b
Remove presenter as a dependency where possible
...
Although we have a couple of components which still access it, we
agreed it would have been just better to avoid relying on
`TextEditorPresenter` where possible and use it purposefully in other
places (e.g. `LinesComponent` which needs it to store text
measurements).
/cc: @jssln
2015-06-13 14:18:36 +02:00
Antonio Scandurra
7ac0cdcbf5
Start porting TextEditorComponent spec
2015-06-12 18:22:33 +02:00
Jess Lin
957424f987
[Gutter] @state.gutter.sortedDescriptions -> @state.gutters
2015-05-13 11:15:44 -07:00
Jess Lin
c128788a3b
[Gutter] Migrate CustomGutterComponent to consume new state format
2015-05-13 11:15:44 -07:00
Jess Lin
0a7f6ae187
[Gutter] Migrate LineNumberGutterComponent to consume new state format
2015-05-13 10:59:31 -07:00
Jess Lin
cdca9c3ef1
[Gutter] Fix coffeescript style issues
2015-04-22 07:29:00 -07:00
Jess Lin
9abd0232ce
[Gutter] Remove ::getName from gutter components; save names in GutterContainerComponent
2015-04-22 07:29:00 -07:00
Jess Lin
6f66d2fd5d
[Gutter] Convert GutterContainerComponent::updateChildGutters -> ::reorderGutters
2015-04-22 07:28:59 -07:00
Jess Lin
09d1b977de
[Gutter] Convert ! to 'not', && to 'and'
2015-04-22 07:28:59 -07:00
Jess Lin
34856d94f5
[Gutter][DOM Persistence] Keep a gutter in the DOM if it is merely hidden (not destroyed)
2015-04-22 07:28:58 -07:00
Jess Lin
66f1f33861
[Gutter][View Registry] Make LineNumber- and Custom- GutterComponent get their view from the ViewRegistry
2015-04-22 07:28:58 -07:00
Jess Lin
f3d2597bda
[Gutter][View Registry] Make the Presenter pass sorted Gutter models instead of sorted derived state
2015-04-22 07:28:58 -07:00
Jess Lin
d2914bc73c
[Gutter] Make the GutterContainerComponent able to create custom gutters
2015-04-22 07:28:58 -07:00
Jess Lin
ce1d64f550
[Gutter] Create GutterContainerComponent
2015-04-22 07:28:57 -07:00
