Nathan Sobo
442e89e77e
💄 – rename render/updateLines to render/updateVisibleLines
2012-05-16 14:03:26 -06:00
Nathan Sobo
2d8ba3b1ee
Use translate3d to scroll lines / gutter in attempt to improve repaint.
...
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Nathan Sobo
66b711a026
Kill logging
2012-05-16 13:46:36 -06:00
Corey Johnson
27f3d3d03d
Use scrollView in benchmarks
2012-05-15 17:39:44 -07:00
Corey Johnson
e691f1e73a
Errors thrown when running benchmarks are logged to the console
2012-05-15 17:39:23 -07:00
Corey Johnson
aed346cfcf
Fail if the benchmarks fail
2012-05-15 17:00:54 -07:00
Corey Johnson
d9dbca122f
Force benchmark ajax call to be synchronous
2012-05-15 16:59:06 -07:00
Corey Johnson
cae7c18db4
Don't trigger scroll event on edit session load, it is called automatically
...
Fixes partially rendered lines when you reload
2012-05-15 15:28:10 -07:00
Corey Johnson
aacd077749
Editor.renderLines() calls updateLines (more DRY)
2012-05-15 14:47:59 -07:00
Corey Johnson
484b55800a
Call updateLines when lines are removed from buffer
2012-05-15 14:27:22 -07:00
Corey Johnson
91aebde968
Only update gutter when editor is attached
2012-05-15 12:32:46 -07:00
Corey Johnson
54a3823606
Buffer change events update the @lastRenderedScreenRow
2012-05-15 12:29:59 -07:00
Corey Johnson
63d53af577
💩
2012-05-15 10:46:58 -07:00
Corey Johnson
8cbd81b7ac
don't fail build if benchmark fails
2012-05-15 10:22:47 -07:00
Corey Johnson
6515cada2d
check to see if the build passes without the 9000-line-file.after-opening.move-to-beginning-of-word benchmark
2012-05-15 10:16:12 -07:00
Corey Johnson
80c066b03b
The test for tabs in a token was totally wrong. Now it is totally right.
2012-05-15 10:12:56 -07:00
Corey Johnson
6b3664a040
Vertical scrollbar height is updated when switching buffers
2012-05-15 10:02:56 -07:00
Corey Johnson
facd7082d0
optimization: only tokens containing tabs are split into multiple tokens
2012-05-15 08:39:50 -07:00
Corey Johnson & Nathan Sobo
171e4cc2a5
Use LOAD_RESOURCES_FROM_DIR macro to indicate that resources should be loaded from a path rather than the bundle
2012-05-14 17:43:55 -06:00
Corey Johnson & Nathan Sobo
78155de740
Un-F
2012-05-14 16:55:35 -06:00
Corey Johnson & Nathan Sobo
abc230eee3
Fix bug: file finder correctly focuses editor after opening a file.
2012-05-14 16:35:03 -06:00
Corey Johnson & Nathan Sobo
9079bcb103
Meta-a selects everything
2012-05-14 16:18:37 -06:00
Corey Johnson & Nathan Sobo
13553f79bc
Benchmark movement of cursor that scrolls the editor's scroll view
2012-05-14 15:44:23 -06:00
Corey Johnson & Nathan Sobo
550bd0a979
Run more trials in benchmark that opens a 9k line file
2012-05-14 15:43:53 -06:00
Corey Johnson & Nathan Sobo
e8838b95fc
Don't load user configuration for benchmark, since it changes the performance curve
2012-05-14 15:43:26 -06:00
Corey Johnson & Nathan Sobo
513e15e369
Make editor tall so that all line numbers are rendered for this test
2012-05-14 15:42:51 -06:00
Corey Johnson & Nathan Sobo
d99a12b6cf
Don't defer scroll after cursor changes position to make scrolling feel smoother
2012-05-14 15:42:31 -06:00
Corey Johnson
b35a2502c6
Gutter line numbers are rendered similarly to the scroll view's lines
2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0
Only visible lines numbers are rendered by the gutter
2012-05-14 09:53:58 -07:00
Corey Johnson
95440cc9dc
bufferRowsForScreenRows method on editor and renderer take start/end arguments
2012-05-14 09:53:58 -07:00
Corey Johnson
63e9af6109
LineMap.bufferRowsForScreenRows stops traversing line map when endScreenRow is exceeded
2012-05-14 09:53:58 -07:00
Nathan Sobo
73c51583e6
Add benchmark for inserting newline in big file
2012-05-11 18:44:15 -06:00
Nathan Sobo
f47abdead9
Merge branch 'render-visible'
2012-05-11 17:52:23 -06:00
Nathan Sobo
21438acc48
Merge branch 'render-visible' of github.com:github/atom into render-visible
2012-05-11 17:51:59 -06:00
Nathan Sobo
0c89db37a5
Editor scroll position is correctly restored on refresh.
...
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
Corey Johnson & Nathan Sobo
af65bd785c
fix test failures
2012-05-11 16:06:42 -07:00
Corey Johnson & Nathan Sobo
d51b229d56
When the editor buffer changes and the path is not visible in the TreeView, It selects the closes ancestor entry of that file.
2012-05-11 15:44:18 -07:00
Corey Johnson & Nathan Sobo
2f86a3a6e5
TreeView starts with root being selected
2012-05-11 14:31:48 -07:00
Corey Johnson & Nathan Sobo
9990fd7b98
Do not let xcode compile coffeescript in when PROJECT_DIR exists
2012-05-11 13:12:43 -07:00
Nathan Sobo
96d92be230
Rename Editor.scrollbar to verticalScrollbar for clarity
2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f
Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
...
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
38582a22d3
These tests shall pass
2012-05-11 11:25:27 -07:00
Corey Johnson & Nathan Sobo
c93c63d721
Editor.scroller WheelEvents are forwarded to Editor.scrollbar
2012-05-11 11:04:04 -07:00
Corey Johnson & Nathan Sobo
9427c82084
WIP: Getting specs passing with new stand-in vertical scrollbar
2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
e433e08c78
Revert "WIP: Don't actually scroll the lines… just play with their margin to make them look like they scroll"
...
This reverts commit b3206a5a8b
2012-05-10 18:05:25 -06:00
Corey Johnson & Nathan Sobo
1a6ef9d7e2
Revert "Temporarily disable gutter. Add transition affect to margin-top."
...
This reverts commit 811e5264cf
2012-05-10 18:00:58 -06:00
Corey Johnson & Nathan Sobo
811e5264cf
Temporarily disable gutter. Add transition affect to margin-top.
2012-05-10 17:52:41 -06:00
Corey Johnson & Nathan Sobo
b3206a5a8b
WIP: Don't actually scroll the lines… just play with their margin to make them look like they scroll
2012-05-10 17:30:06 -06:00
Corey Johnson & Nathan Sobo
f0d4999fa4
Nix console.log on scroll.
2012-05-10 17:13:00 -06:00
Corey Johnson & Nathan Sobo
502b463a72
WIP: Adding an artificial scrollbar so we can render content before we scroll. It's blue.
2012-05-10 16:59:46 -06:00
