Kevin Sawicki
a13c49d679
Merge pull request #6570 from jssln/gutter
...
[Gutter] Clear custom gutter decorations from previous usages of a custo...
2015-04-29 14:26:28 -07:00
Kevin Sawicki
c95d6b2c60
Catch wmic spawn errors
2015-04-29 09:20:22 -07:00
Kevin Sawicki
63bfee1096
Use the command ivar
2015-04-29 09:20:21 -07:00
Kevin Sawicki
a9806d63eb
Check for process from within handleEvents
2015-04-29 09:20:21 -07:00
Kevin Sawicki
78d2c868f7
Assign process ivar from within spawn
2015-04-29 09:20:21 -07:00
Kevin Sawicki
96f0916ddd
Add missing l
2015-04-29 09:20:21 -07:00
Kevin Sawicki
920def7eb0
Add spec for thrown spawn error
2015-04-29 09:20:21 -07:00
Kevin Sawicki
fd84c5ff04
Extract handle events helper
2015-04-29 09:20:21 -07:00
Kevin Sawicki
99e40a788b
Handle errors thrown by child_process.spawn
2015-04-29 09:20:21 -07:00
Kevin Sawicki
a67d9615a8
Extract error handling helper
2015-04-29 09:20:21 -07:00
Kevin Sawicki
213e6fd611
Check process before killing
2015-04-29 09:20:21 -07:00
Jess Lin
5e766b6eee
[Gutter] Clear custom gutter decorations from previous usages of a custom gutter element
2015-04-29 08:53:04 -07:00
Nathan Sobo
192997c8cf
Clear line numbers from previous usages of the gutter element
...
In adding custom gutter APIs, I suggested to @jssln that we associate
the gutter model objects with DOM nodes in the view registry to make
it easy for package authors to get at the view layer for a particular
gutter. She also applied this treatment to the line numbers gutter,
which makes sense.
However, using the view registry opened up an unexpected wrinkle…
When you detach an editor, we need to tear down all the associated view
logic because at that point, we don’t know whether the element is about
to be reattached or whether it’s going to get garbage collected. In the
case where we reattach, we end up constructing a new TextEditorComponent
for the element. When this happens, the gutter component requests a DOM
node for the gutter from the view registry. Except in this case the
DOM element isn’t empty because it was already used by a different
component for the same element before it was detached. The fix is simply
to always clear out the line numbers to ensure we start in a clean
state.
@jssln: You should apply this same fix to custom gutters or we’ll see
the same issues.
2015-04-28 20:05:25 -06:00
Nathan Sobo
d7045c3cc8
Make TextEditor params object optional
2015-04-28 20:05:24 -06:00
Kevin Sawicki
cc16c30dee
Merge pull request #6543 from atom/ks-profile-startup-option
...
Add --profile-startup option
2015-04-28 09:17:56 -07:00
Kevin Sawicki
3fd5a680dc
Merge pull request #6526 from atom/ld-bug-4880
...
🐛 Put a limit of 100 on max font size
2015-04-28 09:13:00 -07:00
Kevin Sawicki
9c7f9f74a1
Thread through profileStartup load setting
2015-04-28 09:04:52 -07:00
Kevin Sawicki
6b1c7f7a04
📝 Add missing the
2015-04-28 09:04:52 -07:00
Kevin Sawicki
0b150fc6a8
Add --profile-startup
2015-04-28 09:04:51 -07:00
Lee Dohm
21ad8f9807
🐛 Put a limit of 100 on max font size
...
This will prevent Atom from crashing, but still allow folks who need large
font sizes for visual impairments to have them.
Fix #4880
2015-04-26 19:08:19 -07:00
Ivan Zuzak
46ab8e7f63
Link to section in API docs for ContextMenuManager::add
2015-04-26 11:23:13 +02:00
Ivan Zuzak
cfdf5f1bcc
Move Grim.deprecate call so that it can be correctly attributed
2015-04-26 11:22:07 +02:00
Ivan Zuzak
d75d270426
Add package name to Grim.deprecate call for configDefaults
2015-04-24 09:38:27 -07:00
Ivan Zuzak
0c25184624
Add package name to Grim.deprecate call for activationEvents
2015-04-24 09:38:27 -07:00
Kevin Sawicki
ec9310e94f
📝 Drop redundant notification
2015-04-23 16:10:31 -07:00
Kevin Sawicki
05fdc85282
Mark getNotifications as public and return an array copy
2015-04-23 16:10:31 -07:00
Kevin Sawicki
d4c1775cf7
Mark Notification public and add docs
2015-04-23 16:10:31 -07:00
Kevin Sawicki
1cd5bb0f8d
Mark NotificationManager public and add docs
2015-04-23 16:10:31 -07:00
Kevin Sawicki
0b24307096
Mark atom.notifications public
2015-04-23 16:10:31 -07:00
Kevin Sawicki
6e074b3695
Merge pull request #6477 from atom/iz-move-grim-deprecate-calls
...
Move some Grim deprecation calls to correctly attribute them with packages
2015-04-22 17:01:44 -07:00
Kevin Sawicki
626c9924fe
Remove deprecation about returning a disposable
2015-04-22 16:46:28 -07:00
Nathan Sobo
90d6eb7a13
Merge pull request #5217
2015-04-22 13:28:37 -06:00
Jess Lin
df070e9f1f
[Gutter] Add back includeDeprecatedAPIs gate on gutter type decorations
2015-04-22 11:10:50 -07:00
Kevin Sawicki
5f38719dfc
⬆️ scrollbar-style@3.1
2015-04-22 10:27:07 -07:00
Jess Lin
3949153390
[Gutter] Presenter should return gutter decorations for screen row range, not buffer row range
2015-04-22 07:29:00 -07:00
Jess Lin
6cbb344616
[Gutter] Remove emissary usage
2015-04-22 07:29:00 -07:00
Jess Lin
cdca9c3ef1
[Gutter] Fix coffeescript style issues
2015-04-22 07:29:00 -07:00
Jess Lin
14145e1197
[Gutter] removeDecorationInfoFromLineDecorationCaches -> removePropertiesFromLineDecorationCaches
2015-04-22 07:29:00 -07:00
Jess Lin
c7b5792773
[Gutter] Rename TextEditorPresenter::updateCustomGutterState -> ::updateGutterOrderState
2015-04-22 07:29:00 -07:00
Jess Lin
55c6a11c36
[Gutter] Add comment to explain avoided decoration update in presenter & remove test
2015-04-22 07:29:00 -07:00
Jess Lin
9abd0232ce
[Gutter] Remove ::getName from gutter components; save names in GutterContainerComponent
2015-04-22 07:29:00 -07:00
Jess Lin
6f66d2fd5d
[Gutter] Convert GutterContainerComponent::updateChildGutters -> ::reorderGutters
2015-04-22 07:28:59 -07:00
Jess Lin
3051470979
[Gutter] Make CustomGutterComponent::buildDecorationNode call into ::updateDecorationNode
2015-04-22 07:28:59 -07:00
Jess Lin
303cb4c368
[Gutter] Rename 'HTML' to 'Node' in some methods
2015-04-22 07:28:59 -07:00
Jess Lin
09d1b977de
[Gutter] Convert ! to 'not', && to 'and'
2015-04-22 07:28:59 -07:00
Jess Lin
c9cbef9a0c
[Gutter] Avoid reading position info off DOM nodes directly in CustomGutterComponent
2015-04-22 07:28:59 -07:00
Jess Lin
af629f8416
[Gutter] Remove check for null decorationState in CustomGutterComponent
2015-04-22 07:28:59 -07:00
Jess Lin
85188ced03
[Gutter] Move 'lineNumberGutter' state to nest under 'gutters' in the presenter state
2015-04-22 07:28:59 -07:00
Jess Lin
79b460a0ca
[Gutter] Add ::getDomNode method to all 'components'
2015-04-22 07:28:59 -07:00
Jess Lin
5dfa6b3e1e
[Gutter] Remove test-only CSS
2015-04-22 07:28:59 -07:00
