Kevin Sawicki
536beb0d40
Support setting number fields to 0
...
Previously entering 0 would end up as '0' in the config
value instead of as a numeric value.
2013-04-30 23:10:22 -07:00
Kevin Sawicki
986e5f9c7a
Default to 80 when editor.preferredLineLength <= 0
...
Previously any non-null value would be used as the target
column in the wrap guide and autoflow packages when really
80 should have been used if the value was non-postive.
Now config.getPositiveInt() is called with a default value
of 80 if the current value isn't already positive.
2013-04-30 22:37:02 -07:00
Kevin Sawicki
f417e898f6
Only call save on active item when it exists
...
Closes #529
2013-04-30 22:02:46 -07:00
Kevin Sawicki
047d9525e7
Ignore first modified event in config editor
...
This event comes from initially setting the text for the current
config value on the editor and was causing the config to be
immediately saved multiple times when opened.
2013-04-30 21:55:43 -07:00
Kevin Sawicki
ca7da8a0da
Don't set un-parseable numbers to 0 in the config
...
Previously if an integer or float field was empty it would
default to zero instead of undefined which made it inconsistent
with string value fields.
Now the config value is only set as a Number when it can be
parsed as one.
2013-04-30 21:36:27 -07:00
Kevin Sawicki
a788006d7c
Default editor.preferredLineLength config to 80
2013-04-30 15:03:46 -07:00
probablycorey
af5392b8ac
Add extra padding to the bottom of an editor's vertical scrollbar
...
This gives us some space when we scroll to the bottom of a file.
Similar to how MacVim works when using the mouse.
Closes #464
2013-04-30 11:52:28 -07:00
Corey Johnson
35b0e06260
💄
2013-04-30 11:52:28 -07:00
Corey Johnson
9180060920
Revert "Listen for mouse events on scrollView instead of renderedLines"
...
You can't listen on scroll view because that makes
it impossible to scroll using the scrollbar
Opens #464
This reverts commit fdae5fd89c
2013-04-29 15:07:38 -07:00
Corey Johnson
fdae5fd89c
Listen for mouse events on scrollView instead of renderedLines
...
It was not possible to click on the lower part of the last line
when the editor was scrollable and listening for mousedown events on renderedLines.
Closes #464
2013-04-29 14:59:23 -07:00
Corey Johnson & Kevin Sawicki
0d8a6782b3
Stop tokenizing line when the same rule is pushed more than once
...
Previously Rails classes would infinitly loop if the Ruby on Rails
grammar was loaded but the Ruby grammar had not been. This occurred
because a rule was continually pushing itself on the stack but never
advancing.
Now if the position does not advance and the last two rules in the
stack have the same scope the last rule is popped and the entire line
is tokenized with the current scopes.
Closes #524 #486
2013-04-29 12:10:40 -07:00
Corey Johnson
fe219ed159
💄
2013-04-29 12:10:40 -07:00
Kevin Sawicki
df6809e705
Bind meta-N to open a new untitled editor
2013-04-29 10:27:39 -07:00
Kevin Sawicki
71aa9802d5
Move default keys from keymap.coffee to atom.cson
2013-04-29 10:11:21 -07:00
Kevin Sawicki
53dde09523
Mark config panels as internal
...
The doc spec was failing since these classes were added with
no docs and weren't marked as internal so the coverage dropped
below 80%.
2013-04-27 07:40:06 -07:00
Kevin Sawicki
d2b513bd5e
Bind meta-_ to zoom out in image view
2013-04-27 07:19:34 -07:00
Kevin Sawicki
c54766a08a
Don't show indent guide in mini editor
2013-04-26 17:31:54 -07:00
probablycorey
8a7aa8083c
Add show inded guide
2013-04-26 15:36:58 -07:00
probablycorey
655fec2f18
Redraw editors when panel appears
...
If not done, the editors have zero height.
2013-04-26 15:36:58 -07:00
probablycorey
2d5bb8bd8b
Move open .atom button to config menu
2013-04-26 15:36:58 -07:00
probablycorey
bd7542cb0a
Use mini-editors instead of inputs
2013-04-26 15:36:58 -07:00
probablycorey
f06c9a5bc8
Don't respond to observe events when the editor value doesn't change
2013-04-26 15:36:58 -07:00
probablycorey
9f85ba4f7d
Empty editors trigger config to delete the associated config key
2013-04-26 15:36:58 -07:00
Corey Johnson & Nathan Sobo
b878be27a0
Revert to default font when setFontFamily is set to null/undefined
2013-04-26 15:36:58 -07:00
probablycorey
e72e1c9c56
Remove log
2013-04-26 15:36:57 -07:00
probablycorey
ecad6bc2a8
Don't allow float or int Editor's to have NaN as a value
2013-04-26 15:36:57 -07:00
probablycorey
cedea831f7
Config panel handles binding for Editors
2013-04-26 15:36:57 -07:00
probablycorey
1b4fbdb065
Allow html attributes to be applied to Editors
2013-04-26 15:36:57 -07:00
Corey Johnson & Nathan Sobo
c5cd39308d
Add "open .atom" button to general config view
2013-04-26 15:36:57 -07:00
Nathan Sobo
083e6f26bd
Style the general config panel w/ bootstrap
2013-04-26 15:36:57 -07:00
Nathan Sobo
232978ea9d
Themes can be disabled by clicking their 'x' icon in the enabled list
2013-04-26 15:36:14 -07:00
Nathan Sobo
5afe0a758c
Allow stylesheets with ' characters in their filename
2013-04-26 15:36:14 -07:00
Nathan Sobo
d3fa5b0f85
🙊
2013-04-26 15:36:13 -07:00
Nathan Sobo
ad0bcc3851
Update enabled themes list when config key is updated
2013-04-26 15:36:13 -07:00
Nathan Sobo
b110f430ee
Update 'config.themes' config key when enabled themes list is sorted
2013-04-26 15:36:13 -07:00
Nathan Sobo
7993e3ab39
WIP: don't allow duplicates to be dragged
2013-04-26 15:36:13 -07:00
Nathan Sobo
540c543984
Add a styled but non-functional themes config panel
2013-04-26 15:36:13 -07:00
Nathan Sobo
af02d9f0fd
Use config defaults to default themes to atom-dark-*
2013-04-26 15:36:13 -07:00
Nathan Sobo
36d0b2c735
No need for jQuery UI in package config panel
2013-04-26 15:36:13 -07:00
Nathan Sobo
0d520e9930
Add a package config panel with the list of enabled packages
2013-04-26 15:36:13 -07:00
Nathan Sobo
ba6d3a1124
Use bootstrap to style editor config panel
2013-04-26 15:36:13 -07:00
Nathan Sobo
ac65e288df
Pull config stylesheet into atom.less
2013-04-26 15:36:12 -07:00
Nathan Sobo
c5e34c60f8
Don't explode if 'core.themes' config key is undefined
2013-04-26 15:36:12 -07:00
Nathan Sobo
5a291e8188
Use bootstrap stacked nav-pills for panels menu in config window
2013-04-26 15:36:12 -07:00
Nathan Sobo
0af9564d1a
Styling 💄
2013-04-26 15:36:12 -07:00
Nathan Sobo
21f83ea938
Add 'x' icon to enabled themes list
2013-04-26 15:36:12 -07:00
Nathan Sobo
81c1769770
Allow available themes to be dragged to sortable 'enabled themes' list
...
Still not doing anything with the sort update events.
2013-04-26 15:36:12 -07:00
Nathan Sobo
0620d19f26
Require jquery-ui-sortable and -draggable in the general config panel.
...
This commit has a hack to make window.jQuery available during the
duration of the requiring of jquery-ui. Once we're done requiring
jQuery, the global is removed from window once again.
Issue #494 has an alternative idea of enhancing require to allow the
requiring script to specify the value of global variables in the script
being required.
2013-04-26 15:36:12 -07:00
Nathan Sobo
46acb6da2c
Style themes and packages lists
2013-04-26 15:36:12 -07:00
Nathan Sobo
e8a66ded01
🙊
2013-04-26 15:36:12 -07:00
